https://github.com/torvalds/linux
Revision 8fc75bed96bb94e23ca51bd9be4daf65c57697bf authored by Trond Myklebust on 29 January 2019, 20:52:55 UTC, committed by Anna Schumaker on 29 January 2019, 21:33:24 UTC
Ensure that we return the fatal error value that caused us to exit
nfs_page_async_flush().

Fixes: c373fff7bd25 ("NFSv4: Don't special case "launder"")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Cc: stable@vger.kernel.org # v4.12+
Reviewed-by: Benjamin Coddington <bcodding@redhat.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
1 parent 80ff001
Raw File
Tip revision: 8fc75bed96bb94e23ca51bd9be4daf65c57697bf authored by Trond Myklebust on 29 January 2019, 20:52:55 UTC
NFS: Fix up return value on fatal errors in nfs_page_async_flush()
Tip revision: 8fc75be
percpu-rw-semaphore.txt
====================
Percpu rw semaphores
====================

Percpu rw semaphores is a new read-write semaphore design that is
optimized for locking for reading.

The problem with traditional read-write semaphores is that when multiple
cores take the lock for reading, the cache line containing the semaphore
is bouncing between L1 caches of the cores, causing performance
degradation.

Locking for reading is very fast, it uses RCU and it avoids any atomic
instruction in the lock and unlock path. On the other hand, locking for
writing is very expensive, it calls synchronize_rcu() that can take
hundreds of milliseconds.

The lock is declared with "struct percpu_rw_semaphore" type.
The lock is initialized percpu_init_rwsem, it returns 0 on success and
-ENOMEM on allocation failure.
The lock must be freed with percpu_free_rwsem to avoid memory leak.

The lock is locked for read with percpu_down_read, percpu_up_read and
for write with percpu_down_write, percpu_up_write.

The idea of using RCU for optimized rw-lock was introduced by
Eric Dumazet <eric.dumazet@gmail.com>.
The code was written by Mikulas Patocka <mpatocka@redhat.com>
back to top