https://github.com/torvalds/linux
Revision 8fcb2312d1e3300e81aa871aad00d4c038cfc184 authored by Olof Johansson on 16 November 2018, 23:08:00 UTC, committed by Linus Torvalds on 18 November 2018, 18:15:09 UTC
The existing code triggered an invalid warning about 'rq' possibly being
used uninitialized.  Instead of doing the silly warning suppression by
initializa it to NULL, refactor the code to bail out early instead.

Warning was:

  kernel/sched/psi.c: In function `cgroup_move_task':
  kernel/sched/psi.c:639:13: warning: `rq' may be used uninitialized in this function [-Wmaybe-uninitialized]

Link: http://lkml.kernel.org/r/20181103183339.8669-1-olof@lixom.net
Fixes: 2ce7135adc9ad ("psi: cgroup support")
Signed-off-by: Olof Johansson <olof@lixom.net>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent ca0246b
History
Tip revision: 8fcb2312d1e3300e81aa871aad00d4c038cfc184 authored by Olof Johansson on 16 November 2018, 23:08:00 UTC
kernel/sched/psi.c: simplify cgroup_move_task()
Tip revision: 8fcb231

back to top