https://github.com/torvalds/linux
Revision 8fcb2312d1e3300e81aa871aad00d4c038cfc184 authored by Olof Johansson on 16 November 2018, 23:08:00 UTC, committed by Linus Torvalds on 18 November 2018, 18:15:09 UTC
The existing code triggered an invalid warning about 'rq' possibly being
used uninitialized. Instead of doing the silly warning suppression by
initializa it to NULL, refactor the code to bail out early instead.
Warning was:
kernel/sched/psi.c: In function `cgroup_move_task':
kernel/sched/psi.c:639:13: warning: `rq' may be used uninitialized in this function [-Wmaybe-uninitialized]
Link: http://lkml.kernel.org/r/20181103183339.8669-1-olof@lixom.net
Fixes: 2ce7135adc9ad ("psi: cgroup support")
Signed-off-by: Olof Johansson <olof@lixom.net>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent ca0246b
Tip revision: 8fcb2312d1e3300e81aa871aad00d4c038cfc184 authored by Olof Johansson on 16 November 2018, 23:08:00 UTC
kernel/sched/psi.c: simplify cgroup_move_task()
kernel/sched/psi.c: simplify cgroup_move_task()
Tip revision: 8fcb231
| File | Mode | Size |
|---|---|---|
| basic | ||
| coccinelle | ||
| dtc | ||
| gcc-plugins | ||
| gdb | ||
| genksyms | ||
| kconfig | ||
| ksymoops | ||
| mod | ||
| package | ||
| selinux | ||
| tracing | ||
| .gitignore | -rw-r--r-- | 168 bytes |
| Kbuild.include | -rw-r--r-- | 15.0 KB |
| Kconfig.include | -rw-r--r-- | 871 bytes |
| Lindent | -rwxr-xr-x | 502 bytes |
| Makefile | -rw-r--r-- | 1.6 KB |
| Makefile.asm-generic | -rw-r--r-- | 1.2 KB |
| Makefile.build | -rw-r--r-- | 18.1 KB |
| Makefile.clean | -rw-r--r-- | 2.8 KB |
| Makefile.dtbinst | -rw-r--r-- | 1.1 KB |
| Makefile.extrawarn | -rw-r--r-- | 2.7 KB |
| Makefile.gcc-plugins | -rw-r--r-- | 2.3 KB |
| Makefile.headersinst | -rw-r--r-- | 4.0 KB |
| Makefile.host | -rw-r--r-- | 6.3 KB |
| Makefile.kasan | -rw-r--r-- | 1.4 KB |
| Makefile.kcov | -rw-r--r-- | 319 bytes |
| Makefile.lib | -rw-r--r-- | 14.6 KB |
| Makefile.modbuiltin | -rw-r--r-- | 1.7 KB |
| Makefile.modinst | -rw-r--r-- | 1.1 KB |
| Makefile.modpost | -rw-r--r-- | 5.3 KB |
| Makefile.modsign | -rw-r--r-- | 897 bytes |
| Makefile.ubsan | -rw-r--r-- | 926 bytes |
| adjust_autoksyms.sh | -rwxr-xr-x | 2.9 KB |
| asn1_compiler.c | -rw-r--r-- | 35.5 KB |
| bin2c.c | -rw-r--r-- | 743 bytes |
| bloat-o-meter | -rwxr-xr-x | 3.2 KB |
| bootgraph.pl | -rwxr-xr-x | 6.3 KB |
| bpf_helpers_doc.py | -rwxr-xr-x | 15.5 KB |
| cc-can-link.sh | -rwxr-xr-x | 166 bytes |
| check_extable.sh | -rwxr-xr-x | 4.9 KB |
| checkincludes.pl | -rwxr-xr-x | 1.9 KB |
| checkkconfigsymbols.py | -rwxr-xr-x | 15.5 KB |
| checkpatch.pl | -rwxr-xr-x | 194.7 KB |
| checkstack.pl | -rwxr-xr-x | 5.2 KB |
| checksyscalls.sh | -rwxr-xr-x | 5.7 KB |
| checkversion.pl | -rwxr-xr-x | 1.9 KB |
| clang-version.sh | -rwxr-xr-x | 636 bytes |
| cleanfile | -rwxr-xr-x | 3.5 KB |
| cleanpatch | -rwxr-xr-x | 5.1 KB |
| coccicheck | -rwxr-xr-x | 7.2 KB |
| config | -rwxr-xr-x | 4.5 KB |
| conmakehash.c | -rw-r--r-- | 6.0 KB |
| const_structs.checkpatch | -rw-r--r-- | 964 bytes |
| decode_stacktrace.sh | -rwxr-xr-x | 3.7 KB |
| decodecode | -rwxr-xr-x | 2.5 KB |
| depmod.sh | -rwxr-xr-x | 1.3 KB |
| diffconfig | -rwxr-xr-x | 3.7 KB |
| documentation-file-ref-check | -rwxr-xr-x | 3.7 KB |
| export_report.pl | -rwxr-xr-x | 4.5 KB |
| extract-cert.c | -rw-r--r-- | 3.5 KB |
| extract-ikconfig | -rwxr-xr-x | 1.7 KB |
| extract-module-sig.pl | -rwxr-xr-x | 3.7 KB |
| extract-sys-certs.pl | -rwxr-xr-x | 3.7 KB |
| extract-vmlinux | -rwxr-xr-x | 1.7 KB |
| extract_xc3028.pl | -rwxr-xr-x | 44.6 KB |
| faddr2line | -rwxr-xr-x | 6.2 KB |
| file-size.sh | -rwxr-xr-x | 86 bytes |
| find-unused-docs.sh | -rwxr-xr-x | 1.3 KB |
| gcc-goto.sh | -rwxr-xr-x | 530 bytes |
| gcc-ld | -rwxr-xr-x | 711 bytes |
| gcc-plugin.sh | -rwxr-xr-x | 1.1 KB |
| gcc-version.sh | -rwxr-xr-x | 857 bytes |
| gcc-x86_32-has-stack-protector.sh | -rwxr-xr-x | 173 bytes |
| gcc-x86_64-has-stack-protector.sh | -rwxr-xr-x | 198 bytes |
| get_dvb_firmware | -rwxr-xr-x | 25.2 KB |
| get_maintainer.pl | -rwxr-xr-x | 65.8 KB |
| gfp-translate | -rwxr-xr-x | 1.7 KB |
| headerdep.pl | -rwxr-xr-x | 3.5 KB |
| headers.sh | -rwxr-xr-x | 512 bytes |
| headers_check.pl | -rwxr-xr-x | 3.7 KB |
| headers_install.sh | -rwxr-xr-x | 1.4 KB |
| insert-sys-cert.c | -rw-r--r-- | 8.9 KB |
| kallsyms.c | -rw-r--r-- | 18.0 KB |
| kernel-doc | -rwxr-xr-x | 60.6 KB |
| ld-version.sh | -rwxr-xr-x | 269 bytes |
| leaking_addresses.pl | -rwxr-xr-x | 12.9 KB |
| link-vmlinux.sh | -rwxr-xr-x | 6.9 KB |
| makelst | -rwxr-xr-x | 808 bytes |
| markup_oops.pl | -rwxr-xr-x | 8.1 KB |
| mkcompile_h | -rwxr-xr-x | 2.5 KB |
| mkmakefile | -rwxr-xr-x | 866 bytes |
| mksysmap | -rwxr-xr-x | 1.3 KB |
| mkuboot.sh | -rwxr-xr-x | 414 bytes |
| module-common.lds | -rw-r--r-- | 901 bytes |
| namespace.pl | -rwxr-xr-x | 13.0 KB |
| objdiff | -rwxr-xr-x | 2.8 KB |
| parse-maintainers.pl | -rw-r--r-- | 3.7 KB |
| patch-kernel | -rwxr-xr-x | 9.9 KB |
| pnmtologo.c | -rw-r--r-- | 11.9 KB |
| profile2linkerlist.pl | -rwxr-xr-x | 414 bytes |
| prune-kernel | -rwxr-xr-x | 708 bytes |
| recordmcount.c | -rw-r--r-- | 16.7 KB |
| recordmcount.h | -rw-r--r-- | 16.4 KB |
| recordmcount.pl | -rwxr-xr-x | 18.4 KB |
| setlocalversion | -rwxr-xr-x | 3.9 KB |
| show_delta | -rwxr-xr-x | 3.0 KB |
| sign-file.c | -rw-r--r-- | 9.8 KB |
| sortextable.c | -rw-r--r-- | 8.4 KB |
| sortextable.h | -rw-r--r-- | 5.5 KB |
| spdxcheck.py | -rwxr-xr-x | 9.5 KB |
| spelling.txt | -rw-r--r-- | 26.7 KB |
| sphinx-pre-install | -rwxr-xr-x | 14.0 KB |
| split-man.pl | -rwxr-xr-x | 600 bytes |
| stackdelta | -rwxr-xr-x | 1.8 KB |
| stackusage | -rwxr-xr-x | 794 bytes |
| subarch.include | -rw-r--r-- | 641 bytes |
| tags.sh | -rwxr-xr-x | 9.5 KB |
| unifdef.c | -rw-r--r-- | 34.8 KB |
| ver_linux | -rwxr-xr-x | 2.7 KB |
| xen-hypercalls.sh | -rw-r--r-- | 386 bytes |
| xz_wrap.sh | -rwxr-xr-x | 562 bytes |
Computing file changes ...
