Revision 8fe2cbe104c19a4c2fb569efefc3a90a8da8316b authored by Quentin Monnet on 19 May 2022, 14:56:27 UTC, committed by Gilberto Bertin on 31 May 2022, 14:32:16 UTC
[ upstream commit 70676ec2c0f50074238b9da9edbe5b38a8f3544d ]
With "make render-docs-live-preview", we use the cilium/docs-builder
image to build a preview of the documentation, to serve it locally, and
to watch the source files for changes to update automatically the
preview.
When the Docker image is present locally, the command uses it. When this
is not the case, it pulls it from Docker, in its ":latest" version by
default. This can be an issue due to commit 0da7224218ab ("ci: pin down
image for documentation workflow"), where we pinned down the
docs-builder image to use in the CI. Since this commit, the reference
image is not longer ":latest", but the tag in use in the CI files. As a
consequence, the live preview may attempt to use an outdated version of
the image. This is currently the case: running the command with no local
image raises an error about a missing "myst_parser" extension, which is
not present on the version tagged with ":latest".
To fix this, we mark builder-image as a dependency for the
render-docs-live-preview target, so that the image gets built locally.
Reported-by: Yoyo Wu <yoyo19980720@163.com>
Signed-off-by: Quentin Monnet <quentin@isovalent.com>
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
1 parent 38bf905
.gitignore
# Compiled Object files, Static and Dynamic libs (Shared Objects)
*.o
*.a
*.so
*.so.*
# LLVM IR files
*.ll
*.ll-*
# Folders
_obj
_test
_build/
# Architecture specific extensions/prefixes
*.cgo1.go
*.cgo2.c
_cgo_defun.c
_cgo_gotypes.go
_cgo_export.*
_testmain.go
*.exe
*.test
*.prof
*.swn
*.swp
.vagrant
vagrant.kubeconfig
coverage.out
coverage-all.out
coverage-all.html
.DS_Store
.idea/
*.plist
*_bash_completion
*.swo
outgoing
*cscope.files
*cscope.out
*cscope.in.out
*cscope.po.out
*tags
.gdb_history
man/
tests/cilium-files
test/test_results*
test/.vagrant
test/tmp.yaml
test/*_manifest.yaml
test/*.xml
test/*.json
test/*.log
test/bpf/_results
test/cilium-[0-9a-f]*.yaml
test/*tmp
test/cilium-istioctl
# generated test files
test/k8sT/manifests/cnp-second-namespaces.yaml
test/cilium.conf.ginkgo
external-workload-ca.crt
external-workload-tls.crt
external-workload-tls.key
# GKE temporary files
test/gke/cluster-name
test/gke/cluster-uri
test/gke/cluster-version
test/gke/gke-kubeconfig
test/gke/resize-kubeconfig
test/gke/registry-adder.yaml
# Emacs backup files
*~
# generated from make targets
*.ok
*.build_all
LICENSE.all
# Temporary files that allow build containers/VMs work without git
# Not to be ignored by docker.
GIT_VERSION
# During image builds following files get created
.buildx
.buildx_builder
Computing file changes ...
