Revision 90fd131afc565159c9e0ea742f082b337e10f8c6 authored by Florian Westphal on 23 July 2018, 10:47:14 UTC, committed by Pablo Neira Ayuso on 23 July 2018, 22:36:33 UTC
Shaochun Chen points out we leak dumper filter state allocations
stored in dump_control->data in case there is an error before netlink sets
cb_running (after which ->done will be called at some point).

In order to fix this, add .start functions and do the allocations
there.

->done is going to clean up, and in case error occurs before
->start invocation no cleanups need to be done anymore.

Reported-by: shaochun chen <cscnull@gmail.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Acked-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
1 parent 6613b61
History
File Mode Size
Kconfig -rw-r--r-- 8.3 KB
Kconfig.debug -rw-r--r-- 2.2 KB
Makefile -rw-r--r-- 516 bytes
rcu.h -rw-r--r-- 15.4 KB
rcu_segcblist.c -rw-r--r-- 13.7 KB
rcu_segcblist.h -rw-r--r-- 4.7 KB
rcuperf.c -rw-r--r-- 18.9 KB
rcutorture.c -rw-r--r-- 55.0 KB
srcutiny.c -rw-r--r-- 5.8 KB
srcutree.c -rw-r--r-- 42.6 KB
sync.c -rw-r--r-- 7.1 KB
tiny.c -rw-r--r-- 6.2 KB
tree.c -rw-r--r-- 127.7 KB
tree.h -rw-r--r-- 19.7 KB
tree_exp.h -rw-r--r-- 24.3 KB
tree_plugin.h -rw-r--r-- 80.2 KB
update.c -rw-r--r-- 29.8 KB

back to top