Skip to main content

Browse the archive

Revision 911204cd7624a4e9f94e0552c11c8cbb8c3771ca authored by Piotr Tabor on 28 April 2021, 20:46:42 UTC, committed by Piotr Tabor on 29 April 2021, 09:51:24 UTC 
Fix `ETCDCTL_API=2 etcdctl backup --with-v3` consistent index consistency
 
Prior to this CL, `ETCDCTL_API=2 etcdctl backup --with-v3` was readacting WAL log
(by removal of some entries), but was NOT updating consistent_index in the backend.
Also the WAL editing logic was buggy, as it didn't took in consideration the fact
that when TERM changes, there can be entries with duplicated indexes in
the log. So its NOT sufficient to subtract number of removed entries to
get accurate log indexes.

The PR replaces removing and shifting of WAL entries with replacing them with an no-op entries.
Thanks to this consistent-index references are staying up to date.

The PR also:
  - updates 'verification' logic to check whether consistent_index does not lag befor last snapshot
  - env-gated execution of verification framework in `etcdctl backup`.

Tested with:
```
(./build.sh && cd tests && EXPECT_DEBUG=TRUE 'env' 'go' 'test' '-timeout=300m' 'go.etcd.io/etcd/tests/v3/e2e' -run=TestCtlV2Backup --count=1000 2>&1 | tee TestCtlV2BackupV3.log)
```
1 parent adc365e
Raw File
CHANGELOG-2.3.md 


<hr>


## [v2.3.8](https://github.com/etcd-io/etcd/releases/tag/v2.3.8) (2017-02-17)

See [code changes](https://github.com/etcd-io/etcd/compare/v2.3.7...v2.3.8).

### Go

- Compile with [*Go 1.7.5*](https://golang.org/doc/devel/release.html#go1.7).


<hr>
back to top