Skip to main content

Browse the archive

Revision 9334d97a1fd4c4efb842d014dc71ac65b4a57363 authored by Tim Horner on 04 June 2024, 14:14:29 UTC, committed by Dylan Reimerink on 12 June 2024, 08:17:06 UTC 
l2-discovery: fix health reporting for link updater
 
As-is, when l2 neighbor discovery is enabled, the
node-neighbor-link-updater controller fails with "invalid node spec
found in queue". This is due to a bug in the controller's DoFunc, where
an empty list is treated the same as an invalid queue entry.

When this controller fails, `cilium status` reports errors for all nodes
in the cluster similar to the following:

```
cilium             cilium-mgstt    controller node-neighbor-link-updater is failing since 21s (49x): invalid node spec found in queue: (*manager.nodeQueueEntry)(nil)
```

To differentiate between an empty queue and a nil item, the queue's
`pop` method now also returns a bool to indicate whether an element was
successfully retrieved from the queue.

Fixes: #8d525fe

Signed-off-by: Tim Horner <timothy.horner@isovalent.com>
1 parent 22b3e82
Raw File
CODE_OF_CONDUCT.md 
## Community Code of Conduct v1.0

This is Code of Conduct is based on the [CNCF Code of
Conduct](https://github.com/cncf/foundation/blob/main/code-of-conduct.md).
See the referred document for translated versions into different languages. The
text below is modified with Cilium community specific contact details.

### Contributor Code of Conduct

As contributors and maintainers of this project, and in the interest of fostering
an open and welcoming community, we pledge to respect all people who contribute
through reporting issues, posting feature requests, updating documentation,
submitting pull requests or patches, and other activities.

We are committed to making participation in this project a harassment-free experience for
everyone, regardless of level of experience, gender, gender identity and expression,
sexual orientation, disability, personal appearance, body size, race, ethnicity, age,
religion, or nationality.

Examples of unacceptable behavior by participants include:

* The use of sexualized language or imagery
* Personal attacks
* Trolling or insulting/derogatory comments
* Public or private harassment
* Publishing others' private information, such as physical or electronic addresses,
 without explicit permission
* Other unethical or unprofessional conduct.

Project maintainers have the right and responsibility to remove, edit, or reject
comments, commits, code, wiki edits, issues, and other contributions that are not
aligned to this Code of Conduct. By adopting this Code of Conduct, project maintainers
commit themselves to fairly and consistently applying these principles to every aspect
of managing this project. Project maintainers who do not follow or enforce the Code of
Conduct may be permanently removed from the project team.

This code of conduct applies both within project spaces and in public spaces
when an individual is representing the project or its community.

Instances of abusive, harassing, or otherwise unacceptable behavior may be
reported by contacting the code of conduct team via 
[conduct@cilium.io](mailto:conduct@cilium.io).

This Code of Conduct is adapted from the Contributor Covenant
(http://contributor-covenant.org), version 1.2.0, available at
http://contributor-covenant.org/version/1/2/0/
back to top