Revision 9334d97a1fd4c4efb842d014dc71ac65b4a57363 authored by Tim Horner on 04 June 2024, 14:14:29 UTC, committed by Dylan Reimerink on 12 June 2024, 08:17:06 UTC
As-is, when l2 neighbor discovery is enabled, the node-neighbor-link-updater controller fails with "invalid node spec found in queue". This is due to a bug in the controller's DoFunc, where an empty list is treated the same as an invalid queue entry. When this controller fails, `cilium status` reports errors for all nodes in the cluster similar to the following: ``` cilium cilium-mgstt controller node-neighbor-link-updater is failing since 21s (49x): invalid node spec found in queue: (*manager.nodeQueueEntry)(nil) ``` To differentiate between an empty queue and a nil item, the queue's `pop` method now also returns a bool to indicate whether an element was successfully retrieved from the queue. Fixes: #8d525fe Signed-off-by: Tim Horner <timothy.horner@isovalent.com>
1 parent 22b3e82
CONTRIBUTING.md
# How to Contribute
## To Cilium/Hubble
See the [Developer / Contributor
Guide](https://docs.cilium.io/en/stable/contributing/development/contributing_guide/) for detailed information on
how to contribute, get started and find good first issues.
## To the cilium.io website
Please see the [cilium.io website contributing guide](https://github.com/cilium/cilium.io/blob/main/CONTRIBUTING.md) for detailed
information on how to add blogs, trainings, and other resources.
## To the Cilium documentation
Please see the [Cilium documentation contributing guide](https://docs.cilium.io/en/stable/contributing/docs/) for detailed
information on how to contribute to the Cilium documentation.
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...