https://github.com/shader-slang/slang
Revision 935b629448fedc187243bfe88d4149bf30d89c05 authored by Tim Foley on 23 January 2019, 17:13:03 UTC, committed by GitHub on 23 January 2019, 17:13:03 UTC
There was a bug in the logic for emitting initial IR, such that it was neglecting to emit "methods" (member functions) unless they were also referenced by a non-member (global) function, or were needed to satisfy an interface requirement. This would only matter for `import`ed modules, since for non-`import`ed code, anything relevant would be referenced by the entry point so that the problem would never surface. This change fixes the underlying problem by adding a step to the IR lowering pass called `ensureAllDeclsRec` that makes sure that not only global-scope declarations, but also anything nested under a `struct` type gets emitted to the initial IR module. There are also a few unrelated fixes in this PR, which are things I ran into while making the fix: * Deleted support for the (long gone) `IRDeclRef` type in our `slang.natvis` file * Added support for visualizing the value of IR string and integer literals when they appear in the debugger * Fixed IR dumping logic to not skip emitting `struct` and `interface` instructions. Switching those to inherit from `IRType` accidentally affected how they get printed in IR dumps by default. * Fixed up the IR linking logic so that it correctly takes `[export]` decorations into account, so that an exported definition will always be taken over any other (unless the latter is more specialized for the target). I initially implemented this in an attempt to fix the original issue, but found it wasn't a fix for the root cause. It is still a better approach than what was implemented previously, so I'm leaving it in place.
1 parent a08a314
Tip revision: 935b629448fedc187243bfe88d4149bf30d89c05 authored by Tim Foley on 23 January 2019, 17:13:03 UTC
Fix IR emit logic for methods in `struct` types (#791)
Fix IR emit logic for methods in `struct` types (#791)
Tip revision: 935b629
.editorconfig
# This file sets up basic text editor behavior
# using EditorConfig: http://EditorConfig.org.
#
# Some editors will import and use the settings from
# this file automatically, while others need a plugin.
# Editors are supposed to search upwards from a source
# file to find configuration settings until they see
# a "root" file. This file should be a root:
#
root = true
# Shared configuration for all C/C++ and Slang code
#
[*.{c,cpp,h,slang}]
# Use UTF-8 encoding
#
charset = utf-8
# Indent using 4 spaces.
#
indent_style = space
indent_size = 4
# Insert a newline at the end of the file
# if one is missing (this used to be officially
# required by C, but it is also just a tidyness thing)
#
insert_final_newline = true
# Remove any extra whitespace characters at the
# end of a line. This is just for tidyness, to
# minimize the chances of introducing whitspace
# diffs that are hard to spot.
#
trim_trailing_whitespace = true
Computing file changes ...
