Revision 94a4a4fe4c696413932eed8bdec46574de9576b8 authored by Guillaume Nault on 08 March 2022, 22:15:03 UTC, committed by Jakub Kicinski on 10 March 2022, 04:23:32 UTC
When using "run_cmd <command> &", then "$!" refers to the PID of the subshell used to run <command>, not the command itself. Therefore nettest_pids actually doesn't contain the list of the nettest commands running in the background. So cleanup() can't kill them and the nettest processes run until completion (fortunately they have a 5s timeout). Fix this by defining a new command for running processes in the background, for which "$!" really refers to the PID of the command run. Also, double quote variables on the modified lines, to avoid shellcheck warnings. Fixes: ece1278a9b81 ("selftests: net: add ESP-in-UDP PMTU test") Signed-off-by: Guillaume Nault <gnault@redhat.com> Reviewed-by: Shuah Khan <skhan@linuxfoundation.org> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 18dfc66
File | Mode | Size |
---|---|---|
ext | ||
Kconfig | -rw-r--r-- | 1.9 KB |
Makefile | -rw-r--r-- | 749 bytes |
array.c | -rw-r--r-- | 1.2 KB |
hda_bus_type.c | -rw-r--r-- | 2.1 KB |
hdac_bus.c | -rw-r--r-- | 7.4 KB |
hdac_component.c | -rw-r--r-- | 9.7 KB |
hdac_controller.c | -rw-r--r-- | 17.0 KB |
hdac_device.c | -rw-r--r-- | 27.5 KB |
hdac_i915.c | -rw-r--r-- | 4.2 KB |
hdac_regmap.c | -rw-r--r-- | 15.2 KB |
hdac_stream.c | -rw-r--r-- | 21.1 KB |
hdac_sysfs.c | -rw-r--r-- | 11.2 KB |
hdmi_chmap.c | -rw-r--r-- | 24.2 KB |
intel-dsp-config.c | -rw-r--r-- | 13.6 KB |
intel-nhlt.c | -rw-r--r-- | 5.7 KB |
intel-sdw-acpi.c | -rw-r--r-- | 4.7 KB |
local.h | -rw-r--r-- | 1.4 KB |
trace.c | -rw-r--r-- | 107 bytes |
trace.h | -rw-r--r-- | 2.1 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...