Revision 94a4a4fe4c696413932eed8bdec46574de9576b8 authored by Guillaume Nault on 08 March 2022, 22:15:03 UTC, committed by Jakub Kicinski on 10 March 2022, 04:23:32 UTC
When using "run_cmd <command> &", then "$!" refers to the PID of the
subshell used to run <command>, not the command itself. Therefore
nettest_pids actually doesn't contain the list of the nettest commands
running in the background. So cleanup() can't kill them and the nettest
processes run until completion (fortunately they have a 5s timeout).

Fix this by defining a new command for running processes in the
background, for which "$!" really refers to the PID of the command run.

Also, double quote variables on the modified lines, to avoid shellcheck
warnings.

Fixes: ece1278a9b81 ("selftests: net: add ESP-in-UDP PMTU test")
Signed-off-by: Guillaume Nault <gnault@redhat.com>
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 18dfc66
History
File Mode Size
ac97
ali5451
asihpi
au88x0
aw2
ca0106
cs46xx
cs5535audio
ctxfi
echoaudio
emu10k1
hda
ice1712
korg1212
lola
lx6464es
mixart
nm256
oxygen
pcxhr
riptide
rme9652
trident
vx222
ymfpci
Kconfig -rw-r--r-- 25.4 KB
Makefile -rw-r--r-- 2.2 KB
ad1889.c -rw-r--r-- 23.0 KB
ad1889.h -rw-r--r-- 7.9 KB
ak4531_codec.c -rw-r--r-- 16.3 KB
als300.c -rw-r--r-- 19.7 KB
als4000.c -rw-r--r-- 29.0 KB
atiixp.c -rw-r--r-- 43.0 KB
atiixp_modem.c -rw-r--r-- 33.1 KB
azt3328.c -rw-r--r-- 79.8 KB
azt3328.h -rw-r--r-- 15.5 KB
bt87x.c -rw-r--r-- 27.6 KB
cmipci.c -rw-r--r-- 99.0 KB
cs4281.c -rw-r--r-- 61.4 KB
cs5530.c -rw-r--r-- 5.5 KB
ens1370.c -rw-r--r-- 75.4 KB
ens1371.c -rw-r--r-- 38 bytes
es1938.c -rw-r--r-- 53.0 KB
es1968.c -rw-r--r-- 76.5 KB
fm801.c -rw-r--r-- 40.0 KB
intel8x0.c -rw-r--r-- 87.4 KB
intel8x0m.c -rw-r--r-- 34.4 KB
maestro3.c -rw-r--r-- 79.7 KB
rme32.c -rw-r--r-- 55.5 KB
rme96.c -rw-r--r-- 69.1 KB
sis7019.c -rw-r--r-- 37.6 KB
sis7019.h -rw-r--r-- 12.7 KB
sonicvibes.c -rw-r--r-- 48.4 KB
via82xx.c -rw-r--r-- 74.7 KB
via82xx_modem.c -rw-r--r-- 32.0 KB

back to top