Revision 94a4a4fe4c696413932eed8bdec46574de9576b8 authored by Guillaume Nault on 08 March 2022, 22:15:03 UTC, committed by Jakub Kicinski on 10 March 2022, 04:23:32 UTC
When using "run_cmd <command> &", then "$!" refers to the PID of the
subshell used to run <command>, not the command itself. Therefore
nettest_pids actually doesn't contain the list of the nettest commands
running in the background. So cleanup() can't kill them and the nettest
processes run until completion (fortunately they have a 5s timeout).
Fix this by defining a new command for running processes in the
background, for which "$!" really refers to the PID of the command run.
Also, double quote variables on the modified lines, to avoid shellcheck
warnings.
Fixes: ece1278a9b81 ("selftests: net: add ESP-in-UDP PMTU test")
Signed-off-by: Guillaume Nault <gnault@redhat.com>
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 18dfc66
| File | Mode | Size |
|---|---|---|
| Makefile | -rw-r--r-- | 127 bytes |
| lx6464es.c | -rw-r--r-- | 25.9 KB |
| lx6464es.h | -rw-r--r-- | 2.3 KB |
| lx_core.c | -rw-r--r-- | 28.0 KB |
| lx_core.h | -rw-r--r-- | 5.8 KB |
| lx_defs.h | -rw-r--r-- | 13.6 KB |
Computing file changes ...
