Revision 94a4a4fe4c696413932eed8bdec46574de9576b8 authored by Guillaume Nault on 08 March 2022, 22:15:03 UTC, committed by Jakub Kicinski on 10 March 2022, 04:23:32 UTC
When using "run_cmd <command> &", then "$!" refers to the PID of the
subshell used to run <command>, not the command itself. Therefore
nettest_pids actually doesn't contain the list of the nettest commands
running in the background. So cleanup() can't kill them and the nettest
processes run until completion (fortunately they have a 5s timeout).

Fix this by defining a new command for running processes in the
background, for which "$!" really refers to the PID of the command run.

Also, double quote variables on the modified lines, to avoid shellcheck
warnings.

Fixes: ece1278a9b81 ("selftests: net: add ESP-in-UDP PMTU test")
Signed-off-by: Guillaume Nault <gnault@redhat.com>
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 18dfc66
History
File Mode Size
Makefile -rw-r--r-- 470 bytes
ak4396.h -rw-r--r-- 1.1 KB
cm9780.h -rw-r--r-- 1.6 KB
cs2000.h -rw-r--r-- 2.3 KB
cs4245.h -rw-r--r-- 2.9 KB
cs4362a.h -rw-r--r-- 2.0 KB
cs4398.h -rw-r--r-- 2.0 KB
oxygen.c -rw-r--r-- 22.7 KB
oxygen.h -rw-r--r-- 7.3 KB
oxygen_io.c -rw-r--r-- 7.3 KB
oxygen_lib.c -rw-r--r-- 24.1 KB
oxygen_mixer.c -rw-r--r-- 31.5 KB
oxygen_pcm.c -rw-r--r-- 22.0 KB
oxygen_regs.h -rw-r--r-- 15.7 KB
pcm1796.h -rw-r--r-- 1.5 KB
se6x.c -rw-r--r-- 3.6 KB
virtuoso.c -rw-r--r-- 2.3 KB
wm8766.h -rw-r--r-- 2.0 KB
wm8776.h -rw-r--r-- 4.3 KB
wm8785.h -rw-r--r-- 1.2 KB
xonar.h -rw-r--r-- 1.6 KB
xonar_cs43xx.c -rw-r--r-- 11.9 KB
xonar_dg.c -rw-r--r-- 7.9 KB
xonar_dg.h -rw-r--r-- 1.6 KB
xonar_dg_mixer.c -rw-r--r-- 12.3 KB
xonar_hdmi.c -rw-r--r-- 2.9 KB
xonar_lib.c -rw-r--r-- 3.2 KB
xonar_pcm179x.c -rw-r--r-- 34.3 KB
xonar_wm87x6.c -rw-r--r-- 37.8 KB

back to top