Revision 963ad94853000ab100f5ff19eea80095660d41b4 authored by Nikolay Aleksandrov on 22 July 2015, 11:03:40 UTC, committed by David S. Miller on 26 July 2015, 23:27:22 UTC
Since slave_changelink support was added there have been a few race
conditions when using br_setport() since some of the port functions it
uses require the bridge lock. It is very easy to trigger a lockup due to
some internal spin_lock() usage without bh disabled, also it's possible to
get the bridge into an inconsistent state.

Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Fixes: 3ac636b8591c ("bridge: implement rtnl_link_ops->slave_changelink")
Reviewed-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 4851643
History
File Mode Size
Kconfig -rw-r--r-- 2.0 KB
Makefile -rw-r--r-- 379 bytes
actions.c -rw-r--r-- 24.5 KB
datapath.c -rw-r--r-- 56.3 KB
datapath.h -rw-r--r-- 6.0 KB
dp_notify.c -rw-r--r-- 2.7 KB
flow.c -rw-r--r-- 18.8 KB
flow.h -rw-r--r-- 8.2 KB
flow_netlink.c -rw-r--r-- 62.2 KB
flow_netlink.h -rw-r--r-- 2.5 KB
flow_table.c -rw-r--r-- 18.6 KB
flow_table.h -rw-r--r-- 2.8 KB
vport-geneve.c -rw-r--r-- 6.6 KB
vport-gre.c -rw-r--r-- 7.2 KB
vport-internal_dev.c -rw-r--r-- 7.1 KB
vport-internal_dev.h -rw-r--r-- 1.0 KB
vport-netdev.c -rw-r--r-- 5.8 KB
vport-netdev.h -rw-r--r-- 1.2 KB
vport-vxlan.c -rw-r--r-- 7.8 KB
vport-vxlan.h -rw-r--r-- 146 bytes
vport.c -rw-r--r-- 16.0 KB
vport.h -rw-r--r-- 7.9 KB

back to top