Skip to main content

Browse the archive

https://github.com/angular/angular
07 August 2024, 03:31:07 UTC
sort by:
Revision Author Date Message Commit Date
2b73d95 Sumit Arora 14 February 2022, 01:19:12 UTC feat(devtools): updating firefox manifest json file (#44952) Updating `manifest.json` file for firefox. PR Close #44952 12 April 2022, 18:41:37 UTC
60f2cfd Sumit Arora 02 February 2022, 19:59:56 UTC docs(devtools): adding firefox development documentation (#44952) Adding DevTools documentation for Firefox. PR Close #44952 12 April 2022, 18:41:37 UTC
e231d3c Sumit Arora 02 February 2022, 19:52:36 UTC feat(devtools): adding firefox support for devtools (#44952) Adding Firefox support for Angular DevTools. PR Close #44952 12 April 2022, 18:41:37 UTC
eb2f449 George Kalpakas 12 April 2022, 09:01:40 UTC docs(docs-infra): add missing period in `aio/README.md` (#45584) PR Close #45584 12 April 2022, 18:40:46 UTC
222d866 Leosvel Pérez Espinosa 12 April 2022, 18:15:09 UTC docs: fix `schematicCollections` option (#45602) PR Close #45602 12 April 2022, 18:40:08 UTC
89d2991 Dylan Hunn 15 February 2022, 17:04:04 UTC feat(forms): Implement strict types for the Angular Forms package. (#43834) This PR strongly types the forms package by adding generics to AbstractControl classes as well as FormBuilder. This makes forms type-safe and null-safe, for both controls and values. The design uses a "control-types" approach. In other words, the type parameter on FormGroup is an object containing controls, and the type parameter on FormArray is an array of controls. Special thanks to Alex Rickabaugh and Andrew Kushnir for co-design & implementation, to Sonu Kapoor and Netanel Basal for illustrative prior art, and to Cédric Exbrayat for extensive testing and validation. BREAKING CHANGE: Forms classes accept a generic. Forms model classes now accept a generic type parameter. Untyped versions of these classes are available to opt-out of the new, stricter behavior. PR Close #43834 12 April 2022, 17:37:04 UTC
d11d1c0 Jessica Janiuk 11 April 2022, 23:47:59 UTC Revert "refactor(router): Add warning for `relativeLinkResolution: 'legacy'` (#45523)" (#45594) This reverts commit d180db15bf7aef83335ec152002e58a1d9e3031e. PR Close #45594 12 April 2022, 00:08:41 UTC
3fceba4 dario-piotrowicz 11 April 2022, 19:40:46 UTC refactor(animations): include pushUnrecognizedPropertiesWarning in ngDevMode check (#45591) the check for unsupported CSS properties has been made dev-mode-only in PR #45570, so the check for the unsupportedCSSPRopertiesFound can be moved inside a ngDevMode check so that more code can be treeshaken away PR Close #45591 11 April 2022, 21:06:03 UTC
0facba5 Paul Gschwendtner 10 April 2022, 13:08:32 UTC build: update bazel integration test to RNJ v5.4.0 and Sass 1.50.0 (#45470) Updates Bazel integration to RNJ v5.4.0. This is needed since it relies on Angular Bazel which now relies on an internal pkg_npm helper breaking change. PR Close #45470 11 April 2022, 21:01:09 UTC
1219c5a Paul Gschwendtner 10 April 2022, 11:31:57 UTC refactor(bazel): fix dts bundling by accounting for api-extractor change (#45470) Fixes the dts bundling by accounting for recent API extractor changes which made API-extractor support path mappings. This causes cross-package and cross-entry-point imports to no longer be considered external, resulting in the imports to be dropped. PR Close #45470 11 April 2022, 21:01:09 UTC
4b2e98d Paul Gschwendtner 29 March 2022, 20:52:29 UTC fix(bazel): remove unnecessary file extractions from `ng_package` (#45470) Looks like there is some old legacy code for extracting files from NPM packages. This is already captured by the unscoped ESM2020 output extraction. PR Close #45470 11 April 2022, 21:01:09 UTC
28e835b Paul Gschwendtner 29 March 2022, 20:44:46 UTC feat(bazel): report error when dependency does not provide JS sources in `ng_package` (#45470) Non-JavaScript source-providing targets in the `ng_package` rule can throw-off the entry-point detection and therefore should be flagged. Currently e.g. a genrule-generated static file might unnecessarily cause additional actions to be generated (non-breaking but just unnecessary) PR Close #45470 11 April 2022, 21:01:09 UTC
636909f Paul Gschwendtner 29 March 2022, 20:40:52 UTC feat(bazel): allow for generated `package.json` files in `ng_package` (#45470) Currently the `ng_package` rule does not support generated `package.json` files. Generated `package.json` files are sometimes useful when e.g. dependencies are automatically inserted (e.g. many dependencies in the components repo for the MDC deps) Currently the `package.json` files would be copied as part of the `data` attribute, but they would not be processed. i.e. missing out on the `exports` field and more. We can simplify the rule attributes and make this more ergonomic. PR Close #45470 11 April 2022, 21:01:09 UTC
48b8a1f Renovate Bot 09 April 2022, 20:42:17 UTC build: update all non-major dependencies (#45470) Updates all non-major dependencies, including Bazel PR Close #45470 11 April 2022, 21:01:09 UTC
d180db1 Andrew Scott 08 March 2022, 18:42:39 UTC refactor(router): Add warning for `relativeLinkResolution: 'legacy'` (#45523) This change adds code to compute the corrected value for a link, regardless of the `relativeLinkResolution` value. Then, if the `relativeLinkResolution` is set to `legacy` and differs from the correct value, a warning is printed to the console in dev mode. This change is meant to assist in notifying developers that they have code which relies on the deprecated, broken behavior so they can fix and update the code before the `relativeLinkResolution` option is fully removed. PR Close #45523 11 April 2022, 20:51:15 UTC
f1630bb Michael-Doner 09 April 2022, 13:44:56 UTC docs: Fix several typos in the angular documentation (#45573) PR Close #45573 11 April 2022, 17:41:59 UTC
9572bb2 dario-piotrowicz 09 April 2022, 13:24:16 UTC refactor(animations): use full ngDevMode check in animatable prop validation (#45570) in the `validateAnimatableStyleProperty` function use the more complete check for the ngDevMode as it seems to be the preferred version (see: https://github.com/angular/angular/pull/45212#discussion_r823045428) PR Close #45570 11 April 2022, 16:52:02 UTC
a6fa37b dario-piotrowicz 09 April 2022, 11:27:11 UTC feat(animations): make validateStyleProperty check dev-mode only (#45570) make the validateStyleProperty check dev-mode only so that it is consistent with the validateAnimatableStyleProperty check introduced in PR #45212 besides consistency this change also reduces the payload size and increases performance (since less logic is executed) original conversation: https://github.com/angular/angular/pull/45212#discussion_r818106737 PR Close #45570 11 April 2022, 16:52:02 UTC
b13a453 Renovate Bot 09 April 2022, 06:04:31 UTC build: update dependency google-closure-compiler to v20220405 (#45568) PR Close #45568 11 April 2022, 16:26:25 UTC
41223a8 Kristiyan Kostadinov 08 April 2022, 19:37:30 UTC build: update to jasmine 4.0 (#45558) Updates us to version 4.0 of Jasmine and fixes some errors that were the result of us depending upon deprecated APIs. We need to do this both to stay up to date and because it was going to break eventually, because one of the Bazel packages was logging a deprecation warning that version 4.0 was required. There were also some cases where the state of `ngDevMode` had started leaking out between tests. PR Close #45558 11 April 2022, 16:25:28 UTC
8d85f24 Joey Perrott 27 January 2022, 23:32:20 UTC build: refactor global approvals to be done via overrides, adding dev-infra global approvers (#44866) Add dev-infra global approver support and change global approval management to be done via overrides. By using overrides to determine global approval status, we can safely ignore the concept of global approval in all of the other group management. PR Close #44866 11 April 2022, 16:24:46 UTC
0fed2ba Joey Perrott 27 January 2022, 23:02:48 UTC build: update pullapprove to assign caretakers to renovate PRs (#44866) Automatically assign renovate generated PRs to the current caretakers. PR Close #44866 11 April 2022, 16:24:46 UTC
20fbb4c Renovate Bot 08 April 2022, 11:35:56 UTC build: update github/codeql-action action to v2.1.8 (#45542) PR Close #45542 11 April 2022, 16:22:26 UTC
a6bf2c5 Renovate Bot 08 April 2022, 05:31:49 UTC build: update dependency eslint-plugin-jsdoc to v39 (#45562) PR Close #45562 11 April 2022, 16:17:28 UTC
4c1ce82 Michal Materowski 09 April 2022, 11:41:26 UTC build: fix typo in package.json file comment (#45569) Change comment in scripts section of package.json PR Close #45569 11 April 2022, 16:14:16 UTC
b96d6ea Renovate Bot 11 April 2022, 06:49:11 UTC build: update dependency @types/chrome to ^0.0.181 (#45586) PR Close #45586 11 April 2022, 16:13:00 UTC
e0ac614 Joe Martin (Crowdstaffing) 08 April 2022, 17:38:03 UTC docs: update test threshold \nupdate test threshold to get this content merged. (#45325) PR Close #45325 08 April 2022, 19:36:31 UTC
bf1294b Joe Martin (Crowdstaffing) 11 March 2022, 01:21:02 UTC docs: apply suggestions from code review (#45325) Apply editorial suggestions for peer review. Co-authored-by: Tiffany Davis <88161089+TMDavisGoogle@users.noreply.github.com> PR Close #45325 08 April 2022, 19:36:30 UTC
42289f2 Joe Martin (Crowdstaffing) 10 March 2022, 16:48:09 UTC docs: improve markdown (#45325) The purpose of the changes is to clean all markdown to match a single pedantic style. * To ensure all changes in style are properly separated. * To ensure all styled content aligns to nearest 4-character-tab. * To ensure all code blocks use the Angular `<code-example>` or `<code-tab>` elements. * To ensure all markdown exists outside of html tags. * To ensure all images use the Angular style for `<img>` elements. * To ensure that all smart punctuation is replaced or removed. ```text ’, ’, “, ”, –, —, … ``` * To ensure all content does not conflict with the following reserved characters. ```text @, $, *, &, #, |, <, >, ``` * To ensure all content displays using html entities. The following changes were made to files in the following directory. ```text aio/content ``` The target files were markdown files. The list of excluded files: ```text .browserslistrc, .css, .conf, .editorconfig, .gitignore, .html, .js, .json, .sh, .svg, .ts, .txt, .xlf, ``` PR Close #45325 08 April 2022, 19:36:30 UTC
7a37fe9 Jessica Janiuk 08 April 2022, 18:46:46 UTC Revert "build: update to jasmine 4.0 (#45558)" (#45566) This reverts commit a248df06824db1c40346b84de07ff905b0d0606f. PR Close #45566 08 April 2022, 19:07:29 UTC
a248df0 Kristiyan Kostadinov 07 April 2022, 13:59:08 UTC build: update to jasmine 4.0 (#45558) Updates us to version 4.0 of Jasmine and fixes some errors that were the result of us depending upon deprecated APIs. We need to do this both to stay up to date and because it was going to break eventually, because one of the Bazel packages was logging a deprecation warning that version 4.0 was required. There were also some cases where the state of `ngDevMode` had started leaking out between tests. PR Close #45558 08 April 2022, 15:55:58 UTC
60b5a3d Cédric Exbrayat 31 March 2022, 08:13:23 UTC refactor(core): validate property (#45528) Simplifies and documents the `validateProperty` function (in a similar fashion that #45492 simplified `validateElementIsKnown`). PR Close #45528 07 April 2022, 22:03:13 UTC
2a81e44 George Kalpakas 06 April 2022, 17:17:00 UTC docs: remove out-of-order `<h3>` elements from footer (#45510) The footer uses `h3` elements out of order, which causes a "Heading elements are not in a sequentially-descending order" a11y error. Replace the `h3` elements with `div` to improve a11y. Fixes #44338 PR Close #45510 07 April 2022, 21:01:58 UTC
f8f3ab3 Andrew Scott 04 April 2022, 18:11:11 UTC fix(router): Remove `any` from `LoadChildrenCallback` type (#45524) The `LoadChildrenCallback` type previously included `any` in the possible return value union for `Promise`. This is too loose and should be restricted to values that are actually supported. BREAKING CHANGE: When returning a `Promise` from the `LoadChildrenCallback`, the possible type is now restricted to `Type<any>|NgModuleFactory<any>` rather than `any`. PR Close #45524 07 April 2022, 21:01:09 UTC
5adfe8e Hossein Mousavi 05 April 2022, 18:33:08 UTC docs(forms): remove the incorrect set value from previous commit (#45533) in the validators documentation, the value for the formControl for both required and requiredTrue validators is an empty string. This is OK for required since it gives us an error. But I think if we set the value of formControl responsible for requiredTrue to something other than an empty string (e.g.: 'some value'), it would demonstrate the difference between required and requiredTrue better. PR Close #45533 07 April 2022, 21:00:25 UTC
b1d0683 Hossein Mousavi 05 April 2022, 18:26:09 UTC docs(forms): add value to formControl for better demonstration of requiredTrue validator (#45533) in the validators documentation, the value for the formControl for both required and requiredTrue validators is an empty string. This is OK for required since it gives us an error. But I think if we set the value of formControl responsible for requiredTrue to something other than an empty string (e.g.: 'some value'), it would demonstrate the difference between required and requiredTrue better. PR Close #45533 07 April 2022, 21:00:25 UTC
b57f8be George Kalpakas 06 April 2022, 16:10:05 UTC test(docs-infra): ufix e2e test for `{@example}` dgeni tags (#45551) Previously, the `guide/compoent-style` page was used in e2e tests to verify the behavior of `{@example}` dgeni tags. However, this guide has been updated and no longer contains an `{@example}` tag. This commit switches to using a different page (`api/common/NgIf`) that does currently contain an `{@example}` tag. (NOTE: This will also fix the [CI failures][1] in #45501.) [1]: https://circleci.com/gh/angular/angular/1145424 PR Close #45551 07 April 2022, 20:59:19 UTC
24649b9 George Kalpakas 06 April 2022, 16:03:35 UTC fix(docs-infra): add `shell` to the list of code-example languages recognized as cli commands (#45551) Previously, only `language="sh"` and `language="bash"` would be recognized (and formatted) as cli commands in `<code-example>`. This commit adds `shell` to the list of languages recognized as cli commands. (NOTE: This will fix the [CI failures][1] in #45325.) [1]: https://circleci.com/gh/angular/angular/1145559 PR Close #45551 07 April 2022, 20:59:19 UTC
f1a2816 Andrew Kushnir 06 April 2022, 15:58:29 UTC release: cut the v14.0.0-next.11 release (#45550) 06 April 2022, 15:58:29 UTC
d4270d2 Andrew Kushnir 06 April 2022, 15:56:09 UTC docs: release notes for the v13.3.2 release (#45549) 06 April 2022, 15:56:09 UTC
1c11a57 Martin Sikora 02 March 2022, 08:47:27 UTC fix(router): merge interited resolved data and static data (#45276) in layers Right now route static data are collected from its parents based on the logic described in `inheritedParamsDataResolve()`, merged into a single object and then merged again with merged data from resolvers. This means that a child's data can be overriden by a resolver in its parent (#34361). However, what is the expected behavior is not described in the documentation. This PR changes this behavior and merges static data and resolved data in "layers" (route by route) so child's static data and resolved data cannot be overriden by their parents. Fixes #34361 PR Close #45276 05 April 2022, 15:49:09 UTC
a3f344f Christoph Guttandin 23 February 2022, 18:26:22 UTC test(animations): add test for buildAnimationAst() function (#31107) This commit adds a test for the buildAnimationAst() function. PR Close #31107 05 April 2022, 15:41:38 UTC
29d3891 Christoph Guttandin 18 June 2019, 14:50:59 UTC fix(animations): handle structured AnimateTimings (#31107) This commit makes sure structured AnimateTimings are not procesed any further when building the AST. Fixes: #22752 PR Close #31107 05 April 2022, 15:41:38 UTC
035ba83 Renovate Bot 02 April 2022, 06:18:01 UTC build: update dependency entities to v4 (#45509) PR Close #45509 04 April 2022, 21:54:15 UTC
d56a537 Andrew Scott 29 October 2021, 00:17:09 UTC feat(migrations): Add migration to add explicit `Route`/`Routes` type (#45084) Places that use `pathMatch` need an explicit `Route` or `Routes` type on the variable so TypeScript does not infer the type as just 'string'. PR Close #45084 04 April 2022, 21:53:45 UTC
5aeaedf Cédric Exbrayat 31 March 2022, 07:46:12 UTC refactor(core): validate element is known in JIT mode (#45492) Renames, simplifies and documents the function in charge of validating if an element is known in JIT mode. PR Close #45492 04 April 2022, 16:34:41 UTC
adf4b6d George Kalpakas 03 April 2022, 08:47:07 UTC build(docs-infra): upgrade cli command docs sources to 0e8f3c34b (#45511) Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/c0a0bfb65...0e8f3c34b): **Modified** - help/update.json PR Close #45511 04 April 2022, 16:33:59 UTC
b2d0652 Alan Agius 01 April 2022, 12:02:26 UTC fix(docs-infra): update Angular packages to latest minor version (#45502) This is needed because Angular CLI 13.3 contains fixes that are needed for Stackblitz Node 16 to compile Sass. We also added `copyfiles` in `aio/tools/examples/shared/package.json` as `yarn sync-deps` was failing due to the missing dependency. PR Close #45502 04 April 2022, 16:23:54 UTC
c0c18b7 piyush132000 31 March 2022, 02:40:24 UTC docs: add animations to readme file (#45488) Updated readme file for adding animations topic in advance topics of Angular PR Close #45488 04 April 2022, 16:17:49 UTC
8b1a2f1 mgechev 31 March 2022, 23:43:25 UTC docs: change roadmap updated date (#45500) PR Close #45500 01 April 2022, 20:33:07 UTC
085d94e mgechev 31 March 2022, 23:41:49 UTC docs: add details about ssr efforts (#45500) PR Close #45500 01 April 2022, 20:33:07 UTC
71e9068 Chabbey François 31 March 2022, 14:09:18 UTC docs: fix typo in CHANGELOG.md (#45494) Fix typo PR Close #45494 31 March 2022, 19:50:21 UTC
99154cf Renovate Bot 31 March 2022, 05:59:08 UTC build: update github/codeql-action action to v2 (#45491) PR Close #45491 31 March 2022, 19:48:17 UTC
2b12959 Dylan Hunn 30 March 2022, 21:28:56 UTC docs: release notes for the v13.3.1 release (#45486) PR Close #45486 30 March 2022, 21:30:03 UTC
115aafb Dylan Hunn 30 March 2022, 21:09:45 UTC release: cut the v14.0.0-next.10 release (#45484) PR Close #45484 30 March 2022, 21:10:34 UTC
e1e440d AlirezaEbrahimkhani 25 March 2022, 13:11:33 UTC docs: add Angular university website to resources list (#45437) PR Close #45437 30 March 2022, 00:13:07 UTC
82956dc Willian Corrêa 18 February 2022, 10:15:53 UTC Update aio/content/marketing/resources.json (#45076) Co-authored-by: Alan Agius <alan.agius4@gmail.com> PR Close #45076 30 March 2022, 00:11:54 UTC
eb9dd8d Willian Corrêa 14 February 2022, 13:15:59 UTC docs: add Rangle's Angular Training book (#45076) PR Close #45076 30 March 2022, 00:11:54 UTC
7d94923 dario-piotrowicz 06 February 2022, 18:03:25 UTC fix(docs-infra): implement focus trap for aio search results (#44989) currently if a user tries to navigate via keyboard, once the are presented with search results, the search results panel remains present and can potentially hide most of the content on the page, in such case keyboard navigation will be severly hindered and the only option for the user would be to go back to the seach input text and clear its value, fix such inconvenience by looping the focus in the header area close to the search results and the results panel itself note: an alternative implementation using the cdkTrapFocus has been attempted in PR #45194, such alternative implementation presented a number of (minor) drawbacks (including the increase main bundle size due to the inclusion of the A11yModule), so it was agreed to proceed with the manual implementation present in these changes instead. PR Close #44989 29 March 2022, 23:56:03 UTC
8e09445 zverbeta 29 March 2022, 21:09:09 UTC test: update aio payload size golden to reflect Angular update (#45376) PR Close #45376 29 March 2022, 22:25:49 UTC
099fedc zverbeta 24 March 2022, 23:30:58 UTC docs: add notification to support ukraine (#45376) PR Close #45376 29 March 2022, 22:25:49 UTC
06050ac JoostK 26 March 2022, 21:51:55 UTC fix(compiler-cli): handle inline type-check blocks in nullish coalescing extended check (#45454) This commit fixes an inconsistency where a type check location for an inline type check block would be interpreted to occur in a type-checking shim instead. This resulted in a missing template mapping, causing a crash due to an unsafe non-null assertion operator. In the prior commit the `TcbLocation` has been extended with an `isShimFile` field that is now being used to look for the template mapping in the correct location. Additionally, the non-null assertion operator is refactored such that a missing template mapping will now ignore the warning instead of crashing the compiler. Fixes #45413 PR Close #45454 29 March 2022, 21:09:33 UTC
ff32301 JoostK 26 March 2022, 21:23:28 UTC refactor(compiler-cli): track whether a `TcbPosition` corresponds with a shim file (#45454) Extends `TcbPosition` with a field that indicates whether the `tcbPath` is a type-checking shim file, or an original source file with an inline type check block. This field is used in an upcoming commit that fixes an inconsistency with how inline type check blocks are incorrectly interpreted as a type-checking shim file instead. PR Close #45454 29 March 2022, 21:09:33 UTC
b2758d7 JoostK 26 March 2022, 21:10:33 UTC refactor(compiler-cli): rename `ShimLocation` to `TcbLocation` (#45454) Inline type check blocks (TCBs) are emitted into the original source file, but node positions would still be represented as a `ShimLocation` with a `shimPath` corresponding with the type-checking shim file. This results in inconsistencies, as the `positionInShimFile` field of `ShimLocation` would not correspond with the `shimPath` of that `ShimLocation`. This commit is a precursor to letting `ShimLocation` also represent the correct location for inline type check blocks, by renaming the interface to `TcbLocation`. A followup commit addresses the actual inconsistency. PR Close #45454 29 March 2022, 21:09:33 UTC
e55e98d Renovate Bot 29 March 2022, 16:29:53 UTC build: update all non-major dependencies (#45374) PR Close #45374 29 March 2022, 20:22:26 UTC
2142ffd Alex Rickabaugh 22 March 2022, 22:25:13 UTC feat(compiler-cli): propagate `standalone` flag to runtime (#44973) This commit carries the `standalone` flag forward from a directive/pipe into its generated directive/pipe definition, allowing the runtime to recognize standalone entities. PR Close #44973 29 March 2022, 20:06:26 UTC
6f653e0 Alex Rickabaugh 02 February 2022, 00:29:07 UTC feat(compiler-cli): standalone types imported into NgModule scopes (#44973) This commit implements the next step of Angular's "standalone" functionality, by allowing directives/components/pipes declared as `standalone` to be imported into NgModules. Errors are raised when such a type is not standalone but is included in an NgModule's imports. PR Close #44973 29 March 2022, 20:06:26 UTC
459766b Alex Rickabaugh 01 February 2022, 23:08:41 UTC test(compiler-cli): split standalone tests into component & module tests (#44973) This just helps organize the standalone tests a little bit. PR Close #44973 29 March 2022, 20:06:26 UTC
60ef6e5 Alex Rickabaugh 02 February 2022, 00:48:45 UTC refactor(compiler-cli): move error for declaring standalone things (#44973) This commit moves the error for declaring a standalone directive/component/ pipe to the `LocalModuleScopeRegistry`. Previously the error was produced by the `NgModuleHandler` directly. Producing the error in the scope registry allows the scope to be marked as poisoned when the error occurs, preventing spurious downstream errors from surfacing. PR Close #44973 29 March 2022, 20:06:26 UTC
3d13343 Alex Rickabaugh 25 January 2022, 22:19:40 UTC fix(compiler-cli): better error messages for NgModule structural issues (#44973) This commit improves the error messages generated by the compiler when NgModule scope analysis finds structural issues within a compilation. In particular, errors are now shown on a node within the metadata of the NgModule which produced the error, as opposed to the node of the erroneous declaration/import/ export. For example, if an NgModule declares `declarations: [FooCmp]` and `FooCmp` is not annotated as a directive, component, or pipe, the error is now shown on the reference to `FooCmp` in the `declarations` array expression. Previously, the error would have been shown on `FooCmp` itself, with a mention in the error text of the NgModule name. Additional error context in some cases has been moved to related information attached to the diagnostic, which further improves the legibility of such errors. Error text has also been adjusted to be more succinct, since more info about the error is now delivered through context. PR Close #44973 29 March 2022, 20:06:26 UTC
f027bfb Alex Rickabaugh 25 January 2022, 22:05:32 UTC refactor(compiler-cli): remove NgModule tracking from scope data (#44973) Before the `SemanticSymbol` system which now powers incremental compilation, the compiler previously needed to track which NgModules contributed to the scope of a component in order to recompile correctly if something changed. This commit removes that legacy field (which had no consumers) as well as the logic to populate it. PR Close #44973 29 March 2022, 20:06:26 UTC
6e1fce5 Paul Gschwendtner 28 March 2022, 15:15:48 UTC test: update aio payload size golden to reflect Angular update (#45461) Updates the AIO payload size goldens to reflect the Angular update affecting both the `aio` and `aio_local` build (due to CLI devkit changes affecting both goldens, and the Angular update also affecting the non-local `aio` build / job). Overall, the Material themes got a little larger, but this is not caused by the framwork, so not relevant here. PR Close #45461 29 March 2022, 16:26:00 UTC
209a73e Paul Gschwendtner 28 March 2022, 15:05:06 UTC test: update api goldens to reflect api-golden bazel rule change (#45461) The API golden Bazel rule has changed in the shared dev-infra code. Instead of putting golden API reports into the golden folder as per their original location in the NPM package, golden reports are now stored based on the package exports. This makes it more obvious how entry-points are consumable As part of this change, since the API golden rule now consutls the NPM package `exports` field, the `localize/tools` entry-point golden file is now generated. Previously it wasn't generated due to it not having a secondary entry-point `package.json` file. Such package json files should not be needed anymore and will be gone in future APF versions. PR Close #45461 29 March 2022, 16:26:00 UTC
468c776 Renovate Bot 28 March 2022, 13:20:28 UTC build: update angular (#45461) PR Close #45461 29 March 2022, 16:25:59 UTC
16e635c dario-piotrowicz 16 March 2022, 21:51:56 UTC fix(docs-infra): update a11y min-scores (#45209) update (decrease) the value of some of the accessibility MIN_SCORES_PER_PAGE after recent changes PR Close #45209 29 March 2022, 16:23:12 UTC
0fc4571 dario-piotrowicz 16 March 2022, 21:47:16 UTC fix(docs-infra): assign different aria labels to main aio navs (#45209) assign different aria labels to the primary nav and the one used for guides and docs, so that impaired users can more easily distinguish the two PR Close #45209 29 March 2022, 16:23:12 UTC
734bd8d dario-piotrowicz 16 March 2022, 21:44:05 UTC fix(docs-infra): remove redundant main roles (#45209) remove redundant main role as pages should always have a single element with a main role (also remove the role assigne to the main tag as that is implied) PR Close #45209 29 March 2022, 16:23:12 UTC
be5dce2 dario-piotrowicz 16 March 2022, 21:41:07 UTC fix(docs-infra): wrap the main aio mat-toolbar in a header (#45209) wrap the main aio mat-toolbar in a header element to provide better accessibility resolves #16938 (the first point) PR Close #45209 29 March 2022, 16:23:12 UTC
7ef0717 dario-piotrowicz 16 March 2022, 21:37:06 UTC fix(docs-infra): remove navigation role to aio-top-menu ul (#45209) currently the navigation ul used in aio-top-menu has a role of navigation, but listitems should be owned by list parents (see more: https://www.w3.org/TR/wai-aria-1.1/#listitem) so wrap the ul in a nav and remove the role="navigation" from the ul element to fix such issue resolves #44562 resolves #16938 (the second point) PR Close #45209 29 March 2022, 16:23:12 UTC
6e4cb48 Michael-Doner 29 March 2022, 14:03:42 UTC docs: adjust contributing, developing and overview markdown files (#45464) Adjust the contributing, developing and overview markdown files based on the new repository location angular/angular PR Close #45464 29 March 2022, 16:22:50 UTC
801d11d Dylan Hunn 29 March 2022, 16:11:12 UTC Revert "fix(compiler): scope css keyframes in emulated view encapsulation (#42608)" (#45466) This reverts commit f03e313f24465cbe9ce99aa5f9f482a6c6b5485f. PR Close #45466 29 March 2022, 16:12:19 UTC
f03e313 dario-piotrowicz 20 June 2021, 11:03:48 UTC fix(compiler): scope css keyframes in emulated view encapsulation (#42608) Ensure that keyframes rules, defined within components with emulated view encapsulation, are scoped to avoid collisions with keyframes in other components. This is achieved by renaming these keyframes to add a prefix that makes them unique across the application. In order to enable the handling of keyframes names defined as strings the previous strategy of replacing quoted css content with `%QUOTED%` (introduced in commit 7f689a2) has been removed and in its place now only specific characters inside quotes are being replaced with placeholder text (those are `;`, `:` and `,`, more can be added in the future if the need arises). Closes #33885 BREAKING CHANGE: Keyframes names are now prefixed with the component's "scope name". For example, the following keyframes rule in a component definition, whose "scope name" is host-my-cmp: @keyframes foo { ... } will become: @keyframes host-my-cmp_foo { ... } Any TypeScript/JavaScript code which relied on the names of keyframes rules will no longer match. The recommended solutions in this case are to either: - change the component's view encapsulation to the `None` or `ShadowDom` - define keyframes rules in global stylesheets (e.g styles.css) - define keyframes rules programmatically in code. PR Close #42608 29 March 2022, 00:12:25 UTC
bf98c64 Andrew Kushnir 26 March 2022, 02:53:19 UTC docs: add image directive to public roadmap (#45448) PR Close #45448 28 March 2022, 17:30:26 UTC
d43c0e9 Maddie Klein 27 February 2022, 04:10:25 UTC fix(http): Throw error when headers are supplied in JSONP request (#45210) JSONP does not support headers being set on requests. This enables JSONP to throw an error when headers are supplied in the request to prevent attempts to set them. BREAKING CHANGE: JSONP will throw an error when headers are set on a reques JSONP does not support headers being set on requests. Before when a request was sent to a JSONP backend that had headers set the headers were ignored. The JSONP backend will now throw an error if it receives a request that has any headers set. Any uses of JSONP on requests with headers set will need to remove the headers to avoid the error. Closes #9141 PR Close #45210 28 March 2022, 16:38:19 UTC
b36dec6 Kristiyan Kostadinov 18 September 2021, 11:05:26 UTC fix(forms): not picking up disabled state if group is swapped out and disabled (#43499) Fixes a long-standing issue where swapping out the `FormGroup` and calling `disable` immediately afterwards doesn't actually disable the `ControlValueAccessor`. Fixes #22556. PR Close #43499 28 March 2022, 16:26:19 UTC
3d2a60e Renovate Bot 26 March 2022, 01:14:35 UTC build: update dependency @bazel/ibazel to ^0.16.0 (#45259) PR Close #45259 28 March 2022, 16:25:26 UTC
c996b47 Paul Gschwendtner 26 March 2022, 15:54:20 UTC build: replace bazel devserver with shared dev-infra implementation (#45452) As part of the devtools migration, we copied the custom http server/ dev-server from the `angular/components` repo. This server implementation has now moved to the shared dev-infra code, and we can clean up the copy in this repository now. PR Close #45452 28 March 2022, 16:23:28 UTC
aebf165 JiaLiPassion 07 March 2022, 09:24:24 UTC fix(zone.js): should ignore multiple resolve call (#45283) Close #44913 The following case is not handled correctly by `zone.js`. ``` const delayedPromise = new Promise((resolve) => { setTimeout(resolve, 1, 'timeout'); }); new Promise((resolve) => { resolve(delayedPromise); resolve('second call'); }).then(console.log); ``` It should output `timeout`, since the promise is resolved by the 1st resolve, the `second call` should be ignored. So this is a bug that the original implementation not ensure the `resolve` is only called once. PR Close #45283 26 March 2022, 00:31:03 UTC
d36fa11 Kristiyan Kostadinov 25 March 2022, 22:09:25 UTC fix(core): avoid Closure Compiler error in restoreView (#45445) Closure Compiler in advanced optimization mode may end up inlining the `ɵɵrestoreView` into the event listener which can lead to a runtime null pointer exception after the changes in #43075. These changes add an annotation to prevent function inlining of the specific instruction. PR Close #45445 26 March 2022, 00:19:30 UTC
96c7cc9 Andrew Scott 09 March 2022, 20:39:35 UTC docs: deprecated relativeLinkResolution in the Router (#45308) The `relativeLinkResolution` option was added as an option to opt-in to corrected behavior when generating links relative to a route that has an empty path parent. This was needed to avoid a breaking change. Since then, we have switched the default to be the corrected behavior. It's time to close the turn the lights off on this option so we no longer have to maintain and document buggy behavior. PR Close #45308 25 March 2022, 23:50:46 UTC
3143494 Paul Gschwendtner 25 March 2022, 22:32:26 UTC build: disable payload size uploading within bazel (#45446) Uploading payload size is unreliable from within Bazel. This is because tests might not run for every commit, tests might have been cached from a pull request RBE-build (causing payload uploading to be skipped most of the time as every change comes from a PR) We should disable the uploading as this is a fundamental problem (good thing to note now) that we can solve with better payload size tracking that we want to establish as part of dev-infra. PR Close #45446 25 March 2022, 23:50:09 UTC
4ea70e3 arturovt 20 March 2022, 18:39:42 UTC fix(zone.js): swallow the error when the element callback is not patchable (#45400) The `patchCallbacks` is used for patching the `document.registerElement` and `customElements.define`. We explicitly wrap the patching code into try-catch since callbacks may be already patched by other web components frameworks (e.g. LWC), and they make those properties non-writable. This means that patching callback will throw an error `cannot assign to read-only property`. See this code as an example: https://github.com/salesforce/lwc/blob/master/packages/@lwc/engine-core/src/framework/base-bridge-element.ts#L180-L186 We don't want to stop the application rendering if we couldn't patch some callback, e.g. `attributeChangedCallback`. PR Close #42546 PR Close #45400 25 March 2022, 23:31:09 UTC
1177b4e Paul Gschwendtner 25 March 2022, 20:45:27 UTC ci: make payload size tracking script work with CircleCI and Bazel limitation (#45444) For quite some time now, since we started to use Bazel for integration tests, we relied on some size tracking logic that did not actually fully work under Bazel. It was thought that all the necessary CI push/PR information is available to the Bazel test, but that was not the case. This was now fixed with the recent Rules NodeJS v5 update where I made sure the `env.sh` variables are actually available before we write them to the temporary file for the Bazel-access. This now will unveil an issue because payload size goldens would start being based on their branch name. e.g. the golden key in `13.3.x` should not be `master` but `13.3.x`. This makes more sense than `master` as key, but makes things more cumbersome and ideally we would not store the branch name at all (this is a larger change though -- not worth now since we might refactor this anyway). For now we will update the size tracking logic to always use `master` as golden key (like it worked in the past year(s)) With the environment fix we now (again) start uploading payload size results to Firebase. This did not work by accident either. The uploading logic is reliant on the CircleCI commit range which is not working/reliable in upstream branches. This commit removes this reliance on `COMMIT_RANGE` since it's not strictly necessary and currently breaking renovate PRs. We can re-enable this when we have a solution with CircleCI, or a workaround/resolution logic provided in e.g. `ng-dev ci determine-commit-range`. PR Close #45444 25 March 2022, 21:25:03 UTC
7ab7181 Dylan Hunn 25 March 2022, 19:40:11 UTC release: cut the v14.0.0-next.9 release (#45442) PR Close #45442 25 March 2022, 19:41:33 UTC
78eace6 Paul Gschwendtner 24 March 2022, 20:04:16 UTC build: shorten partial compilation test case target names for windows (#45431) Shortens the partial compilation test case target names as the paths/ manifest paths in Bazel became too large, exceeding some Windows path length limits. Relevant context/resources: * https://angular-team.slack.com/archives/C02PARQNMC1/p1648137933069659 (internal) * https://docs.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=cmd * https://github.com/bazelbuild/rules_nodejs/pull/3215/files#r782271592 PR Close #45431 25 March 2022, 19:18:34 UTC
fed7630 Paul Gschwendtner 24 March 2022, 19:23:53 UTC ci: improve stability of windows bazel CI job (#45431) Improves stability of the Windows Bazel CI job by installing Bazelisk globally. Also makes the environment helpers more convenient by evaluating the variable assignments directly, simplifying some Bash logic. PR Close #45431 25 March 2022, 19:18:34 UTC
a7c81da Paul Gschwendtner 24 March 2022, 18:54:58 UTC ci: dedupe top-level yarn install in circleci config (#45431) Dedupes the Yarn run steps, avoiding the need to manually keep this step in sync (e.g. with the timeout -- which is currently missing for the windows job) PR Close #45431 25 March 2022, 19:18:34 UTC
9e3e970 Paul Gschwendtner 24 March 2022, 16:58:38 UTC test: refactor compiler-cli compliance test to work on windows (#45431) Recent changes in `rules_nodejs` caused the test case copy file actions to be transitioned into the `exec` configuration, resulting in much larger file paths. These paths break on Windows with the shell argument limit, and with the path limit, causing errors like: ``` ERROR: C:/users/circleci/ng/packages/compiler-cli/test/compliance/test_cases/BUILD.bazel:9:12: Copying file packages/compiler-cli/test/compliance/test_cases/r3_compiler_compliance/components_and_directives/value_composition/structural_directives_if_directive_def.js failed: (Exit 1): cmd.exe failed: error executing command cd /d C:/users/circleci/_bazel_circleci/u4uoan2j/execroot/angular SET PATH=C:\Program Files\Git\usr\bin;C:\Program Files\Git\bin;C:\Windows;C:\Windows\System32;C:\Windows\System32\WindowsPowerShell\v1.0 SET RUNFILES_MANIFEST_ONLY=1 cmd.exe /C bazel-out\x64_windows-opt-exec-2B5CBBC6\bin\packages\compiler-cli\test\compliance\test_cases\test_cases--1973427149-cmd.bat The system cannot find the path specified ``` https://app.circleci.com/pipelines/github/angular/angular/44038/workflows/4b530cb2-f232-4e1d-b35a-e6e085151d08/jobs/1140017 PR Close #45431 25 March 2022, 19:18:34 UTC
a48683b Paul Gschwendtner 23 March 2022, 19:40:28 UTC ci: make windows circleci job more robust and use git bash (#45431) It is totally fine, and expected to use Git Bash for running Bazel on Windows. In fact this is the most common setup for Bazel on Windows and it's unrealistic to run without it. This allows us to remove the old/legacy Powershell setup from CI which is also quite flaky sometimes and does not reproduce how Bazel is used on windows-users dev machines. PR Close #45431 25 March 2022, 19:18:34 UTC
b1fadbd Paul Gschwendtner 23 March 2022, 13:42:29 UTC ci: temporarily disable components-repo-unit-tests job for Bazel NodeJS v5 update (#45431) The Angular components repository can only start using Bazel Rules NodeJS v5 when `@angular/bazel` is published with support for it. To work around this cycle we temporarily disable the unit tests job until we migrated the COMP repo as well. PR Close #45431 25 March 2022, 19:18:34 UTC
back to top