Skip to main content

Browse the archive

https://github.com/JuliaLang/julia
19 April 2024, 06:28:37 UTC
Revision 9723f8275aaaff343c50a7571be15f95171a8683 authored by Alex Arslan on 08 November 2021, 01:46:27 UTC, committed by KristofferC on 08 November 2021, 08:45:20 UTC 
Keep expected crash in misc test from producing a core dump (#42990)
 
Currently the test in `test/misc.jl` that tests that a particular kind
of read fault crashes has two issues:

1. It works for the wrong reason. It's testing for `!success` when
   evaluating code interpolated directly into the `Cmd`, but it isn't
   quoting the code, so the subprocess fails with a syntax error instead
   of the type of crash the test is expecting.

2. On some platforms (such as our good ol' pal FreeBSD), this kind of
   read fault produces a core dump. This a bit annoying because it means
   that the repo state becomes dirty after running the tests and it may
   overwrite an existing core dump that was left behind by an earlier
   issue we'd like to diagnose.

To fix these, we can wrap the code passed to the subprocess in single
quotes and on Unix-like systems wrap the subprocess in `ulimit -c 0` to
avoid producing a core dump.

(cherry picked from commit fa6dcb0e61166e6af2dcf4b78ef922d3f191c2fb)
1 parent ee25032
History
Tip revision: 9723f8275aaaff343c50a7571be15f95171a8683 authored by Alex Arslan on 08 November 2021, 01:46:27 UTC
Keep expected crash in misc test from producing a core dump (#42990)
Tip revision: 9723f82
File Mode Size
.buildkite
.devcontainer
.github
base
cli
contrib
deps
doc
etc
src
stdlib
test
.clang-format -rw-r--r-- 3.3 KB
.codecov.yml -rw-r--r-- 52 bytes
.gitattributes -rw-r--r-- 65 bytes
.gitignore -rw-r--r-- 425 bytes
.mailmap -rw-r--r-- 11.0 KB
CITATION.bib -rw-r--r-- 513 bytes
CONTRIBUTING.md -rw-r--r-- 19.3 KB
HISTORY.md -rw-r--r-- 313.4 KB
LICENSE.md -rw-r--r-- 1.3 KB
Make.inc -rw-r--r-- 49.0 KB
Makefile -rw-r--r-- 25.8 KB
NEWS.md -rw-r--r-- 20.3 KB
README.md -rw-r--r-- 7.5 KB
THIRDPARTY.md -rw-r--r-- 3.7 KB
VERSION -rw-r--r-- 10 bytes
sysimage.mk -rw-r--r-- 4.0 KB

README.md

back to top