https://github.com/python/cpython
Revision 972aba86ede0bf254e16a760639a1ff8df298578 authored by Antoine Pitrou on 10 June 2020, 20:38:42 UTC, committed by GitHub on 10 June 2020, 20:38:42 UTC
The doccumentation at https://docs.python.org/3.10/library/weakref.html cautions that the `WeakKeyDictionary` and `WeakValueDictionary` are susceptible to the problem of dictionary mutation during iteration. These notes present the user with a problem that has no easy solution. I dug into the implementation and found that fortunately, Antoine Pitrou already addressed this challenge (10 years ago!) by introducing an `_IterationGuard` context manager to the implementation, which delays mutation while an iteration is in progress. I asked for confirmation and @pitrou agreed that these notes could be removed: https://github.com/python/cpython/commit/c1baa601e2b558deb690edfdf334fceee3b03327GH-commitcomment-39514438. (cherry picked from commit 1642c0ef750f96664a98cadb09301d492098d2fb) Co-authored-by: Daniel Fortunov <asqui@users.noreply.github.com> Automerge-Triggered-By: @pitrou
1 parent c7a6c7b
Tip revision: 972aba86ede0bf254e16a760639a1ff8df298578 authored by Antoine Pitrou on 10 June 2020, 20:38:42 UTC
[3.8] bpo-40895: Update weakref documentation to remove old warnings (GH-20687) (GH-20792)
[3.8] bpo-40895: Update weakref documentation to remove old warnings (GH-20687) (GH-20792)
Tip revision: 972aba8
File | Mode | Size |
---|---|---|
.azure-pipelines | ||
.github | ||
Doc | ||
Grammar | ||
Include | ||
Lib | ||
Mac | ||
Misc | ||
Modules | ||
Objects | ||
PC | ||
PCbuild | ||
Parser | ||
Programs | ||
Python | ||
Tools | ||
m4 | ||
.gitattributes | -rw-r--r-- | 1.8 KB |
.gitignore | -rw-r--r-- | 1.7 KB |
.travis.yml | -rw-r--r-- | 8.1 KB |
CODE_OF_CONDUCT.md | -rw-r--r-- | 630 bytes |
LICENSE | -rw-r--r-- | 12.5 KB |
Makefile.pre.in | -rw-r--r-- | 66.0 KB |
README.rst | -rw-r--r-- | 9.7 KB |
aclocal.m4 | -rw-r--r-- | 10.7 KB |
config.guess | -rwxr-xr-x | 43.1 KB |
config.sub | -rwxr-xr-x | 35.4 KB |
configure | -rwxr-xr-x | 492.9 KB |
configure.ac | -rw-r--r-- | 163.3 KB |
install-sh | -rwxr-xr-x | 15.0 KB |
pyconfig.h.in | -rw-r--r-- | 44.3 KB |
setup.py | -rw-r--r-- | 101.7 KB |
Computing file changes ...