Skip to main content

Browse the archive

Revision 976e2c1f4b37821272f303aee639b62e1fd085f9 authored by Ian Kilpatrick on 12 April 2018, 12:08:38 UTC, committed by Blink WPT Bot on 12 April 2018, 12:27:52 UTC 
[css-layout-api] Fix DCHECK with the custom layout and multicol.
 
There are probably larger changes that need to happen to ensure that
the custom-layout and multicol play nicely together, but this removes
a DCHECK crash for now.

Bug: 823074
Change-Id: I98f4a34bd0c35e8cd3d23501ca64f38b96be9e7d
Reviewed-on: https://chromium-review.googlesource.com/990780
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550148}
1 parent 19a42b9
Raw File
insert-adjacent.html 
<!doctype html>
<title>insertAdjacentHTML</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<style>
#element {
  display: none;
}
</style>

<div id="element"></div>
<div id="log"></div>

<script>
function wrap(text) {
  return '<h3>' + text + '</h3>';
}

var possiblePositions = {
    'beforebegin': 'previousSibling'
  , 'afterbegin': 'firstChild'
  , 'beforeend': 'lastChild'
  , 'afterend': 'nextSibling'
}

var el = document.querySelector('#element');

Object.keys(possiblePositions).forEach(function(position) {
  var html = wrap(position);
  test(function() {
    el.insertAdjacentHTML(position, html);
    var heading = document.createElement('h3');
    heading.innerHTML = position;
    assert_equals(el[possiblePositions[position]].nodeName, "H3");
    assert_equals(el[possiblePositions[position]].firstChild.nodeType, Node.TEXT_NODE);
  }, 'insertAdjacentHTML(' + position + ', ' + html + ' )');
});
</script>
back to top