Revision 9839ff0dead906e85e4d17490aeff87a5859a157 authored by Xufeng Zhang on 23 January 2013, 16:44:34 UTC, committed by David S. Miller on 28 January 2013, 00:32:23 UTC
While sctp handling a duplicate COOKIE-ECHO and the action is 'Association restart', sctp_sf_do_dupcook_a() will processing the unexpected COOKIE-ECHO for peer restart, but it does not set the association state to SCTP_STATE_ESTABLISHED, so the association could stuck in SCTP_STATE_SHUTDOWN_PENDING state forever. This violates the sctp specification: RFC 4960 5.2.4. Handle a COOKIE ECHO when a TCB Exists Action A) In this case, the peer may have restarted. ..... After this, the endpoint shall enter the ESTABLISHED state. To resolve this problem, adding a SCTP_CMD_NEW_STATE cmd to the command list before SCTP_CMD_REPLY cmd, this will set the restart association to SCTP_STATE_ESTABLISHED state properly and also avoid I-bit being set in the DATA chunk header when COOKIE_ACK is bundled with DATA chunks. Signed-off-by: Xufeng Zhang <xufeng.zhang@windriver.com> Acked-by: Neil Horman <nhorman@tuxdriver.com> Acked-by: Vlad Yasevich <vyasevich@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 75356a8
File | Mode | Size |
---|---|---|
postprocess | ||
events-kmem.txt | -rw-r--r-- | 5.3 KB |
events-power.txt | -rw-r--r-- | 2.9 KB |
events.txt | -rw-r--r-- | 9.0 KB |
ftrace-design.txt | -rw-r--r-- | 14.9 KB |
ftrace.txt | -rw-r--r-- | 65.4 KB |
function-graph-fold.vim | -rw-r--r-- | 1.3 KB |
kprobetrace.txt | -rw-r--r-- | 6.9 KB |
mmiotrace.txt | -rw-r--r-- | 6.6 KB |
ring-buffer-design.txt | -rw-r--r-- | 29.9 KB |
tracepoint-analysis.txt | -rw-r--r-- | 12.0 KB |
tracepoints.txt | -rw-r--r-- | 4.1 KB |
uprobetracer.txt | -rw-r--r-- | 4.2 KB |
Computing file changes ...