Revision 98f3488c1b6090024299f8d6362aa6aac03fe26d authored by Akihiko Odaki on 28 February 2024, 11:33:12 UTC, committed by Michael Tokarev on 13 March 2024, 18:52:34 UTC
nvme_sriov_pre_write_ctrl() used to directly inspect SR-IOV configurations to know the number of VFs being disabled due to SR-IOV configuration writes, but the logic was flawed and resulted in out-of-bound memory access. It assumed PCI_SRIOV_NUM_VF always has the number of currently enabled VFs, but it actually doesn't in the following cases: - PCI_SRIOV_NUM_VF has been set but PCI_SRIOV_CTRL_VFE has never been. - PCI_SRIOV_NUM_VF was written after PCI_SRIOV_CTRL_VFE was set. - VFs were only partially enabled because of realization failure. It is a responsibility of pcie_sriov to interpret SR-IOV configurations and pcie_sriov does it correctly, so use pcie_sriov_num_vfs(), which it provides, to get the number of enabled VFs before and after SR-IOV configuration writes. Cc: qemu-stable@nongnu.org Fixes: CVE-2024-26328 Fixes: 11871f53ef8e ("hw/nvme: Add support for the Virtualization Management command") Suggested-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com> Message-Id: <20240228-reuse-v8-1-282660281e60@daynix.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> (cherry picked from commit 91bb64a8d2014fda33a81fcf0fce37340f0d3b0c) Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
1 parent 3097bcb
File | Mode | Size |
---|---|---|
installer | ||
vss-win32 | ||
channel-posix.c | -rw-r--r-- | 8.7 KB |
channel-win32.c | -rw-r--r-- | 10.1 KB |
channel.h | -rw-r--r-- | 964 bytes |
commands-bsd.c | -rw-r--r-- | 5.3 KB |
commands-common.h | -rw-r--r-- | 2.1 KB |
commands-linux.c | -rw-r--r-- | 8.6 KB |
commands-posix-ssh.c | -rw-r--r-- | 12.7 KB |
commands-posix.c | -rw-r--r-- | 95.6 KB |
commands-win32.c | -rw-r--r-- | 77.0 KB |
commands.c | -rw-r--r-- | 17.6 KB |
cutils.c | -rw-r--r-- | 670 bytes |
cutils.h | -rw-r--r-- | 125 bytes |
guest-agent-command-state.c | -rw-r--r-- | 1.7 KB |
guest-agent-core.h | -rw-r--r-- | 1.6 KB |
main.c | -rw-r--r-- | 49.1 KB |
meson.build | -rw-r--r-- | 7.1 KB |
messages-win32.mc | -rw-r--r-- | 118 bytes |
qapi-schema.json | -rw-r--r-- | 44.8 KB |
service-win32.c | -rw-r--r-- | 5.5 KB |
service-win32.h | -rw-r--r-- | 1.0 KB |
vss-win32.c | -rw-r--r-- | 4.5 KB |
vss-win32.h | -rw-r--r-- | 673 bytes |
Computing file changes ...