https://github.com/shader-slang/slang
Revision 9a7849d893ebb755a607befff6b3429830421112 authored by Tim Foley on 23 April 2018, 17:37:56 UTC, committed by GitHub on 23 April 2018, 17:37:56 UTC
* Improve SSA promotion for arrays and structs

Fixes #518

The existing SSA pass would only handle `load(v)` and `store(v,...)`
where `v` is the variable instruction, and would bail out if `v` was
used as an operand in any other fashion.

The new pass adds support for `load(ac)` where `ac` is an "access chain"
with a gramar like:

    ac :: v
        | getElementPtr(ac, ...)
	| getFieldAddress(ac, ...)

What this means in practical terms is that we can promote a local
variable of array or structure type to an SSA temporary even if there
are loads of individual elements/fields, as along as any *assignment* to
the variable assigns the whole thing.

I've added a test case to confirm that this change fixes passing of
arrays as function parameters for Vulkan.

* Fixup: disable test on Vulkan because render-test isn't ready

This is a fix for Vulkan, but I don't think our testing setup is ready
for it.

* Fixup: error in unreachable return case, caught by clang

* Fixups based on testing

These are fixes found when testing the original changes against the user code that originated the bug report.

* `emit.cpp`: Make sure to handle array-of-texture types when deciding whether to declare a temporary as a local variable in GLSL output

* `ir-legalize-types.cpp`: Make a not of a source of validation failures that we need to clean up sooner or later (just not in scope for this bug fix change).

* `ir-ssa.cpp`:
  * When checking if something is an access chain with a promotable var at the end, make sure the recursive case recurses into the "access chain" logic instead of the leaf case
  * Add some assertions to guard the assumption that any access chain we apply has been scheduled for removal
  * Correctly emit an element *extract* instead of getting an element *address* when promoting an element access into an array being promoted
  * Eliminate a wrapper routine that was setting up an `IRBuilder` and use the one from the block being processed in the SSA pass (since it was set up for stuff just like this)

* `ir-validate.cpp`
  * Add a hack to avoid validation failures when running IR validation on the stdlib code. This case triggers for an initializer (`__init`) declaration inside an interface, since the logical "return type" is the interface type itself, which has no representation at the IR level and thus yields a null result type in a `FuncType` instruction.
1 parent 627de1c
Raw File
Tip revision: 9a7849d893ebb755a607befff6b3429830421112 authored by Tim Foley on 23 April 2018, 17:37:56 UTC
Improve SSA promotion for arrays and structs (#521)
Tip revision: 9a7849d
.editorconfig
# This file sets up basic text editor behavior
# using EditorConfig: http://EditorConfig.org.
#
# Some editors will import and use the settings from
# this file automatically, while others need a plugin.

# Editors are supposed to search upwards from a source
# file to find configuration settings until they see
# a "root" file. This file should be a root:
#
root = true

# Shared configuration for all C/C++ and Slang code
#
[*.{c,cpp,h,slang}]

# Use UTF-8 encoding
#
charset = utf-8

# Indent using 4 spaces.
#
indent_style = space
indent_size = 4

# Insert a newline at the end of the file
# if one is missing (this used to be officially
# required by C, but it is also just a tidyness thing)
#
insert_final_newline = true

# Remove any extra whitespace characters at the
# end of a line. This is just for tidyness, to
# minimize the chances of introducing whitspace
# diffs that are hard to spot.
#
trim_trailing_whitespace = true
back to top