https://github.com/shader-slang/slang
Revision 9a7849d893ebb755a607befff6b3429830421112 authored by Tim Foley on 23 April 2018, 17:37:56 UTC, committed by GitHub on 23 April 2018, 17:37:56 UTC
* Improve SSA promotion for arrays and structs Fixes #518 The existing SSA pass would only handle `load(v)` and `store(v,...)` where `v` is the variable instruction, and would bail out if `v` was used as an operand in any other fashion. The new pass adds support for `load(ac)` where `ac` is an "access chain" with a gramar like: ac :: v | getElementPtr(ac, ...) | getFieldAddress(ac, ...) What this means in practical terms is that we can promote a local variable of array or structure type to an SSA temporary even if there are loads of individual elements/fields, as along as any *assignment* to the variable assigns the whole thing. I've added a test case to confirm that this change fixes passing of arrays as function parameters for Vulkan. * Fixup: disable test on Vulkan because render-test isn't ready This is a fix for Vulkan, but I don't think our testing setup is ready for it. * Fixup: error in unreachable return case, caught by clang * Fixups based on testing These are fixes found when testing the original changes against the user code that originated the bug report. * `emit.cpp`: Make sure to handle array-of-texture types when deciding whether to declare a temporary as a local variable in GLSL output * `ir-legalize-types.cpp`: Make a not of a source of validation failures that we need to clean up sooner or later (just not in scope for this bug fix change). * `ir-ssa.cpp`: * When checking if something is an access chain with a promotable var at the end, make sure the recursive case recurses into the "access chain" logic instead of the leaf case * Add some assertions to guard the assumption that any access chain we apply has been scheduled for removal * Correctly emit an element *extract* instead of getting an element *address* when promoting an element access into an array being promoted * Eliminate a wrapper routine that was setting up an `IRBuilder` and use the one from the block being processed in the SSA pass (since it was set up for stuff just like this) * `ir-validate.cpp` * Add a hack to avoid validation failures when running IR validation on the stdlib code. This case triggers for an initializer (`__init`) declaration inside an interface, since the logical "return type" is the interface type itself, which has no representation at the IR level and thus yields a null result type in a `FuncType` instruction.
1 parent 627de1c
Tip revision: 9a7849d893ebb755a607befff6b3429830421112 authored by Tim Foley on 23 April 2018, 17:37:56 UTC
Improve SSA promotion for arrays and structs (#521)
Improve SSA promotion for arrays and structs (#521)
Tip revision: 9a7849d
.travis.yml
# .travis.yml
#
# This is the configuration file to drive Travis CI for Slang.
language: cpp
env:
- SLANG_TEST_FLAGS=-travis
# Build and test (clang, gcc) x (debug, release)
#
# We customize the set of tests run per-target to
# avoid having the build take too long.
matrix:
include:
- os: linux
compiler: gcc
env:
- CONFIGURATION=debug
- SLANG_TEST_CATEGORY=smoke
- os: linux
compiler: clang
env:
- CONFIGURATION=debug
- SLANG_TEST_CATEGORY=smoke
- os: linux
compiler: clang
env:
- CONFIGURATION=release
- SLANG_TEST_CATEGORY=smoke
- os: linux
compiler: gcc
env:
- CONFIGURATION=release
- SLANG_TEST_CATEGORY=full
- SLANG_DEPLOY=true
# Travis wants to default to a build script that invokes
# `./configure && make && make test` which is appropriate
# for autoconf, but I don't want to get into that mess..
#
script: make && make test
before_deploy: |
export SLANG_OS_NAME=${TRAVIS_OS_NAME}
export SLANG_ARCH_NAME=`uname -p`
export SLANG_TAG=${TRAVIS_TAG#v}
export SLANG_BINARY_ARCHIVE=slang-${SLANG_TAG}-${SLANG_OS_NAME}-${SLANG_ARCH_NAME}.zip
zip -r ${SLANG_BINARY_ARCHIVE} bin/*/*/slangc bin/*/*/libslang.so bin/*/*/libslang-glslang.so docs/*.md README.md LICENSE slang.h
# We are going to deploy to GitHub Releases
# on a successful build from a tag, but only
# on the one target in the build matrix that set
# `SLANG_DEPLOY`
deploy:
provider: releases
api_key: "$GITHUB_RELEASE_TOKEN"
file: "$SLANG_BINARY_ARCHIVE"
skip_cleanup: true
on:
condition: "$SLANG_DEPLOY = true"
tags: true
Computing file changes ...