Revision 9aea5a65aa7a1af9a4236dfaeb0088f1624f9919 authored by Roland McGrath on 08 September 2010, 02:37:06 UTC, committed by Linus Torvalds on 10 September 2010, 15:10:26 UTC
An execve with a very large total of argument/environment strings
can take a really long time in the execve system call.  It runs
uninterruptibly to count and copy all the strings.  This change
makes it abort the exec quickly if sent a SIGKILL.

Note that this is the conservative change, to interrupt only for
SIGKILL, by using fatal_signal_pending().  It would be perfectly
correct semantics to let any signal interrupt the string-copying in
execve, i.e. use signal_pending() instead of fatal_signal_pending().
We'll save that change for later, since it could have user-visible
consequences, such as having a timer set too quickly make it so that
an execve can never complete, though it always happened to work before.

Signed-off-by: Roland McGrath <roland@redhat.com>
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 7993bc1
History
File Mode Size
Kconfig -rw-r--r-- 3.1 KB
Makefile -rw-r--r-- 482 bytes
core-card.c -rw-r--r-- 18.2 KB
core-cdev.c -rw-r--r-- 45.3 KB
core-device.c -rw-r--r-- 32.7 KB
core-iso.c -rw-r--r-- 9.4 KB
core-topology.c -rw-r--r-- 14.9 KB
core-transaction.c -rw-r--r-- 33.4 KB
core.h -rw-r--r-- 6.9 KB
net.c -rw-r--r-- 42.6 KB
nosy-user.h -rw-r--r-- 590 bytes
nosy.c -rw-r--r-- 17.4 KB
nosy.h -rw-r--r-- 9.7 KB
ohci.c -rw-r--r-- 85.3 KB
ohci.h -rw-r--r-- 7.2 KB
sbp2.c -rw-r--r-- 48.1 KB

back to top