Revision 9aea5a65aa7a1af9a4236dfaeb0088f1624f9919 authored by Roland McGrath on 08 September 2010, 02:37:06 UTC, committed by Linus Torvalds on 10 September 2010, 15:10:26 UTC
An execve with a very large total of argument/environment strings
can take a really long time in the execve system call.  It runs
uninterruptibly to count and copy all the strings.  This change
makes it abort the exec quickly if sent a SIGKILL.

Note that this is the conservative change, to interrupt only for
SIGKILL, by using fatal_signal_pending().  It would be perfectly
correct semantics to let any signal interrupt the string-copying in
execve, i.e. use signal_pending() instead of fatal_signal_pending().
We'll save that change for later, since it could have user-visible
consequences, such as having a timer set too quickly make it so that
an execve can never complete, though it always happened to work before.

Signed-off-by: Roland McGrath <roland@redhat.com>
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 7993bc1
History
File Mode Size
x86
Kconfig -rw-r--r-- 501 bytes
Makefile -rw-r--r-- 1.2 KB
README -rw-r--r-- 1.7 KB
core.c -rw-r--r-- 10.3 KB
hypercalls.c -rw-r--r-- 9.3 KB
interrupts_and_traps.c -rw-r--r-- 20.2 KB
lg.h -rw-r--r-- 8.0 KB
lguest_device.c -rw-r--r-- 15.1 KB
lguest_user.c -rw-r--r-- 15.3 KB
page_tables.c -rw-r--r-- 38.8 KB
segments.c -rw-r--r-- 7.7 KB

README

back to top