https://github.com/torvalds/linux
Revision 9b284cbdb5de3b8871014f8290d1b540e5181c21 authored by Linus Torvalds on 05 July 2015, 02:11:33 UTC, committed by Linus Torvalds on 05 July 2015, 02:11:33 UTC
Commit 835a6a2f8603 ("Bluetooth: Stop sabotaging list poisoning")
thought that the code was sabotaging the list poisoning when NULL'ing
out the list pointers and removed it.

But what was going on was that the bluetooth code was using NULL
pointers for the list as a way to mark it empty, and that commit just
broke it (and replaced the test with NULL with a "list_empty()" test on
a uninitialized list instead, breaking things even further).

So fix it all up to use the regular and real list_empty() handling
(which does not use NULL, but a pointer to itself), also making sure to
initialize the list properly (the previous NULL case was initialized
implicitly by the session being allocated with kzalloc())

This is a combination of patches by Marcel Holtmann and Tedd Ho-Jeong
An.

[ I would normally expect to get this through the bt tree, but I'm going
  to release -rc1, so I'm just committing this directly   - Linus ]

Reported-and-tested-by: Jörg Otte <jrg.otte@gmail.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Original-by: Tedd Ho-Jeong An <tedd.an@intel.com>
Original-by: Marcel Holtmann <marcel@holtmann.org>:
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 5c755fe
History
Tip revision: 9b284cbdb5de3b8871014f8290d1b540e5181c21 authored by Linus Torvalds on 05 July 2015, 02:11:33 UTC
bluetooth: fix list handling
Tip revision: 9b284cb
File Mode Size
asymmetric_keys
async_tx
.gitignore -rw-r--r-- 12 bytes
842.c -rw-r--r-- 2.6 KB
Kconfig -rw-r--r-- 45.5 KB
Makefile -rw-r--r-- 4.6 KB
ablk_helper.c -rw-r--r-- 4.2 KB
ablkcipher.c -rw-r--r-- 17.9 KB
aead.c -rw-r--r-- 23.9 KB
aes_generic.c -rw-r--r-- 62.0 KB
af_alg.c -rw-r--r-- 9.8 KB
ahash.c -rw-r--r-- 14.8 KB
akcipher.c -rw-r--r-- 3.0 KB
algapi.c -rw-r--r-- 20.6 KB
algboss.c -rw-r--r-- 6.4 KB
algif_aead.c -rw-r--r-- 13.7 KB
algif_hash.c -rw-r--r-- 6.6 KB
algif_rng.c -rw-r--r-- 5.2 KB
algif_skcipher.c -rw-r--r-- 18.4 KB
ansi_cprng.c -rw-r--r-- 10.9 KB
anubis.c -rw-r--r-- 27.8 KB
api.c -rw-r--r-- 13.8 KB
arc4.c -rw-r--r-- 3.4 KB
authenc.c -rw-r--r-- 20.1 KB
authencesn.c -rw-r--r-- 23.1 KB
blkcipher.c -rw-r--r-- 20.0 KB
blowfish_common.c -rw-r--r-- 15.7 KB
blowfish_generic.c -rw-r--r-- 3.4 KB
camellia_generic.c -rw-r--r-- 34.9 KB
cast5_generic.c -rw-r--r-- 20.9 KB
cast6_generic.c -rw-r--r-- 9.5 KB
cast_common.c -rw-r--r-- 13.1 KB
cbc.c -rw-r--r-- 7.5 KB
ccm.c -rw-r--r-- 21.5 KB
chacha20_generic.c -rw-r--r-- 5.9 KB
chacha20poly1305.c -rw-r--r-- 18.4 KB
chainiv.c -rw-r--r-- 7.6 KB
cipher.c -rw-r--r-- 3.3 KB
cmac.c -rw-r--r-- 7.5 KB
compress.c -rw-r--r-- 1.3 KB
crc32.c -rw-r--r-- 3.7 KB
crc32c_generic.c -rw-r--r-- 4.4 KB
crct10dif_common.c -rw-r--r-- 3.6 KB
crct10dif_generic.c -rw-r--r-- 3.2 KB
cryptd.c -rw-r--r-- 26.1 KB
crypto_null.c -rw-r--r-- 5.3 KB
crypto_user.c -rw-r--r-- 13.4 KB
crypto_wq.c -rw-r--r-- 972 bytes
ctr.c -rw-r--r-- 12.3 KB
cts.c -rw-r--r-- 9.8 KB
deflate.c -rw-r--r-- 5.4 KB
des_generic.c -rw-r--r-- 35.7 KB
drbg.c -rw-r--r-- 56.0 KB
ecb.c -rw-r--r-- 4.9 KB
echainiv.c -rw-r--r-- 7.3 KB
eseqiv.c -rw-r--r-- 5.9 KB
fcrypt.c -rw-r--r-- 18.0 KB
fips.c -rw-r--r-- 1.6 KB
gcm.c -rw-r--r-- 32.1 KB
gf128mul.c -rw-r--r-- 13.2 KB
ghash-generic.c -rw-r--r-- 3.7 KB
hash_info.c -rw-r--r-- 1.8 KB
hmac.c -rw-r--r-- 6.8 KB
internal.h -rw-r--r-- 4.1 KB
jitterentropy-kcapi.c -rw-r--r-- 5.9 KB
jitterentropy.c -rw-r--r-- 23.9 KB
khazad.c -rw-r--r-- 51.8 KB
lrw.c -rw-r--r-- 9.2 KB
lz4.c -rw-r--r-- 2.5 KB
lz4hc.c -rw-r--r-- 2.6 KB
lzo.c -rw-r--r-- 2.6 KB
mcryptd.c -rw-r--r-- 18.0 KB
md4.c -rw-r--r-- 6.2 KB
md5.c -rw-r--r-- 3.9 KB
memneq.c -rw-r--r-- 6.1 KB
michael_mic.c -rw-r--r-- 3.6 KB
pcbc.c -rw-r--r-- 7.7 KB
pcompress.c -rw-r--r-- 2.9 KB
pcrypt.c -rw-r--r-- 13.0 KB
poly1305_generic.c -rw-r--r-- 7.8 KB
proc.c -rw-r--r-- 3.0 KB
ripemd.h -rw-r--r-- 974 bytes
rmd128.c -rw-r--r-- 10.2 KB
rmd160.c -rw-r--r-- 12.6 KB
rmd256.c -rw-r--r-- 10.6 KB
rmd320.c -rw-r--r-- 13.1 KB
rng.c -rw-r--r-- 5.0 KB
rsa.c -rw-r--r-- 6.0 KB
rsa_helper.c -rw-r--r-- 2.6 KB
rsakey.asn1 -rw-r--r-- 107 bytes
salsa20_generic.c -rw-r--r-- 6.7 KB
scatterwalk.c -rw-r--r-- 3.9 KB
seed.c -rw-r--r-- 17.4 KB
seqiv.c -rw-r--r-- 19.0 KB
serpent_generic.c -rw-r--r-- 21.2 KB
sha1_generic.c -rw-r--r-- 2.4 KB
sha256_generic.c -rw-r--r-- 10.4 KB
sha512_generic.c -rw-r--r-- 7.1 KB
shash.c -rw-r--r-- 17.5 KB
tcrypt.c -rw-r--r-- 52.1 KB
tcrypt.h -rw-r--r-- 3.8 KB
tea.c -rw-r--r-- 6.6 KB
testmgr.c -rw-r--r-- 85.0 KB
testmgr.h -rw-r--r-- 1.1 MB
tgr192.c -rw-r--r-- 30.5 KB
twofish_common.c -rw-r--r-- 37.8 KB
twofish_generic.c -rw-r--r-- 6.3 KB
vmac.c -rw-r--r-- 18.9 KB
wp512.c -rw-r--r-- 59.8 KB
xcbc.c -rw-r--r-- 7.2 KB
xor.c -rw-r--r-- 4.0 KB
xts.c -rw-r--r-- 8.7 KB
zlib.c -rw-r--r-- 9.6 KB

back to top