Revision 9b4fe5fb0bdd8f31f24cbfe77e38ec8155c250c5 authored by Neil Horman on 12 July 2013, 17:35:33 UTC, committed by David S. Miller on 12 July 2013, 23:28:02 UTC
this bug:
https://bugzilla.redhat.com/show_bug.cgi?id=951695

Reported a dma debug backtrace:

WARNING: at lib/dma-debug.c:937 check_unmap+0x47d/0x930()
Hardware name: To Be Filled By O.E.M.
via-rhine 0000:00:12.0: DMA-API: device driver failed to check map error[device
address=0x0000000075a837b2] [size=90 bytes] [mapped as single]
Modules linked in: ip6_tables gspca_spca561 gspca_main videodev media
snd_hda_codec_realtek snd_hda_intel i2c_viapro snd_hda_codec snd_hwdep snd_seq
ppdev mperf via_rhine coretemp snd_pcm mii microcode snd_page_alloc snd_timer
snd_mpu401 snd_mpu401_uart snd_rawmidi snd_seq_device snd soundcore parport_pc
parport shpchp ata_generic pata_acpi radeon i2c_algo_bit drm_kms_helper ttm drm
pata_via sata_via i2c_core uinput
Pid: 295, comm: systemd-journal Not tainted 3.9.0-0.rc6.git2.1.fc20.x86_64 #1
Call Trace:
 <IRQ>  [<ffffffff81068dd0>] warn_slowpath_common+0x70/0xa0
 [<ffffffff81068e4c>] warn_slowpath_fmt+0x4c/0x50
 [<ffffffff8137ec6d>] check_unmap+0x47d/0x930
 [<ffffffff810ace9f>] ? local_clock+0x5f/0x70
 [<ffffffff8137f17f>] debug_dma_unmap_page+0x5f/0x70
 [<ffffffffa0225edc>] ? rhine_ack_events.isra.14+0x3c/0x50 [via_rhine]
 [<ffffffffa02275f8>] rhine_napipoll+0x1d8/0xd80 [via_rhine]
 [<ffffffff815d3d51>] ? net_rx_action+0xa1/0x380
 [<ffffffff815d3e22>] net_rx_action+0x172/0x380
 [<ffffffff8107345f>] __do_softirq+0xff/0x400
 [<ffffffff81073925>] irq_exit+0xb5/0xc0
 [<ffffffff81724cd6>] do_IRQ+0x56/0xc0
 [<ffffffff81719ff2>] common_interrupt+0x72/0x72
 <EOI>  [<ffffffff8170ff57>] ? __slab_alloc+0x4c2/0x526
 [<ffffffff811992e0>] ? mmap_region+0x2b0/0x5a0
 [<ffffffff810d5807>] ? __lock_is_held+0x57/0x80
 [<ffffffff811992e0>] ? mmap_region+0x2b0/0x5a0
 [<ffffffff811bf1bf>] kmem_cache_alloc+0x2df/0x360
 [<ffffffff811992e0>] mmap_region+0x2b0/0x5a0
 [<ffffffff811998e6>] do_mmap_pgoff+0x316/0x3d0
 [<ffffffff81183ca0>] vm_mmap_pgoff+0x90/0xc0
 [<ffffffff81197d6c>] sys_mmap_pgoff+0x4c/0x190
 [<ffffffff81367d7e>] ? trace_hardirqs_on_thunk+0x3a/0x3f
 [<ffffffff8101eb42>] sys_mmap+0x22/0x30
 [<ffffffff81722fd9>] system_call_fastpath+0x16/0x1b

Usual problem with the usual fix, add the appropriate calls to dma_mapping_error
where appropriate

Untested, as I don't have hardware, but its pretty straightforward

Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
CC: David S. Miller <davem@davemloft.net>
CC: Roger Luethi <rl@hellgate.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 352900b
History
File Mode Size
Kconfig -rw-r--r-- 15.7 KB
Makefile -rw-r--r-- 3.1 KB
spi-altera.c -rw-r--r-- 7.5 KB
spi-ath79.c -rw-r--r-- 7.3 KB
spi-atmel.c -rw-r--r-- 42.4 KB
spi-au1550.c -rw-r--r-- 25.8 KB
spi-bcm2835.c -rw-r--r-- 11.0 KB
spi-bcm63xx.c -rw-r--r-- 12.7 KB
spi-bfin-sport.c -rw-r--r-- 22.8 KB
spi-bfin5xx.c -rw-r--r-- 40.1 KB
spi-bitbang-txrx.h -rw-r--r-- 3.0 KB
spi-bitbang.c -rw-r--r-- 13.0 KB
spi-butterfly.c -rw-r--r-- 8.5 KB
spi-clps711x.c -rw-r--r-- 7.1 KB
spi-coldfire-qspi.c -rw-r--r-- 14.8 KB
spi-davinci.c -rw-r--r-- 27.2 KB
spi-dw-mid.c -rw-r--r-- 6.0 KB
spi-dw-mmio.c -rw-r--r-- 3.1 KB
spi-dw-pci.c -rw-r--r-- 3.8 KB
spi-dw.c -rw-r--r-- 21.9 KB
spi-dw.h -rw-r--r-- 5.8 KB
spi-ep93xx.c -rw-r--r-- 30.5 KB
spi-falcon.c -rw-r--r-- 11.1 KB
spi-fsl-cpm.c -rw-r--r-- 9.6 KB
spi-fsl-cpm.h -rw-r--r-- 1.6 KB
spi-fsl-espi.c -rw-r--r-- 17.5 KB
spi-fsl-lib.c -rw-r--r-- 5.9 KB
spi-fsl-lib.h -rw-r--r-- 3.7 KB
spi-fsl-spi.c -rw-r--r-- 22.3 KB
spi-fsl-spi.h -rw-r--r-- 2.0 KB
spi-gpio.c -rw-r--r-- 14.6 KB
spi-imx.c -rw-r--r-- 24.1 KB
spi-lm70llp.c -rw-r--r-- 9.1 KB
spi-mpc512x-psc.c -rw-r--r-- 15.5 KB
spi-mpc52xx-psc.c -rw-r--r-- 13.3 KB
spi-mpc52xx.c -rw-r--r-- 14.4 KB
spi-mxs.c -rw-r--r-- 14.6 KB
spi-nuc900.c -rw-r--r-- 9.6 KB
spi-oc-tiny.c -rw-r--r-- 10.0 KB
spi-octeon.c -rw-r--r-- 8.3 KB
spi-omap-100k.c -rw-r--r-- 15.3 KB
spi-omap-uwire.c -rw-r--r-- 13.2 KB
spi-omap2-mcspi.c -rw-r--r-- 37.5 KB
spi-orion.c -rw-r--r-- 11.7 KB
spi-pl022.c -rw-r--r-- 68.3 KB
spi-ppc4xx.c -rw-r--r-- 13.6 KB
spi-pxa2xx-dma.c -rw-r--r-- 9.6 KB
spi-pxa2xx-pci.c -rw-r--r-- 1.9 KB
spi-pxa2xx-pxadma.c -rw-r--r-- 13.4 KB
spi-pxa2xx.c -rw-r--r-- 34.5 KB
spi-pxa2xx.h -rw-r--r-- 5.6 KB
spi-rspi.c -rw-r--r-- 19.2 KB
spi-s3c24xx-fiq.S -rw-r--r-- 2.9 KB
spi-s3c24xx-fiq.h -rw-r--r-- 671 bytes
spi-s3c24xx.c -rw-r--r-- 16.3 KB
spi-s3c64xx.c -rw-r--r-- 43.8 KB
spi-sc18is602.c -rw-r--r-- 8.4 KB
spi-sh-hspi.c -rw-r--r-- 7.6 KB
spi-sh-msiof.c -rw-r--r-- 18.3 KB
spi-sh-sci.c -rw-r--r-- 4.7 KB
spi-sh.c -rw-r--r-- 12.3 KB
spi-sirf.c -rw-r--r-- 17.9 KB
spi-tegra114.c -rw-r--r-- 33.7 KB
spi-tegra20-sflash.c -rw-r--r-- 16.9 KB
spi-tegra20-slink.c -rw-r--r-- 34.8 KB
spi-ti-ssp.c -rw-r--r-- 8.9 KB
spi-tle62x0.c -rw-r--r-- 7.3 KB
spi-topcliff-pch.c -rw-r--r-- 47.9 KB
spi-txx9.c -rw-r--r-- 11.7 KB
spi-xcomm.c -rw-r--r-- 6.0 KB
spi-xilinx.c -rw-r--r-- 14.6 KB
spi.c -rw-r--r-- 47.3 KB
spidev.c -rw-r--r-- 17.6 KB

back to top