9b8f056 | Andrew Kushnir | 15 September 2021, 17:26:25 UTC | release: cut the v12.2.6 release (#43462) | 15 September 2021, 17:26:25 UTC |
2050b08 | Joe Martin (Crowdstaffing) | 14 September 2021, 19:24:31 UTC | docs: update grammar (#43451) Update grammar per review. PR Close #43451 | 14 September 2021, 22:51:31 UTC |
5af9404 | Joe Martin (Crowdstaffing) | 14 September 2021, 19:23:17 UTC | docs: update grammar (#43451) Update grammar per review. PR Close #43451 | 14 September 2021, 22:51:31 UTC |
d5c5841 | Joe Martin (Crowdstaffing) | 14 September 2021, 19:21:34 UTC | docs: update link (#43451) Update link per review. PR Close #43451 | 14 September 2021, 22:51:31 UTC |
69035dd | Joe Martin (Crowdstaffing) | 14 September 2021, 19:18:15 UTC | docs: update punctuation (#43451) Update punctuation per review. PR Close #43451 | 14 September 2021, 22:51:31 UTC |
1a3a870 | Joe Martin (Crowdstaffing) | 14 September 2021, 19:15:08 UTC | docs: update grammar (#43451) Update grammar per review. PR Close #43451 | 14 September 2021, 22:51:31 UTC |
75abf86 | Joe Martin (Crowdstaffing) | 14 September 2021, 19:11:31 UTC | docs: update spelling (#43451) Update spelling per review. PR Close #43451 | 14 September 2021, 22:51:31 UTC |
f099d9c | Joe Martin (Crowdstaffing) | 14 September 2021, 19:09:12 UTC | docs: update capitalization (#43451) Update capitalization per review. PR Close #43451 | 14 September 2021, 22:51:31 UTC |
24cf4ea | Andrew Scott | 10 September 2021, 21:02:58 UTC | refactor(router): Remove TODO and slightly adjust eager browserUrlTree update (#43426) No test was added for this case because I can't think of a test case to write that would work. This change updates the code for a consistent mental model of setting the `browserUrlTree`. It's only meant to track the `UrlTree` that the `UrlHandlingStrategy` is set to extract, not the full `rawUrl`. Notice that everywhere else, the `browserUrlTree` is set to `urlAfterRedirects`, which is computed based on the extracted URL, _not_ the `rawUrl`. PR Close #43426 | 14 September 2021, 18:11:43 UTC |
2f94ac3 | David Shevitz | 01 September 2021, 23:06:41 UTC | docs: add guidelines for localizing angular documentation (#43314) PR Close #43314 | 14 September 2021, 15:32:51 UTC |
d2bee44 | George Kalpakas | 14 September 2021, 10:59:19 UTC | perf(docs-infra): reduce unnecessary whitespace in API docs (#43435) The HTML for the docs pages is generated by Dgeni based on some [Nunjucks][1] templates. Previously, these templates were set up in a way that introduced a lot excess whitespace in the generated HTML, unnecessarily bloating the corresponding JSON files that need to be downloaded in order to view a certain docs page. This has been discussed in #28105 and was again observed while investigating #43285. This commit refactors some of the templates related to API docs (which seem to be the most affected ones) to drastically reduce the amount of excess whitespace. More specifically, the total size of all files in `generated/docs/api/` was reduced from ~13MB to ~7MB. Besides the reduced payload size for each API page, this change will also reduce the amount of memory needed by the ServiceWorker to cache the API pages that have been visited by a user. NOTE: The affected files are not eagerly downloaded when navigating to angular.io. Instead, each file is downloaded individually, as soon as a user visits the corresponding API docs page. Therefore, the impact of this change will be relatively small for most users. [1]: https://mozilla.github.io/nunjucks/ PR Close #43435 | 14 September 2021, 15:29:51 UTC |
7f23958 | George Kalpakas | 14 September 2021, 10:59:19 UTC | build(docs-infra): update `remark-html` to 13.0.2 (#43435) NOTE: This [version][1] includes a breaking fix ([commit b0b1ba5c5][2]), which turns sanitization on by default. Since, we don't need sanitization (the HTML is authored by docs authors and tooling and should be safe), this commit restores the old behavior by setting the [sanitize][3] option to `false`. [1]: https://github.com/remarkjs/remark-html/releases/tag/13.0.2 [2]: https://github.com/remarkjs/remark-html/commit/b0b1ba5c55a58b26bbe1ca3b6def18e95dbbd89e [3]: https://github.com/remarkjs/remark-html#optionssanitize PR Close #43435 | 14 September 2021, 15:29:50 UTC |
e74eac2 | George Kalpakas | 14 September 2021, 10:59:18 UTC | build(docs-infra): update `github-slugger` to 1.4.0 (#43435) NOTE: This [version][1] includes a breaking fix ([commit af59f343d][2]). More specifically `github-slugger` will no longer trim the text of a heading before generating an ID and (with whitespace converted to `-`) this results in different heading IDs: **Before:** `<h3> foo bar </h3>` --> `<h3 id="foo-bar">...` **After:** `<h3> foo bar </h3>` --> `<h3 id="--foo-bar--">...` The different IDs now break some of our anchor-links, becuase `github-slugger` is used by [rehype-slug][3], which is in turn used by our [autolinkHeadings][4] dgeni post-processor. To avoid the issue with broken anchor links, we update the `renderMethodDetail()` nunjucks macro to omit excess whitespace in headings. [1]: https://github.com/Flet/github-slugger/releases/tag/v1.4.0 [2]: https://github.com/Flet/github-slugger/commit/af59f343dc7fe88a94a79c721fb3225a275a095d [3]: https://github.com/rehypejs/rehype-slug [4]: https://github.com/angular/angular/blob/75a3c778b1f7be913f0287423d40fade68ee9adc/aio/tools/transforms/angular-base-package/post-processors/autolink-headings.js#L3 PR Close #43435 | 14 September 2021, 15:29:50 UTC |
4034f25 | Andrew Scott | 10 September 2021, 20:25:14 UTC | fix(router): Allow renavigating to failed URLs (#43424) There are situations where the Router does not currently clean up failed navigations correctly. While this is problematic on its own, we can mitigate some of the damage by processing any URL when we get a navigation request when the internal router state is out of sync. Each of the added tests would fail without this change. fixes #34795 PR Close #43424 | 13 September 2021, 21:48:01 UTC |
a102b27 | Naveed Ahmed | 13 September 2021, 16:59:06 UTC | fix(service-worker): clear service worker cache in safety worker (#43324) clear angular service worker cache in safety worker to ensure stale or broken contents are not served in future requests Fixes #43163 PR Close #43324 | 13 September 2021, 21:34:33 UTC |
baf8145 | mezhik91 | 28 August 2021, 14:00:39 UTC | docs: add Dmytro Mezhenskyi to GDE resources (#43282) PR Close #43282 | 13 September 2021, 19:57:00 UTC |
52c320f | dario-piotrowicz | 10 September 2021, 20:44:36 UTC | docs: remove unnecessary "https://angular.io/" from aio links (#43425) PR Close #43425 | 13 September 2021, 16:24:07 UTC |
176aa99 | Renovate Bot | 10 September 2021, 05:17:24 UTC | build: update dependency karma to v6 (#43422) Updates the dependency for Karma to v6. This is a patch port PR. PR Close #43422 | 13 September 2021, 16:23:24 UTC |
c817935 | Bjarki | 06 August 2021, 16:07:11 UTC | fix(docs-infra): bump aio size limit (#43406) Increase the aio size tracking limit as a result of Trusted Types refactoring. PR Close #43406 | 10 September 2021, 16:24:48 UTC |
604965b | Bjarki | 08 July 2021, 12:25:33 UTC | build(docs-infra): enable tsec security checker (#43406) tsec is a TypeScript compiler wrapper for restricting use of security-sensitive DOM APIs, in particular those that could lead to XSS or Trusted Types violations. Add it as a linter to aio to prevent future Trusted Types regressions on angular.io. Also introduces security_exemptions.json, which lists the known, security-reviewed tsec security violations. New entries can only be added to this file after a security review, in particular making sure that the corresponding code does not cause XSS vulnerabilities or Trusted Types violations. PR Close #43406 | 10 September 2021, 16:24:48 UTC |
2f47de8 | Bjarki | 07 July 2021, 17:05:35 UTC | build(docs-infra): send CSP reports for Trusted Types violations (#43406) Configure Firebase to serve a CSP header on angular.io that enables Trusted Types in report-only mode. This causes any Trusted Types violations that may occur as users browser angular.io to generate a CSP report that is sent to csp.withgoogle.com, where it is processed by Google's CSP report collector. This is a non-breaking change that allows us to evaluate whether angular.io is fully compatible with Trusted Types, at which point we can start enforcing Trusted Types. PR Close #43406 | 10 September 2021, 16:24:48 UTC |
d86e1ab | Bjarki | 06 July 2021, 03:09:18 UTC | build(docs-infra): enable Trusted Types enforcement in angular.json (#43406) Configure angular.json to serve a CSP header that enabled Trusted Types in enforcement mode, both in e2e tests and when running the local development server. This should help prevent regressions related to Trusted Types in the angular.io app. PR Close #43406 | 10 September 2021, 16:24:48 UTC |
e5ee5a2 | Bjarki | 06 July 2021, 02:32:08 UTC | fix(docs-infra): pass a TrustedScriptURL to ServiceWorkerModule (#43406) Fix a Trusted Types violation in ServiceWorkerModule that occurs when initializing the service worker from a string URL, by passing a TrustedScriptURL instead. PR Close #43406 | 10 September 2021, 16:24:48 UTC |
586302a | Bjarki | 06 July 2021, 02:30:52 UTC | fix(docs-infra): make doc-viewer compatible with Trusted Types (#43406) Change DocumentContents.contents to a TrustedHTML and update users accordingly. PR Close #43406 | 10 September 2021, 16:24:48 UTC |
02c514e | Bjarki | 06 July 2021, 02:25:29 UTC | fix(docs-infra): make custom icon registry compatible with Trusted Types (#43406) Change SvgIconInfo.svgSource to be a TrustedHTML and update all its users accordingly. Also introduce the svg template tag function for building TrustedHTML from constant SVG sources. PR Close #43406 | 10 September 2021, 16:24:48 UTC |
501cbc5 | Bjarki | 06 July 2021, 02:22:42 UTC | fix(docs-infra): make pretty-printer compatible with Trusted Types (#43406) Change the PrettyPrinter interface to accept a TrustedHTML and patch prettify.js so that it makes use of that value without modification. Update all users of the service to produce, and pass in a TrustedHTML. PR Close #43406 | 10 September 2021, 16:24:48 UTC |
ae13874 | Bjarki | 07 July 2021, 20:06:17 UTC | fix(docs-infra): fix simple Trusted Types violations (#43406) Also introduce a dependency on the Trusted Types type definitions and a Trusted Types polyfill, safevalues. Create a security module for common, security-reviewed transformations into Trusted Types. PR Close #43406 | 10 September 2021, 16:24:48 UTC |
93bb2dd | Bjarki | 06 July 2021, 01:46:00 UTC | fix(docs-infra): fix Trusted Types violation in Analytics snippet (#43406) The Google Analytics snippet loads its runtime by dynamically creating a script element and assigning a URL to its src attribute. This causes a Trusted Types violation. To fix this, create an inline Trusted Types policy called 'aio#analytics' to bless the script URL, which is a trusted constant. PR Close #43406 | 10 September 2021, 16:24:48 UTC |
b4a551c | mgechev | 07 September 2021, 22:38:38 UTC | docs: add ngUpgrade maintenance timeline (#43379) Add details about the maintenance timeline for ngUpgrade, reflecting the deprecation of AngularJS. PR Close #43379 | 10 September 2021, 16:23:12 UTC |
08528e9 | dario-piotrowicz | 06 September 2021, 21:37:25 UTC | docs: amend code related to string-expressions for property binding (#43366) resolves #43287 PR Close #43366 | 10 September 2021, 16:22:14 UTC |
cbf360d | Aristeidis Bampakos | 02 September 2021, 19:33:17 UTC | docs: add Architect Training to resources (#43327) PR Close #43327 | 09 September 2021, 21:54:00 UTC |
ea30979 | Andrew Scott | 08 September 2021, 15:35:38 UTC | docs: Add documentation and TODOs for cleanup (#43391) * Document `currentUrlTree`, `browserUrlTree`, and `rawUrlTree` * Add a couple `TODO` comments to investigate changes based on understanding PR Close #43391 | 09 September 2021, 21:53:27 UTC |
134e4f5 | Andrew Kushnir | 09 September 2021, 21:09:33 UTC | Revert "refactor(router): clean up unnecessary flag in `restoreHistory` function" (#43409) This reverts commit 061a456e39c80691b7fd374d2af33a9f6a753197. PR Close #43409 | 09 September 2021, 21:23:31 UTC |
8cc93b7 | Aristeidis Bampakos | 12 August 2021, 14:31:09 UTC | docs: add Angular Projects book in resources (#43130) PR Close #43130 | 09 September 2021, 18:33:37 UTC |
a0f0dee | David Shevitz | 20 August 2021, 16:42:47 UTC | docs: update the reviewed tag for what-is-angular topic (#43213) PR Close #43213 | 09 September 2021, 18:30:31 UTC |
0cc7ef6 | Amadou Sall | 25 August 2021, 15:36:23 UTC | docs: remove extraneous word in the Dependency injection in action guide (#43255) PR Close #43255 | 09 September 2021, 18:27:31 UTC |
565b749 | Michele Stieven | 23 August 2021, 18:46:50 UTC | docs: add Michele Stieven to GDE resources (#43233) PR Close #43233 | 09 September 2021, 18:21:03 UTC |
2658219 | Andrew Scott | 08 September 2021, 00:11:01 UTC | refactor(router): clean up unnecessary flag in `restoreHistory` function (#43382) This restores the `finalize` function to directly call `resetUrlToCurrentUrlTree`, as it was before efb440eb2f507f9a2675f2663f1af0b3c574c902. This allows us to simplify the `restoreHistory` function because it no longer needs to handle the call from `finalize` where it should not reset the internal router state. PR Close #43382 | 09 September 2021, 16:22:06 UTC |
141fde1 | Alan Agius | 04 September 2021, 09:35:38 UTC | fix(animations): emit pure annotations to static property initializers (#43344) Currently the pure annotations comments are not emitted because unless the entire expression is wrapped in braces. See the below TypeScript playgrounds https://www.typescriptlang.org/play?target=99&module=1&ts=4.4.2&ssl=8&ssc=1&pln=1&pc=1#code/MYGwhgzhAEByCuIQEkB2ArApsALgewCdoBvAXwFgAoKzADwAdCdowAjCHAsXaUSGNFlyESVaNA5gcAS2BwAqgBlF0ALzQA9ACpoAAQD6+gAryASgFFD0LRuipMAdziIUGbPgIAKAJQBuKhTUlMB4qBB4IJgAdCB4AOaegu6EUbBKin5UQA ```js "use strict"; Object.defineProperty(exports, "__esModule", { value: true }); exports.Injector = void 0; class NullInjector { } class Injector { } exports.Injector = Injector; Injector.NULL = new NullInjector(); console.log(Injector.NULL); ``` https://www.typescriptlang.org/play?target=99&module=1&ts=4.4.2&ssl=4&ssc=18&pln=4&pc=33#code/MYGwhgzhAEByCuIQEkB2ArApsALgewCdoBvAXwFgAoKzADwAdCdowAjCHAsXaUSGNFlyESVaNA5gcAS2BwAqgBlF0ALzQAFAHoAVNAACAfUMAFeQCUAoseg6t0VJgDucRCgzZ8BDQEofAbioKakpgPFQIPBBMADoQPABzDUFPQhjYJUUAqiA ```js "use strict"; Object.defineProperty(exports, "__esModule", { value: true }); exports.Injector = void 0; class NullInjector { } class Injector { } exports.Injector = Injector; Injector.NULL = ( /* @__PURE__ */new NullInjector()); console.log(Injector.NULL); ``` PR Close #43344 | 09 September 2021, 16:21:25 UTC |
ca510c8 | Alan Agius | 04 September 2021, 09:32:30 UTC | fix(core): emit pure annotations to static property initializers (#43344) Currently the pure annotations comments are not emitted because unless the entire expression is wrapped in braces. See the below TypeScript playgrounds https://www.typescriptlang.org/play?target=99&module=1&ts=4.4.2&ssl=8&ssc=1&pln=1&pc=1#code/MYGwhgzhAEByCuIQEkB2ArApsALgewCdoBvAXwFgAoKzADwAdCdowAjCHAsXaUSGNFlyESVaNA5gcAS2BwAqgBlF0ALzQA9ACpoAAQD6+gAryASgFFD0LRuipMAdziIUGbPgIAKAJQBuKhTUlMB4qBB4IJgAdCB4AOaegu6EUbBKin5UQA ```js "use strict"; Object.defineProperty(exports, "__esModule", { value: true }); exports.Injector = void 0; class NullInjector { } class Injector { } exports.Injector = Injector; Injector.NULL = new NullInjector(); console.log(Injector.NULL); ``` https://www.typescriptlang.org/play?target=99&module=1&ts=4.4.2&ssl=4&ssc=18&pln=4&pc=33#code/MYGwhgzhAEByCuIQEkB2ArApsALgewCdoBvAXwFgAoKzADwAdCdowAjCHAsXaUSGNFlyESVaNA5gcAS2BwAqgBlF0ALzQAFAHoAVNAACAfUMAFeQCUAoseg6t0VJgDucRCgzZ8BDQEofAbioKakpgPFQIPBBMADoQPABzDUFPQhjYJUUAqiA ```js "use strict"; Object.defineProperty(exports, "__esModule", { value: true }); exports.Injector = void 0; class NullInjector { } class Injector { }a exports.Injector = Injector; Injector.NULL = ( /* @__PURE__ */new NullInjector()); console.log(Injector.NULL); ``` PR Close #43344 | 09 September 2021, 16:21:24 UTC |
0e14dee | George Kalpakas | 07 September 2021, 17:52:56 UTC | docs(bazel): fix outdated redirect URL for `/guide/bazel` (#43376) The file we are redirecting `/guide/bazel` to was moved from `bazel/src/schematics/README.md` to `bazel/docs/BAZEL_SCHEMATICS.md` in commit 71b8c9ab29014f7e710e03ebda185c0a7c0c2620. Update the Firebase configuration to use the new path in the redirect URL. PR Close #43376 | 09 September 2021, 16:17:40 UTC |
e726a63 | Andrew Scott | 08 September 2021, 16:28:03 UTC | release: cut the v12.2.5 release (#43392) | 08 September 2021, 16:28:03 UTC |
c02e5e1 | dario-piotrowicz | 07 September 2021, 22:19:56 UTC | refactor(common): removed TODO no longer considered necessary (#43378) The TODO comment suggesting to verify that the target element to scroll to needs to be an anchor does not longer seems under consideration so it can be removed resolves #43348 PR Close #43378 | 07 September 2021, 23:05:32 UTC |
01d2f03 | Paul Gschwendtner | 07 September 2021, 13:08:17 UTC | ci: avoid failures when yarn unlinks bazelisk in windows jobs (#43365) Windows disallows removal of files which are currently being used. i.e. have active handles. This currently can result in permission denied failures on the Windows CI jobs where `yarn bazel` resolves to the local bazelisk installation that can be unlinked by `yarn_install` repository fetching as part of the Bazel invocation, resulting in errors like: ``` ERROR: An error occurred during the fetch of repository 'npm': yarn_install failed: $ node tools/yarn/check-yarn.js ... [4/5] Linking dependencies... info If you think this is a bug, please open a bug report with the information provided in "C:\\users\\circleci\\ng\\yarn-error.log". info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command. (warning " > tsickle@0.34.3" has incorrect peer dependency "typescript@~3.3.1". error An unexpected error occurred: "EPERM: operation not permitted, unlink 'C:\\users\\circleci\\ng\\node_modules\\@bazel\\bazel-win32_x64\\bazel-0.27.0-windows-x86_64.exe'". Process stalled Active handles: - Socket - Socket - Socket ) ``` We workarund this in order to improve CI stability in case the node modules are being invalidated by Bazel, or through Yarns integrity checking. PR Close #43365 | 07 September 2021, 21:29:58 UTC |
e5f9d2d | Paul Gschwendtner | 02 September 2021, 14:29:47 UTC | build: check .ng-dev tool configuration in CI (#43365) Checks the `.ng-dev` tool configuration in CI, compared to doing it locally when the caretaker intends to perform a merge and then realizes the config is broken. PR Close #43365 | 07 September 2021, 21:29:58 UTC |
68a7cc1 | Paul Gschwendtner | 02 September 2021, 14:22:06 UTC | build: update bazel setup to latest versions (#43365) Updates the overall Bazel setup to their latest versions: * rules_nodejs is updated to stable 4.0.0 * rules_sass is updated to the latest version containing a fix for the `@bazel/worker` bug we had a workaround for. * dev-infra-private is updated to avoid duplicated dependencies. We should use a version that also relies on stable rules_nodejs v4. Note: We are not set on how dependencies for the `bazel/` folder of the dev-infra package are managed, but we removed `@types/` packages from the transitive dependencies, so we now need to manually include `@types/uuid` for building the benchmark driver utilties. We need to revisit this in the future. PR Close #43365 | 07 September 2021, 21:29:58 UTC |
0bfb5b1 | Charles Barnes | 04 September 2021, 22:11:29 UTC | docs: remove Angular 9 from support table (#43350) PR Close #43350 | 07 September 2021, 21:29:32 UTC |
1bc1971 | dario-piotrowicz | 04 September 2021, 19:22:41 UTC | docs: fix app-hero-detaill typo (#43349) PR Close #43349 | 07 September 2021, 21:25:03 UTC |
4e11347 | George Kalpakas | 02 September 2021, 16:01:56 UTC | build: update feature request template to include core package (#43323) Update the dropdown list to include core in the list of packages. PR Close #43323 | 07 September 2021, 21:24:15 UTC |
3b4f121 | William Sedlacek | 05 September 2021, 07:54:30 UTC | docs(common): correct typos in jsdoc of http client (#43352) This corrects four typos in the HttpClient JSDoc capabilites => capabilities reuested => requested wuth => with responmse => response PR Close #43352 | 07 September 2021, 18:45:16 UTC |
d8f9e61 | Ikko Ashimine | 06 September 2021, 11:38:45 UTC | refactor: fix typo in postinstall-patches.js (#43362) refering -> referring PR Close #43362 | 07 September 2021, 18:44:47 UTC |
aa1782c | Enea Jahollari | 24 August 2021, 09:29:43 UTC | docs: enhance spacings in dynamic component loader section examples (#43241) PR Close #43241 | 02 September 2021, 16:45:10 UTC |
4e4a198 | Enea Jahollari | 24 August 2021, 09:24:36 UTC | docs: enhance spacings in content projection section examples (#43241) PR Close #43241 | 02 September 2021, 16:45:10 UTC |
5af9524 | Enea Jahollari | 24 August 2021, 09:21:26 UTC | docs: enhance spacings in inputs outputs section examples (#43241) PR Close #43241 | 02 September 2021, 16:45:10 UTC |
d7711d0 | Enea Jahollari | 24 August 2021, 09:18:05 UTC | docs: enhance spacings in component interaction section examples (#43241) PR Close #43241 | 02 September 2021, 16:45:10 UTC |
f5d0c88 | Enea Jahollari | 24 August 2021, 09:13:55 UTC | docs: enhance spacings in component lifecycle section examples (#43241) PR Close #43241 | 02 September 2021, 16:45:09 UTC |
dc46cc4 | Enea Jahollari | 24 August 2021, 09:09:39 UTC | docs: enhance spacings in component overview section examples (#43241) PR Close #43241 | 02 September 2021, 16:45:09 UTC |
39c50b5 | Enea Jahollari | 24 August 2021, 09:05:37 UTC | docs: enhance spacings in try it section examples (#43241) PR Close #43241 | 02 September 2021, 16:45:09 UTC |
8e1c309 | Enea Jahollari | 24 August 2021, 08:49:38 UTC | docs: enhance what is angular section spacing (#43241) PR Close #43241 | 02 September 2021, 16:45:09 UTC |
a6e22c4 | Pete Bacon Darwin | 02 September 2021, 11:30:15 UTC | build(docs-infra): update dgeni-packages to improve checkLinks messages (#43317) This update should make the list of files with broken links more readable. Fixes #43214 PR Close #43317 | 02 September 2021, 16:44:47 UTC |
a0bd6e9 | Alan Agius | 31 August 2021, 13:02:19 UTC | fix(router): add more context to `Unhandled Navigation Error` (#43291) Previously, the error message was not added to `Unhandled Navigation Error` Before ``` main.js:1 Unhandled Navigation Errors: ``` After ``` main.js:1 Unhandled Navigation Errors: SecurityError: Failed to execute 'replaceState' on 'History': A history state object with URL 'http://localhost:4200/' cannot be created in a document with origin 'http://127.0.0.1:8080' and URL 'http://127.0.0.1:8080/'. ``` PR Close #43291 | 01 September 2021, 21:15:00 UTC |
caecd18 | Jessica Janiuk | 01 September 2021, 18:30:13 UTC | release: cut the v12.2.4 release (#43308) | 01 September 2021, 18:30:13 UTC |
d8f637a | George Kalpakas | 23 August 2021, 14:19:16 UTC | docs: add step to declare `ProductAlertsComponent` in tutorial (#43229) The getting-started tutorial at angular.io/start instructs users to generate a `ProductAlertsComponent` using the "Angular generator" feature in [StackBlitz](https://stackblitz.com/). However, unlike the Angular CLI, generating a component in StackBlitz does not automatically declare it in `AppModule`, which is a requirement for the component to be used in the application. This resulted in a compile error when following the tutorial instructions. This commit fixes this by adding a step to manually import and declare the newly generated component in `app.module.ts`. Fixes #43020 Closes #43212 PR Close #43229 | 30 August 2021, 20:37:46 UTC |
46bd8f2 | Joey Perrott | 23 August 2021, 17:39:33 UTC | ci: update pullapprove config to reflect kyliau's departure (#43230) Update pullapprove configuration to remove kyliau from groups. PR Close #43230 | 30 August 2021, 15:23:41 UTC |
d84a4eb | Joey Perrott | 23 August 2021, 17:22:57 UTC | docs: remove recent departures from contributors page (#43230) PR Close #43230 | 30 August 2021, 15:23:40 UTC |
692e8ab | Daniel Trevino | 13 August 2021, 19:47:41 UTC | test(compiler-cli): add tests for `NullishCoalescingNotNullableCheck` (#43232) Add tests to make sure the nullish coalescing check is generating the correct diagnostics. Refs #42966 PR Close #43232 | 26 August 2021, 23:36:33 UTC |
5d64d17 | Daniel Trevino | 13 August 2021, 19:46:00 UTC | refactor(compiler-cli): add `NullishCoalescingNotNullableCheck` (#43232) Add a template check that returns diagnostics if the left side of a nullish coalescing operation is not nullable. Refs #42966 PR Close #43232 | 26 August 2021, 23:36:33 UTC |
9c63999 | Daniel Trevino | 13 August 2021, 19:41:33 UTC | refactor(compiler-cli): use `TemplateCheckWithVisitor` in `InvalidBananaInBoxCheck` (#43232) Modify the existing template check to use the new abstract class. This makes template checks easier to read and understand. Refs #42966 PR Close #43232 | 26 August 2021, 23:36:32 UTC |
75fc846 | Daniel Trevino | 13 August 2021, 19:39:02 UTC | refactor(compiler-cli): add abstract `TemplateCheckWithVisitor` class (#43232) Add an abstract class that has a default implementation of the run function and visits all nodes. Authors of template checks can extend this class and override the `visitNode` method to return diagnostics. Refs #42966 PR Close #43232 | 26 August 2021, 23:36:32 UTC |
debe517 | Daniel Trevino | 19 August 2021, 21:52:10 UTC | refactor(compiler-cli): move `component` out of `TemplateContext` (#43232) Move `component` out of the `TemplateContext` so the context can be reused for multiple components. Refs #42966 PR Close #43232 | 26 August 2021, 23:36:32 UTC |
e29f1d9 | Daniel Trevino | 19 August 2021, 16:08:12 UTC | refactor(compiler-cli): change checks folder structure (#43232) Change template checks into `extended/checks` instead of `extended/src/template_checks`. Refs #42966 PR Close #43232 | 26 August 2021, 23:36:32 UTC |
553eb2c | Daniel Trevino | 19 August 2021, 15:55:34 UTC | refactor(compiler-cli): remove whitespace (#43232) Remove extra whitespace introduced in a previous PR. PR Close #43232 | 26 August 2021, 23:36:32 UTC |
30d959a | Joey Perrott | 26 August 2021, 16:42:33 UTC | build: update issue template to include core package (#43272) Update the dropdown list to include core in the list of packages. PR Close #43272 | 26 August 2021, 19:43:14 UTC |
fdcb420 | Andrew Scott | 26 August 2021, 15:15:21 UTC | docs(router): Fix incorrect name for url match options (#43268) fixes #43123 PR Close #43268 | 26 August 2021, 17:07:24 UTC |
524b4d5 | Kristiyan Kostadinov | 24 August 2021, 17:46:03 UTC | refactor(forms): make error messages easier to tree shake (#43223) Currently the error message functions are defined as static methods on a class which means that as soon as one of them is used somewhere, all of them have to be retained. This isn't a problem at the moment, because all of them are behind `ngDevMode` checks, but it's error prone and it's easy to fix. These changes move them out into functions so that they can be imported individually. It also has the advantage of allowing Webpack to minify the function names. PR Close #43223 | 26 August 2021, 17:05:36 UTC |
fb64f71 | segunb | 25 August 2021, 20:20:00 UTC | docs: Close #View tag to avoid confusion (#43256) PR Close #43256 | 26 August 2021, 16:44:08 UTC |
e7e78e6 | nickreid | 02 August 2021, 18:03:36 UTC | refactor(zone.js): Rename class ZoneDelegate to _ZoneDelegate to differentiate it from the ZoneDelgate interface (#43019) The current naming causes tsickle to emit `/** @implements {ZoneDelegate} */ class ZoneDelegate ...`, which is a cyclic definition error in Closure Compiler. Additionally, the name shadowing is also confusing to humans. PR Close angular#43019 PR Close #43019 | 25 August 2021, 22:12:01 UTC |
8233906 | nickreid | 02 August 2021, 21:11:58 UTC | fix(compiler-cli): Emit type annotations for synthesized decorator fields (#43021) Previously, the decorator transformer was annotating the synthesized properties with TS type annotations. However, because it ran after the JSDoc transformer, the TS types were just dropped from the emitted JS. Attempting to move the decorator transformer before the JSDoc transformer causes tsickle crashes because synthetic AST fragments are not attached to a SourceFile node. PR Close #43021 | 25 August 2021, 22:05:29 UTC |
b818361 | Alex Rickabaugh | 25 August 2021, 21:02:48 UTC | release: cut the v12.2.3 release (#43257) PR Close #43257 | 25 August 2021, 21:20:31 UTC |
b46ce7d | George Kalpakas | 24 August 2021, 08:49:18 UTC | build(docs-infra): upgrade cli command docs sources to 56c5962df (#43239) Updating [angular#12.2.x](https://github.com/angular/angular/tree/12.2.x) from [cli-builds#12.2.x](https://github.com/angular/cli-builds/tree/12.2.x). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/7c2d76d9e...56c5962df): **Modified** - help/lint.json PR Close #43239 | 25 August 2021, 17:48:04 UTC |
36bf0ae | Daniel Trevino | 11 August 2021, 23:55:56 UTC | test(language-service): add test for extended diagnostics (#43134) Add a test to make sure extended template diagnostics are being correctly generated in the language service for non-ts files. Refs #42966 PR Close #43134 | 25 August 2021, 17:43:02 UTC |
3b317dc | Daniel Trevino | 11 August 2021, 23:37:19 UTC | refactor(compiler-cli): integrate extended diagnostics with the language service (#43134) Add the call to get the extended template diagnostics in the compiler's `getDiagnosticsForComponent`. This makes showing extended diagnostics in non-ts files posible. Refs #42966 PR Close #43134 | 25 August 2021, 17:43:02 UTC |
3ad527d | Daniel Trevino | 23 August 2021, 21:24:54 UTC | refactor(compiler-cli): rename `ExtendedTemplateChecker` get diagnostics fucntion (#43134) Rename `getExtendedTemplateDiagnosticsForComponent` to `getDiagnosticsForComponent` since it's implied they are extended diagnostics. Refs #42966 PR Close #43134 | 25 August 2021, 17:43:02 UTC |
b6ff762 | Daniel Trevino | 23 August 2021, 21:21:37 UTC | refactor(compiler-cli): move `getDiagnosticsForComponent` to compiler (#43134) Change the language service to call `getDiagnosticsForComponent` from the compiler instead of the `TemplateTypeChecker`. Refs #42966 PR Close #43134 | 25 August 2021, 17:43:02 UTC |
e196311 | Daniel Trevino | 23 August 2021, 21:17:45 UTC | refactor(compiler-cli): move `ExtendedTemplateChecker` to `LazyCompilationState` (#43134) Create the `ExtendedTemplateChecker` during `makeCompilation`, that way it's avaiblable in the whole compiler. Refs #42966 PR Close #43134 | 25 August 2021, 17:43:01 UTC |
3cf8f66 | Daniel Trevino | 11 August 2021, 23:33:58 UTC | refactor(compiler-cli): use `TemplateDiagnostic` in `extended` package (#43134) Return `TemplateDiagnostic` instead of `ts.Diagnostic` when getting the extended template diagnostics. This makes the integration with the language service easier. This also fixes the error code and now uses the `ngErrorCode` for extended template diagnostics. Refs #42966 PR Close #43134 | 25 August 2021, 17:43:01 UTC |
d7b6416 | dario-piotrowicz | 21 August 2021, 10:25:20 UTC | refactor(common): fix emiting typos (#43221) fix some of the aio examples which log strings containing "emiting" instead of "emitting" PR Close #43221 | 23 August 2021, 20:30:29 UTC |
fc7f921 | shlasouski | 20 August 2021, 12:23:47 UTC | fix(service-worker): NPE if onActionClick is undefined (#43210) Previously, it leads to fail if notification.data.onActionClick is undefined PR Close #43210 | 23 August 2021, 20:29:59 UTC |
cb8e51f | Daniel Trevino | 12 August 2021, 17:58:10 UTC | test(language-service): add extended diagnostics test (#43107) Add a test in the langauge-service to make sure the extended template diagnostics are being correctly generated. Refs #42966 PR Close #43107 | 19 August 2021, 18:55:28 UTC |
e6b2bed | Daniel Trevino | 06 August 2021, 20:55:01 UTC | test(compiler-cli): add extended template diagnostics end-to-end tests (#43107) This commit adds extended template diagnostics end-to-end tests, to make sure the diagnostics are generated correctly. Template checks are already tested with unit tests. Refs #42966 PR Close #43107 | 19 August 2021, 18:55:28 UTC |
58a19a3 | Daniel Trevino | 02 August 2021, 19:06:42 UTC | refactor(compiler-cli): add `extendedTemplateCheck` phase to compiler (#43107) This commit integrates extended template checks with the compiler, by adding another phase of diagnostics generation. This integration is under the `_extendedTemplateDiagnostics` flag. Refs #42966 PR Close #43107 | 19 August 2021, 18:55:28 UTC |
f70d2a2 | Daniel Trevino | 28 July 2021, 19:22:33 UTC | refactor(compiler-cli): export `ExtendedTemplateCheckerImpl` and template checks (#43107) This commit exports the implementation of `ExtendedTemplateChecker` to generate extended template diagnostics and all the template checks. Refs #42966 PR Close #43107 | 19 August 2021, 18:55:28 UTC |
3bbf00f | Daniel Trevino | 17 August 2021, 16:50:10 UTC | refactor(compiler-cli): add `ExtendedTemplateChecker` (#43107) Change the current way to run template checks to the `ExtendedTemplateChecker` instead of just the `getExtendedTemplateDiagnosticsForComponent` function. Refactored the tests that used the previous function to use the new class. Refs #42966 PR Close #43107 | 19 August 2021, 18:55:28 UTC |
19fa033 | dario-piotrowicz | 01 August 2021, 15:48:30 UTC | refactor(docs-infra): use tslint in aio's tools-lint script (#43010) Instead of the deprecated tslint use eslint in the aio's tools-lint script PR Close #43010 | 19 August 2021, 18:20:06 UTC |
513b170 | Erik Slack | 18 August 2021, 01:35:05 UTC | docs: fix typo (#43190) Fix typo in description of ngxp and link for angular community meetup PR Close #43190 | 18 August 2021, 17:52:19 UTC |
c501e86 | Dylan Hunn | 18 August 2021, 17:15:31 UTC | release: cut the v12.2.2 release (#43195) | 18 August 2021, 17:15:31 UTC |
e849e57 | Kirk Larkin | 17 August 2021, 19:29:47 UTC | docs: tidy up description of NgComponentOutlet (#43159) PR Close #43159 | 18 August 2021, 16:17:44 UTC |
e31ed3d | Joe Martin (Crowdstaffing) | 06 August 2021, 17:49:04 UTC | docs: update links and formatting (#43066) Update links and formatting prior to creating sub-topics. Update links to reference links for consistency. Update formatting for code sections. Updated list alignment for consistent formatting. PR Close #43066 | 18 August 2021, 03:00:58 UTC |
545972e | Pete Bacon Darwin | 15 July 2021, 07:27:36 UTC | docs(upgrade): add `@extensible` to the `UpgradeComponent` class (#42807) This class is designed to be used as a base class. Therefore it should not be marked as `final` in the API docs. PR Close #42807 | 17 August 2021, 16:23:09 UTC |
38d51e4 | Pete Bacon Darwin | 09 July 2021, 14:29:29 UTC | build(docs-infra): add `sealed` markers to classes in API pages (#42807) This change will mark classes as `sealed` unless they have been annotated with an `@extensible` jsdoc tag. Fixes #42802 PR Close #42807 | 17 August 2021, 16:23:09 UTC |