Skip to main content

Browse the archive

Revision 9c1c2b35f1d94de8325344c2777d7ee67492db3b authored by Jeff Layton on 03 April 2019, 17:16:01 UTC, committed by Ilya Dryomov on 21 January 2020, 18:02:37 UTC 
ceph: hold extra reference to r_parent over life of request
 
Currently, we just assume that it will stick around by virtue of the
submitter's reference, but later patches will allow the syscall to
return early and we can't rely on that reference at that point.

While I'm not aware of any reports of it, Xiubo pointed out that this
may fix a use-after-free.  If the wait for a reply times out or is
canceled via signal, and then the reply comes in after the syscall
returns, the client can end up trying to access r_parent without a
reference.

Take an extra reference to the inode when setting r_parent and release
it when releasing the request.

Cc: stable@vger.kernel.org
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: "Yan, Zheng" <zyan@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
1 parent def9d27
Raw File
omap-crypto.h 
/* SPDX-License-Identifier: GPL-2.0-only */
/*
 * OMAP Crypto driver common support routines.
 *
 * Copyright (c) 2017 Texas Instruments Incorporated
 *   Tero Kristo <t-kristo@ti.com>
 */

#ifndef __CRYPTO_OMAP_CRYPTO_H
#define __CRYPTO_OMAP_CRYPTO_H

enum {
	OMAP_CRYPTO_NOT_ALIGNED = 1,
	OMAP_CRYPTO_BAD_DATA_LENGTH,
};

#define OMAP_CRYPTO_DATA_COPIED		BIT(0)
#define OMAP_CRYPTO_SG_COPIED		BIT(1)

#define OMAP_CRYPTO_COPY_MASK		0x3

#define OMAP_CRYPTO_COPY_DATA		BIT(0)
#define OMAP_CRYPTO_FORCE_COPY		BIT(1)
#define OMAP_CRYPTO_ZERO_BUF		BIT(2)
#define OMAP_CRYPTO_FORCE_SINGLE_ENTRY	BIT(3)

int omap_crypto_align_sg(struct scatterlist **sg, int total, int bs,
			 struct scatterlist *new_sg, u16 flags,
			 u8 flags_shift, unsigned long *dd_flags);
void omap_crypto_cleanup(struct scatterlist *sg, struct scatterlist *orig,
			 int offset, int len, u8 flags_shift,
			 unsigned long flags);

#endif
back to top