Revision 9c1c2b35f1d94de8325344c2777d7ee67492db3b authored by Jeff Layton on 03 April 2019, 17:16:01 UTC, committed by Ilya Dryomov on 21 January 2020, 18:02:37 UTC
Currently, we just assume that it will stick around by virtue of the
submitter's reference, but later patches will allow the syscall to
return early and we can't rely on that reference at that point.

While I'm not aware of any reports of it, Xiubo pointed out that this
may fix a use-after-free.  If the wait for a reply times out or is
canceled via signal, and then the reply comes in after the syscall
returns, the client can end up trying to access r_parent without a
reference.

Take an extra reference to the inode when setting r_parent and release
it when releasing the request.

Cc: stable@vger.kernel.org
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: "Yan, Zheng" <zyan@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
1 parent def9d27
History
File Mode Size
gameport
joystick
keyboard
misc
mouse
rmi4
serio
tablet
touchscreen
Kconfig -rw-r--r-- 6.0 KB
Makefile -rw-r--r-- 959 bytes
apm-power.c -rw-r--r-- 2.4 KB
evbug.c -rw-r--r-- 2.2 KB
evdev.c -rw-r--r-- 32.7 KB
ff-core.c -rw-r--r-- 8.7 KB
ff-memless.c -rw-r--r-- 14.0 KB
input-compat.c -rw-r--r-- 3.1 KB
input-compat.h -rw-r--r-- 1.6 KB
input-leds.c -rw-r--r-- 5.0 KB
input-mt.c -rw-r--r-- 12.4 KB
input-polldev.c -rw-r--r-- 9.1 KB
input-poller.c -rw-r--r-- 5.3 KB
input-poller.h -rw-r--r-- 478 bytes
input.c -rw-r--r-- 62.7 KB
joydev.c -rw-r--r-- 25.9 KB
matrix-keymap.c -rw-r--r-- 5.3 KB
mousedev.c -rw-r--r-- 25.6 KB
sparse-keymap.c -rw-r--r-- 7.4 KB

back to top