Skip to main content

Browse the archive

Revision 9c29bcd189f4ab1644b7125713602532d0aefdb7 authored by Eric Dumazet on 21 September 2018, 22:27:48 UTC, committed by David S. Miller on 24 September 2018, 04:55:25 UTC 
mlx5: remove ndo_poll_controller
 
As diagnosed by Song Liu, ndo_poll_controller() can
be very dangerous on loaded hosts, since the cpu
calling ndo_poll_controller() might steal all NAPI
contexts (for all RX/TX queues of the NIC). This capture
can last for unlimited amount of time, since one
cpu is generally not able to drain all the queues under load.

mlx5 uses NAPI for TX completions, so we better let core
networking stack call the napi->poll() to avoid the capture.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Saeed Mahameed <saeedm@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent a24b66c
Raw File
perf-hooks.h 
/* SPDX-License-Identifier: GPL-2.0 */
#ifndef PERF_UTIL_PERF_HOOKS_H
#define PERF_UTIL_PERF_HOOKS_H

#ifdef __cplusplus
extern "C" {
#endif

typedef void (*perf_hook_func_t)(void *ctx);
struct perf_hook_desc {
	const char * const hook_name;
	perf_hook_func_t * const p_hook_func;
	void *hook_ctx;
};

extern void perf_hooks__invoke(const struct perf_hook_desc *);
extern void perf_hooks__recover(void);

#define PERF_HOOK(name)					\
extern struct perf_hook_desc __perf_hook_desc_##name;	\
static inline void perf_hooks__invoke_##name(void)	\
{ 							\
	perf_hooks__invoke(&__perf_hook_desc_##name);	\
}

#include "perf-hooks-list.h"
#undef PERF_HOOK

extern int
perf_hooks__set_hook(const char *hook_name,
		     perf_hook_func_t hook_func,
		     void *hook_ctx);

extern perf_hook_func_t
perf_hooks__get_hook(const char *hook_name);

#ifdef __cplusplus
}
#endif
#endif
back to top