Revision 9c55ad1c214d9f8c4594ac2c3fa392c1c32431a7 authored by Ilya Dryomov on 24 April 2018, 17:10:55 UTC, committed by Ilya Dryomov on 26 April 2018, 15:39:08 UTC
ceph_con_workfn() validates con->state before calling try_read() and then try_write(). However, try_read() temporarily releases con->mutex, notably in process_message() and ceph_con_in_msg_alloc(), opening the window for ceph_con_close() to sneak in, close the connection and release con->sock. When try_write() is called on the assumption that con->state is still valid (i.e. not STANDBY or CLOSED), a NULL sock gets passed to the networking stack: BUG: unable to handle kernel NULL pointer dereference at 0000000000000020 IP: selinux_socket_sendmsg+0x5/0x20 Make sure con->state is valid at the top of try_write() and add an explicit BUG_ON for this, similar to try_read(). Cc: stable@vger.kernel.org Link: https://tracker.ceph.com/issues/23706 Signed-off-by: Ilya Dryomov <idryomov@gmail.com> Reviewed-by: Jason Dillaman <dillaman@redhat.com>
1 parent 7b4c443
File | Mode | Size |
---|---|---|
api | ||
bpf | ||
lockdep | ||
subcmd | ||
symbol | ||
traceevent | ||
bitmap.c | -rw-r--r-- | 1.7 KB |
find_bit.c | -rw-r--r-- | 3.2 KB |
hweight.c | -rw-r--r-- | 1.8 KB |
rbtree.c | -rw-r--r-- | 14.7 KB |
str_error_r.c | -rw-r--r-- | 1.0 KB |
string.c | -rw-r--r-- | 2.1 KB |
vsprintf.c | -rw-r--r-- | 575 bytes |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...