Revision 9c55ad1c214d9f8c4594ac2c3fa392c1c32431a7 authored by Ilya Dryomov on 24 April 2018, 17:10:55 UTC, committed by Ilya Dryomov on 26 April 2018, 15:39:08 UTC
ceph_con_workfn() validates con->state before calling try_read() and then try_write(). However, try_read() temporarily releases con->mutex, notably in process_message() and ceph_con_in_msg_alloc(), opening the window for ceph_con_close() to sneak in, close the connection and release con->sock. When try_write() is called on the assumption that con->state is still valid (i.e. not STANDBY or CLOSED), a NULL sock gets passed to the networking stack: BUG: unable to handle kernel NULL pointer dereference at 0000000000000020 IP: selinux_socket_sendmsg+0x5/0x20 Make sure con->state is valid at the top of try_write() and add an explicit BUG_ON for this, similar to try_read(). Cc: stable@vger.kernel.org Link: https://tracker.ceph.com/issues/23706 Signed-off-by: Ilya Dryomov <idryomov@gmail.com> Reviewed-by: Jason Dillaman <dillaman@redhat.com>
1 parent 7b4c443
File | Mode | Size |
---|---|---|
Documentation | ||
arch | ||
.gitignore | -rw-r--r-- | 42 bytes |
Build | -rw-r--r-- | 505 bytes |
Makefile | -rw-r--r-- | 1.7 KB |
arch.h | -rw-r--r-- | 1.9 KB |
builtin-check.c | -rw-r--r-- | 1.9 KB |
builtin-orc.c | -rw-r--r-- | 1.7 KB |
builtin.h | -rw-r--r-- | 1012 bytes |
cfi.h | -rw-r--r-- | 1.4 KB |
check.c | -rw-r--r-- | 51.2 KB |
check.h | -rw-r--r-- | 2.2 KB |
elf.c | -rw-r--r-- | 12.5 KB |
elf.h | -rw-r--r-- | 2.8 KB |
objtool.c | -rw-r--r-- | 3.0 KB |
orc.h | -rw-r--r-- | 948 bytes |
orc_dump.c | -rw-r--r-- | 4.3 KB |
orc_gen.c | -rw-r--r-- | 4.8 KB |
special.c | -rw-r--r-- | 4.6 KB |
special.h | -rw-r--r-- | 1.1 KB |
sync-check.sh | -rwxr-xr-x | 584 bytes |
warn.h | -rw-r--r-- | 1.7 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...