Revision - 9c5a18a - cfg80211: wext: clear sinfo struct before calling driver - origin: https://github.com/torvalds/linux

visit type:

https://github.com/torvalds/linux

17 May 2024, 11:00:25 UTC

Revision 9c5a18a31b321f120efda412281bb9f610f84aa0 authored by Johannes Berg on 09 June 2015, 19:35:44 UTC, committed by David S. Miller on 09 June 2015, 20:54:58 UTC

cfg80211: wext: clear sinfo struct before calling driver

Until recently, mac80211 overwrote all the statistics it could
provide when getting called, but it now relies on the struct
having been zeroed by the caller. This was always the case in
nl80211, but wext used a static struct which could even cause
values from one device leak to another.

Using a static struct is OK (as even documented in a comment)
since the whole usage of this function and its return value is
always locked under RTNL. Not clearing the struct for calling
the driver has always been wrong though, since drivers were
free to only fill values they could report, so calling this
for one device and then for another would always have leaked
values from one to the other.

Fix this by initializing the structure in question before the
driver method call.

This fixes https://bugzilla.kernel.org/show_bug.cgi?id=99691

Cc: stable@vger.kernel.org
Reported-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Reported-by: Alexander Kaltsas <alexkaltsas@gmail.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 parent 5879ae5

Files
Changes

Permalinks

Tip revision: 9c5a18a31b321f120efda412281bb9f610f84aa0 authored by Johannes Berg on 09 June 2015, 19:35:44 UTC
cfg80211: wext: clear sinfo struct before calling driver

Tip revision: 9c5a18a

File	Mode	Size
Documentation
arch
block
crypto
drivers
firmware
fs
include
init
ipc
kernel
lib
mm
net
samples
scripts
security
sound
tools
usr
virt
.gitignore	-rw-r--r--	1.2 KB
.mailmap	-rw-r--r--	4.9 KB
COPYING	-rw-r--r--	18.3 KB
CREDITS	-rw-r--r--	94.7 KB
Kbuild	-rw-r--r--	2.1 KB
Kconfig	-rw-r--r--	252 bytes
MAINTAINERS	-rw-r--r--	303.1 KB
Makefile	-rw-r--r--	53.1 KB
README	-rw-r--r--	18.2 KB
REPORTING-BUGS	-rw-r--r--	7.3 KB

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/torvalds/linux

cfg80211: wext: clear sinfo struct before calling driver

README