Skip to main content

Browse the archive

https://github.com/angular/angular
07 August 2024, 03:31:07 UTC
sort by:
Revision Author Date Message Commit Date
0daa9bf Andrew Kushnir 15 December 2021, 23:10:33 UTC refactor(forms): make validators code compatible with property renaming (#44500) This commit refactors the code of the base validators class to make it compatible with the property renaming optimization. Currently the code makes an assumption that the field with a specified name (defined as a string) can be found on an object, but with property renaming optimization this is not correct. PR Close #44500 05 January 2022, 18:43:37 UTC
426b6f9 Chris Mancini 05 January 2022, 16:42:24 UTC docs(router): fix code block for IsActiveMatchOptions (#44635) PR Close #44635 05 January 2022, 17:47:08 UTC
6c5d73e Dario Piotrowicz 21 December 2021, 21:24:18 UTC docs(animations): fix filter-animations docregion (#44544) the filter animation example in the complex-animation-sequences guide talks about entering and leaving elements, but the presented html snipped exluded the *ngFor which actually adds and removes the elements, so add the *ngFor section to make the example complete and understandable PR Close #44544 05 January 2022, 17:46:11 UTC
0ac4c0b JoostK 08 December 2021, 21:49:43 UTC refactor(compiler): remove output AST functions (#44411) These functions are not used anymore so they are removed. PR Close #44411 04 January 2022, 23:54:12 UTC
07b8e56 JoostK 08 December 2021, 21:47:36 UTC refactor(compiler): remove class related output AST types (#44411) The Ivy compiler no longer generates classes so this commit removes the supporting output nodes. PR Close #44411 04 January 2022, 23:54:11 UTC
5f78f55 JoostK 08 December 2021, 21:42:12 UTC refactor(compiler): remove type-casting related output AST types (#44411) The Ivy compiler no longer generates code for type-checking purposes using the output AST types. Instead, it uses TypeScript AST nodes and its printer for type-checking. This commit removes the type-related output nodes. PR Close #44411 04 January 2022, 23:54:11 UTC
4688a18 JoostK 08 December 2021, 21:33:57 UTC refactor(compiler): remove some unused output AST types (#44411) This kind of output is no longer emitted into generated code, so the supporting output AST is removed. PR Close #44411 04 January 2022, 23:54:11 UTC
d7faf22 JoostK 08 December 2021, 21:18:31 UTC refactor(compiler): remove unused method from binding parser (#44411) This method is no longer called so is being removed. PR Close #44411 04 January 2022, 23:54:11 UTC
6f70524 JoostK 08 December 2021, 21:17:42 UTC refactor(compiler): make template preparser null-safe (#44411) This commit removes some non-null assertion operations to improve null-safety. PR Close #44411 04 January 2022, 23:54:11 UTC
94f34e0 JoostK 08 December 2021, 21:14:32 UTC refactor(compiler): remove unused `unsupported` function (#44411) This function is no longer used so is being removed. PR Close #44411 04 January 2022, 23:54:11 UTC
db48082 JoostK 08 December 2021, 21:07:52 UTC refactor(compiler): make `keySpan` required in binding parser (#44411) Now that ViewEngine has been removed the `keySpan` property can be made required, as it is always provided in the Ivy compiler PR Close #44411 04 January 2022, 23:54:11 UTC
9ef9b88 JoostK 08 December 2021, 20:55:14 UTC refactor(compiler): cleanup distinction in parse logic (#44411) This removes the special casing of parse-validation logic that was only used by Ivy. PR Close #44411 04 January 2022, 23:54:11 UTC
bbc368c JoostK 08 December 2021, 20:47:58 UTC refactor(compiler): remove `BindingForm` enum (#44411) The Ivy compiler only uses `BindingForm.Expression`, so all other variants are removed. PR Close #44411 04 January 2022, 23:54:11 UTC
5fdc660 JoostK 08 December 2021, 20:44:56 UTC refactor(compiler): cleanup AST fixup of listener instructions (#44411) This commit refactors the generation of listener instructions to no longer fixup the output AST that was designed for ViewEngine. PR Close #44411 04 January 2022, 23:54:11 UTC
4f40266 JoostK 08 December 2021, 18:48:00 UTC refactor(compiler): remove unused assertion function (#44411) This code is no longer used now that ViewEngine has been removed. PR Close #44411 04 January 2022, 23:54:11 UTC
c359381 JoostK 08 December 2021, 18:45:59 UTC refactor(compiler): cleanup unsafe usage of `null` value for ng-content selector (#44411) This commit improves the null-safety of the ng-content selector and updates a comment that turned out to be slightly inaccurate. Closes #38407 PR Close #44411 04 January 2022, 23:54:11 UTC
63c5a18 JoostK 08 December 2021, 18:35:18 UTC refactor(compiler): remove unused code from output logic (#44411) This code is no longer used now that ViewEngine has been removed. PR Close #44411 04 January 2022, 23:54:11 UTC
9103b74 JoostK 08 December 2021, 18:26:36 UTC refactor(compiler): remove unused `AstPath` (#44411) This code is no longer used now that ViewEngine has been removed. PR Close #44411 04 January 2022, 23:54:11 UTC
75f7864 JoostK 01 December 2021, 23:35:54 UTC refactor(compiler): remove unused logic from `ConstantPool` (#44411) The `ConstantPool.getDefinition` method is not being used anymore, so this commit removes anything that is related to this method. PR Close #44411 04 January 2022, 23:54:11 UTC
59cd255 JoostK 08 December 2021, 18:24:36 UTC refactor(compiler): remove unused type declarations (#44411) This code is no longer used now that ViewEngine has been removed. PR Close #44411 04 January 2022, 23:54:10 UTC
9c76560 JoostK 08 December 2021, 18:17:57 UTC refactor(compiler): remove syntax error logic (#44411) This code is no longer used now that ViewEngine has been removed. PR Close #44411 04 January 2022, 23:54:10 UTC
db76891 dario-piotrowicz 15 December 2021, 13:39:15 UTC refactor(animations): add unit test for leaving animated child (#44489) add a new unit test to make sure that leaving elements queried via a parent queried via animateChild are correctly removed note: this tests the fix introduced in PR #44357 PR Close #44489 04 January 2022, 23:53:36 UTC
a6d12ef Andrew Kushnir 04 January 2022, 19:03:43 UTC test: remove newlines to make a test more stable (#44616) One of the tests was not taking into account newlines in the text content of an element, thus failing in some browsers. This commit makes the test more stable by removing newlines and comparing the output after that. PR Close #44616 04 January 2022, 23:53:00 UTC
25aef62 dario-piotrowicz 13 December 2021, 22:46:40 UTC fix(docs-infra): adjust code link styling height (#44376) the height of code links (anchors inside code tags or code tags inside anchors) is inconsistent, fix such issue by also making sure that code links to external resources do not get wrongly styled PR Close #44376 04 January 2022, 20:19:09 UTC
55209e5 dario-piotrowicz 04 December 2021, 13:48:11 UTC docs(animations): add links to `state()` references (#44376) the keyword 'state' is included in the `ignoredWords` set that prevents certain words to be autolinked, this causes the animations' state function not to be automatically linked, so manually link those references to the state api docs PR Close #44376 04 January 2022, 20:19:09 UTC
0be1a82 Abdurrahman Abu-Hijleh 16 December 2021, 21:56:42 UTC docs: fix code sample indentation (#44517) PR Close #44517 04 January 2022, 20:15:55 UTC
d389bb8 AlirezaEbrahimkhani 30 December 2021, 14:25:41 UTC docs: fix ngOnChange description issue (#44582) ngOnChange respond when Angular sets or resets data-bound @input properties and description of the ngOnChanges should be `When an [input](#input) binding value changes` instead of `When an [input](#input)/[output](#output) binding value changes` resolves angular#44559 PR Close #44582 04 January 2022, 20:15:19 UTC
77562f9 huangqing 15 December 2021, 07:16:45 UTC docs: Replace OnInit with AfterViewInit (#44485) `this.adHost` is undefined if loadComponent is called in OnInit. So replace OnInit with AfterViewInit! PR Close #44485 04 January 2022, 20:14:45 UTC
46c6f20 Paul Gschwendtner 15 December 2021, 18:31:20 UTC test: update size goldens to reflect latest CLI devkit update (#44490) Updates the size goldens to the reflect the latest CLI devkit updates. PR Close #44490 04 January 2022, 20:14:15 UTC
4765bf1 Paul Gschwendtner 15 December 2021, 15:34:07 UTC build: update release config to reflect latest ng-dev config changes (#44490) The ng-dev release config changed its release configuration in order to support experimental packages. This commit updates the FW release config to work with the new config signature of ng-dev. All of our peackages are non-experimental, so we do not specify an explicit `experimental` property. PR Close #44490 04 January 2022, 20:14:15 UTC
ef0d161 Paul Gschwendtner 15 December 2021, 15:22:01 UTC build: switch all instances from `ng_rollup_bundle` to `app_bundle` (#44490) The `ng_rollup_bundle` rule has been replaced with a new rule called `app_bundle`. This rule replicates the Angular v13 optimization pipeline in the CLI, so that we can get better benchmarking results. Also the rule is much simpler to maintain as it relies on ESbuild. The old `ng_rollup_bundle` rule did rely on e.g. build-optimizer that no longer has an effect on v13 Angular packages, so technically size tests/symbol tests were no longer as correct as they were before. This commit fixes that. A couple of different changes and their explanation: * Language-service will no longer use the benchmark rule for creating its NPM bundles! It will use plain `rollup_bundle`. ESBuild would have been nice but the language-service relies on AMD that ESBuild cannot generate (yet?) * Service-worker ngsw-worker.js file was generated using the benchmark bundle rule. This is wrong. We will use a simple ESbuild rule in the future. The output is more predictable that way, and we can have a clear use of the benchmark bundle rule.. * A couple of benchmarks in `modules/` had to be updated to use e.g. `initTableUtils` calls. This is done because with the new rule, all files except for the entry-point are considered side-effect free. The utilities for benchmarks relied on side-effects in some transitively-loaded file (bad practice anyway IMO). We are now initializing the utilities using a proper init function that is exported... PR Close #44490 04 January 2022, 20:14:15 UTC
b04e9a6 Paul Gschwendtner 15 December 2021, 15:18:06 UTC build: update postinstall script to account for local target references in dev-infra (#44490) We are in an inconvenient situation where the ng-dev package might rely on packages from the Angular framework repository. Given that we install this package in the framework repository, we need to update some references through a postinstall. This commit updates the patches to account for the latest changes in the dev-infra package/repository. PR Close #44490 04 January 2022, 20:14:15 UTC
97f27d7 Paul Gschwendtner 15 December 2021, 15:16:29 UTC build: add postinstall script as runfile for `yarn_install` repository rule (#44490) Adds the postinstall script as runfile for the `yarn_install` repository rule, so that the dependencies are re-fetched when the script changes. PR Close #44490 04 January 2022, 20:14:15 UTC
16bc023 Paul Gschwendtner 15 December 2021, 15:14:31 UTC build: update symbol extractor to support IIFE bundles using arrow-functions (#44490) Updates the symbol extractor to support IIFE bundles using arrow-functions instead of function declarations. This is in preparation for running symbol extraction tests with the overhauled optimization pipeline for Angular v13, relying on ESBuild internally. Also removes rollup-specific code that does not seem to be relevant anymore / rollup will be replaced anyway. PR Close #44490 04 January 2022, 20:14:15 UTC
158c9d6 Paul Gschwendtner 13 December 2021, 17:48:47 UTC build: update angular (#44490) Updates Angular and the dev-infra package to the latest version/build. PR Close #44490 04 January 2022, 20:14:15 UTC
acb95f5 Borja Paz Rodríguez 16 December 2021, 15:58:17 UTC docs: fix several typos (#44508) PR Close #44508 04 January 2022, 20:13:47 UTC
a1ca376 Dario Piotrowicz 19 December 2021, 11:45:22 UTC refactor(docs-infra): improve aio-footer's layout (#44532) improve aio-footer's layout by using grid instead of flexbox, such change makes it so that we have four columns on wide window sizes (desktop), two columns on medium window sizes (desktop/tablet) and a single column on small window sizes (mobile), compared to the flex implementation which could only have either 4 columns or 1 this makes the footer look generally nicer for various window sizes (especially in the middle range in which one column was too little and four were too much) note: also a scroll of auto has been added so we that we can be sure that overflowing footer content never creates a global layout issue PR Close #44532 04 January 2022, 20:13:22 UTC
6ca075d Yousaf Nawaz 29 December 2021, 13:38:41 UTC docs: add missing npm install instruction (#44574) add missing npm install instruction to start->deploying an application Fixes #44542 PR Close #44574 04 January 2022, 20:07:38 UTC
f5addee ivanwonder 18 December 2021, 01:25:01 UTC fix(language-service): revert the test files for Ivy (#44528) The `completions_spec` and `definitions_spec` is removed by accident in [bb9ff60](https://github.com/angular/angular/commit/bb9ff6003c620b3cf00232189d60097395382802) PR Close #44528 04 January 2022, 20:06:49 UTC
5ca7068 Yousaf Nawaz 29 December 2021, 14:06:42 UTC docs(docs-infra): fix numbering of 'running your application locally' steps (#44575) fix numbering of 'running your application locally' steps and corrected step 1 statement. PR Close #44575 04 January 2022, 20:06:07 UTC
845038c Serhey Dolgushev 30 December 2021, 15:32:48 UTC docs: fixed meetup URL (#44585) PR Close #44585 04 January 2022, 20:05:45 UTC
f9e18b7 Adam Plumer 01 January 2022, 06:22:12 UTC build: bump license year (#44590) The year has advanced by one cycle. In accordance with this practice, we increment the value of the bounding set of our license year by one. PR Close #44590 04 January 2022, 20:05:25 UTC
00cc0d9 George Kalpakas 03 January 2022, 16:30:28 UTC docs: update instructions for running `ng-dev misc build-and-link` command (#44604) Fixes #44571 PR Close #44604 04 January 2022, 20:05:05 UTC
d619783 zuckjet 03 January 2022, 03:23:48 UTC docs(compiler): fix typo in `getHtmlTagDefinition()` function (#44601) PR Close #44601 04 January 2022, 20:04:04 UTC
70a2051 JoostK 04 January 2022, 11:45:41 UTC docs: remove Angular 10 from support table (#44611) PR Close #44611 04 January 2022, 20:03:37 UTC
40dc072 Yousaf Nawaz 04 January 2022, 12:12:00 UTC docs: fix invalid link of library support for npm packages guide (#44612) change link of library support to point to guide->creating-libraries fixes #44583 PR Close #44612 04 January 2022, 20:03:15 UTC
2469b88 Chihab Otmani 01 January 2022, 12:02:45 UTC docs: fix typo (#44592) PR Close #44592 04 January 2022, 18:59:59 UTC
e6beeab Andrew Scott 20 December 2021, 16:32:48 UTC ci: remove atscott for unavailable users (#44539) I am back from vacation so I can now be assigend PRs to review PR Close #44539 04 January 2022, 18:38:42 UTC
beb1828 Joey Perrott 16 December 2021, 18:12:33 UTC docs: remove recent departures from contributors page (#44514) PR Close #44514 16 December 2021, 19:29:30 UTC
0115e2b Alex Rickabaugh 15 December 2021, 19:31:25 UTC release: cut the v13.1.1 release (#44495) PR Close #44495 15 December 2021, 19:32:40 UTC
c2ed1ae Kristiyan Kostadinov 15 December 2021, 11:39:51 UTC fix(docs-infra): update examples to Angular 13.1 (#44487) Updates AIO and the live examples to 13.1.0 in order to resolve a build error when opened on Stackblitz. They were using TS 4.5 with Angular ~13.0.0 which doesn't support 4.5. Fixes #44480. PR Close #44487 15 December 2021, 18:22:14 UTC
bce108a Dylan Hunn 14 December 2021, 23:54:48 UTC fix(forms): `_reduceValue` arrow function now has correct types. (#44483) I previously strengthened some weak types in #44370. One of these fixes exposed an incorrect call into `_reduceChildren` from `_reduceValue`. This was caught in google3 by a caller who was extending `FormGroup` and overriding these methods. Special thanks to Bart G for catching this issue and suggesting a fix. PR Close #44483 15 December 2021, 17:27:06 UTC
240edcb Dylan Hunn 14 December 2021, 18:07:02 UTC test(docs-infra): Correct an invalid assumption in aio tests. (#44479) The aio application expects `FormControl` to have no properties for the purposes of its own internal tests, but this is no longer true after #44434. PR Close #44479 14 December 2021, 21:14:48 UTC
11187ef Kristiyan Kostadinov 14 December 2021, 13:35:40 UTC refactor(compiler): clean up workarounds for TypeScript 4.5 (#44477) Cleans up some of the temporary workarounds that were necessary in order to land support for TypeScript 4.5 since they're no longer necessary. PR Close #44477 14 December 2021, 21:14:02 UTC
9165191 George Kalpakas 14 December 2021, 08:49:22 UTC build(docs-infra): upgrade cli command docs sources to febee7484 (#44476) Updating [angular#13.1.x](https://github.com/angular/angular/tree/13.1.x) from [cli-builds#13.1.x](https://github.com/angular/cli-builds/tree/13.1.x). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/e7881e40b...febee7484): **Modified** - help/new.json PR Close #44476 14 December 2021, 21:13:30 UTC
17ac7c6 Spej 13 December 2021, 12:15:48 UTC docs: Fixed typo 'test' => 'text' (#44464) PR Close #44464 14 December 2021, 21:12:58 UTC
c195bd0 dario-piotrowicz 12 December 2021, 22:22:23 UTC refactor(animations): remove the unused enter and leave selectors (#44460) remove the no longer used ENTER_SELECTOR and LEAVE_SELECTOR constants note: their uses have been removed in PR #19455 PR Close #44460 14 December 2021, 21:12:36 UTC
4a1cdba dario-piotrowicz 12 December 2021, 18:31:50 UTC refactor(animations): improve _finalKeyframe non-null assertion (#44458) instead of declaring the WebAnimationsPlayer's _finalKeyframe field with a non-null assertion, declare it as optional field and use a non-null assertion only when it is being used in the beforeDestroy function relates to #24571 PR Close #44458 14 December 2021, 21:12:12 UTC
f6f7a37 Dylan Hunn 12 December 2021, 01:46:49 UTC test(forms): Add more tests for `FormBuilder` method argument shapes. (#44452) It is possible to pass arguments to `FormBuilder` using four different formats: value-only, boxed value, control config, and value-array. Currently, these different methods are not well-tested, especially as they interact. This PR will add tests for the variety of different argument shapes. This was originally inspired by typed forms: when `FormBuilder` becomes typed, all these argument shapes should just work, with correct inferred types. PR Close #44452 14 December 2021, 21:11:29 UTC
199f7a2 Dylan Hunn 12 December 2021, 01:36:31 UTC refactor(forms): Make the minimum changes to the forms unit tests in order to support the typed forms PR (#43834). (#44451) Currently, many of our unit tests are written to use heterogenous groups and arrays, and controls that accept heterogenous values. This PR will make the minimum possible alterations to prepare those usages, mainly by annotating them as untyped controls, etc. This PR is *not* intended to test typed forms, merely to minimize the size of the upcoming PR. This will allow that PR to be focused on the actual features and tests, rather than boilerplate fixes. PR Close #44451 14 December 2021, 21:10:08 UTC
998c1e6 Dylan Hunn 12 December 2021, 01:07:45 UTC fix(forms): I indroduced a minor error in a previous PR: pendingValue is a value not a boolean flag. (#44450) The bug should have no effect since it's a typings-only, internal-only bug, but it's good to fix nonetheless. PR Close #44450 14 December 2021, 21:09:43 UTC
1a25e38 JoostK 11 December 2021, 22:55:48 UTC test(ngcc): don't use the workspace typescript version to generate integration test fixtures (#44448) Now that ViewEngine libraries can no longer be created, the latest TypeScript version that ngcc should be able to process is TypeScript 4.3, i.e. the version of TypeScript that was supported in Angular 12. However, ngcc's integration tests used the TypeScript version of the workspace to create the JavaScript files from TypeScript sources on demand. This introduces friction when upgrading the TypeScript version within the workspace, as changes to TypeScript's emit format may affect ngcc's ability to process it correctly. The on demand creation of JavaScript files was convenient for authoring tests, but it also helped to detect incompatibilities with newer versions of TypeScript. Now that ngcc no longer has to process newer versions of TypeScript, we want to pin the integration suite to use JavaScript code as if it were compiled using TypeScript 4.3, i.e. a version of TypeScript that is actually supported by ngcc. This commit updates the integration test to inline all the generated files directly in the tests, instead of compiling them on demand. This was done by temporarily installing TypeScript 4.3 and using it to create the `loadTestFiles` statement from the original TypeScript inputs. An alternative could have been to install TypeScript 4.3 as an actual dependency in the workspace and using that to continue compiling the integration suite on demand, but this brings some overhead in package installations (TypeScript is ~60MB) and the authoring aspect of ngcc integration test is expected to diminish, now that ngcc's support is no longer a moving target. PR Close #44448 14 December 2021, 21:08:28 UTC
48e692d Yousaf Nawaz 11 December 2021, 15:59:30 UTC docs(docs-infra): change variable names in route guards examples (#44444) change variable name 'next' to 'route' in route guards examples on developer guides "Routing and Navigation Tutorial: Adding routing to Tour of Heroes" to make it consistent with api docs and subsequent examples. Fixes #44291 PR Close #44444 14 December 2021, 21:08:05 UTC
5ef0385 faso-dev 10 December 2021, 13:39:13 UTC docs: fix typo (#44427) `name` instead of `id` PR Close #44427 14 December 2021, 21:07:23 UTC
716f473 jaybell 09 December 2021, 20:37:56 UTC docs: add jaybell to gde list (#44423) PR Close #44423 14 December 2021, 21:06:32 UTC
524e515 Aristeidis Bampakos 08 December 2021, 20:40:04 UTC docs: update Aristeidis Bampakos bio (#44410) PR Close #44410 14 December 2021, 21:06:06 UTC
bb1d4ff dario-piotrowicz 02 December 2021, 23:01:16 UTC fix(animations): don't consume instructions for animateChild (#44357) TODO: Fill body commit if PR gets accepted resolves #41483 resolves #30693 PR Close #44357 14 December 2021, 21:05:35 UTC
d8b6adb zuckjet 25 June 2020, 04:23:58 UTC fix(animations): should not invoke disabled child animations (#37724) Currently child animation will be triggered by `animateChild()` despite it has been disabled. These changes add some logic to prevent that unexpected behavior. PR Close #37724 PR Close #37724 14 December 2021, 21:05:00 UTC
f4fcdff Renovate Bot 13 December 2021, 19:29:48 UTC build: update all non-major dependencies (#44152) PR Close #44152 14 December 2021, 21:04:34 UTC
a0316ab Dylan Hunn 03 December 2021, 18:33:53 UTC refactor(forms): Fix weak helper types in the Forms package, mostly `Function` types that can be strengthened to specific callbacks. This was originally proposed as part of Typed Forms, but it may be possible to submit at least some of these changes separately and unconditionally (i.e. without relying on `TypedOrUntyped`.) (#44370) It is desirable to land this separately to reduce the scope of the Typed Forms PR, by focusing it only on the new type parameters (rather than incidental strictness fixes). PR Close #44370 10 December 2021, 22:13:25 UTC
6c0ac51 Renovate Bot 07 December 2021, 08:47:59 UTC build: update dependency google-closure-compiler to v20211201 (#44392) PR Close #44392 10 December 2021, 21:39:42 UTC
a8e5a93 Renovate Bot 03 December 2021, 11:11:26 UTC build: update angular (#44273) PR Close #44273 10 December 2021, 21:39:05 UTC
266b62c George Kalpakas 09 December 2021, 08:49:41 UTC build(docs-infra): upgrade cli command docs sources to e7881e40b (#44413) Updating [angular#13.1.x](https://github.com/angular/angular/tree/13.1.x) from [cli-builds#13.0.x](https://github.com/angular/cli-builds/tree/13.0.x). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/481eb4544...e7881e40b): **Modified** - help/new.json PR Close #44413 10 December 2021, 21:36:41 UTC
a0e6825 dario-piotrowicz 07 December 2021, 22:48:33 UTC docs(animations): improve animation transition api docs (#44396) improve the transition api docs by removing unnecessary examplanations and examples also provide helpful information regarding entering and leaving elements (as part of #44253) PR Close #44396 10 December 2021, 21:34:01 UTC
d7a9b36 Paul Gschwendtner 10 December 2021, 17:22:07 UTC build: remove unused starlark file that is no longer used (#44430) Cleans up an unused Starlark file used by the old integration test setup. PR Close #44430 10 December 2021, 21:31:04 UTC
5bdf321 Paul Gschwendtner 09 December 2021, 21:45:07 UTC build: fix integration test size trackings not running after recent refactoring (#44430) Fixes that the integration test size trackings stopped working due to the recent refactorings (switch to the rule from `@angular/dev-infra-private`). The size-tracking does not integrate very-well into Bazel and needs a better solution in the future, allowing for RBE and Windows support, but currently with the new rule/setup/structure the tracking does not validate sizes because: * The `dist/*.js` argument to the tracking script got expanded and messed up the indices. It should be passed as a literal. This now surfaced because the new rule runs commands in a shell. * The name for the size goldens were not computed properly because they were based on `ctx.attr.name`, but given the new structure, the test targets are always named `test`. PR Close #44430 10 December 2021, 21:31:04 UTC
b11d3c3 Alex Rickabaugh 09 December 2021, 16:58:26 UTC release: cut the v13.1.0 release (#44418) PR Close #44418 09 December 2021, 17:02:43 UTC
0c35e67 Alex Rickabaugh 09 December 2021, 16:56:46 UTC Revert "release: cut the v13.1.0 release (#44417)" This reverts commit 0e2c357358febbdaa1ec99fe48419d0c8c49de0d. One more try, this time with a manual workaround. 09 December 2021, 16:56:46 UTC
0e2c357 Alex Rickabaugh 09 December 2021, 16:51:23 UTC release: cut the v13.1.0 release (#44417) PR Close #44417 09 December 2021, 16:52:25 UTC
22d8e56 Alex Rickabaugh 09 December 2021, 16:50:04 UTC Revert "release: cut the v13.1.0 release (#44416)" This reverts commit 6fb733fb4048cfbd820fd05e665412c352c6f95c. Still seeing transient errors - trying one more time before moving to a workaround. 09 December 2021, 16:50:04 UTC
6fb733f Alex Rickabaugh 09 December 2021, 16:36:13 UTC release: cut the v13.1.0 release (#44416) PR Close #44416 09 December 2021, 16:37:17 UTC
6992a68 Alex Rickabaugh 09 December 2021, 16:35:00 UTC Revert "release: cut the v13.1.0 release (#44415)" This reverts commit 7e395560132170a3beb293d16739d561cf318ae9. The release process failed with a transient error, so reverting this commit and trying again. 09 December 2021, 16:35:00 UTC
7e39556 Alex Rickabaugh 09 December 2021, 16:27:32 UTC release: cut the v13.1.0 release (#44415) PR Close #44415 09 December 2021, 16:31:04 UTC
08694e3 Alex Rickabaugh 08 December 2021, 19:20:21 UTC release: cut the v13.1.0-rc.0 release 08 December 2021, 19:24:20 UTC
2664bc2 Paul Gschwendtner 20 November 2021, 16:23:07 UTC test: switch integration tests from puppeteer/webdriver-manager to Bazel-managed chromium (#44238) Switches the integration tests form Puppeteer/webdriver-manager to the Bazel-managed Chromium/Chromedriver. This is now possible with the new integration test rule for which we can consult the `dev-infra/bazel/browsers` toolchain and setup environment variables. This has been configured already in a previous commit. This commit also includes some additional small cleanups necessary for the new integration test rule: * The `test.sh` scripts have been renamed as they would conflict with the `test.sh` scripts generated by the integration test rule. Previously this was not an issue because tests were declared at a higher-level. As mentioned though this has other downsides and it is trivial to rename the file. * Related to the point above, since tests are now declared witin the actual test folder (for perf e.g.), `package.json` files setting `"type": "module"` will accidentally cause the `nodejs_test`-generated files to be considered ESM. This is not correct and likely needs to be fixed upstream in `rules_nodejs` where explicit `.cjs` extensions should be used. This is only happening **once** in the `injectable-def` test so it is acceptable doing that for now. PR Close #44238 08 December 2021, 18:42:42 UTC
5837fbd Paul Gschwendtner 20 November 2021, 16:17:23 UTC refactor: setup bazel integration test with new integration rule (#44238) Sets up the Bazel integration test with the new integration rule. This commit is separate from the other changes because it required some additional work. i.e. The test has moved from `integration/bazel` to `integration/<..>/bazel` where `<..>` is a new Bazel package defining the integration test. This is necessary because we could not declare the integration test within the `BUILD.bazel` file actually being part of the nested bazel workspace. In those cases we can just define it at a higher-level and use integration test `working_dir` attribute. PR Close #44238 08 December 2021, 18:42:41 UTC
64fd824 Paul Gschwendtner 20 November 2021, 16:15:22 UTC build: setup test targets for integration tests with new rule (#44238) Sets up the test targets for integration tests with the new rule. The targets will match the configuration of the previous integration test setup (through the dictionary in a `bzl` file). Note: We already add `setup_chromium` based on whether Chromium tests run as part of this integration test. In a follow-up commit we can then remove puppeteer and rely on the Bazel-managed version of Chromium. PR Close #44238 08 December 2021, 18:42:41 UTC
98c5063 Paul Gschwendtner 20 November 2021, 16:09:10 UTC build: update visibility for npm package targets to work with new integration test structure (#44238) As mentioned in the previous commit, integration tests will be declared in subpackages of `//integration`. For these tests to still rely on the NPM packages from `HEAD`, we need to update the visibility. PR Close #44238 08 December 2021, 18:42:41 UTC
6c0905d Paul Gschwendtner 20 November 2021, 16:06:21 UTC build: wire up integration test rule from shared dev-infra package (#44238) Wires up the integration test rule from the shared dev-infra package, while also deleting the old integration test rule. The readme is updated to reflect the changes that are being made to run with the new integration rule. Overall one major difference is that we will declare the integration test targets within each test directory, making those actual bazel packages. This is more idiomatic within Bazel and also reduces the computation within Skyframe as less globs need to be evaluated for example. PR Close #44238 08 December 2021, 18:42:41 UTC
6add6a0 Paul Gschwendtner 06 November 2021, 13:10:04 UTC build: replace validate import ESM/CJS interop rule with dev-infra shipped rule (#44238) The import ESM/CJS interop lint rule has been ported to the shared dev-infra package, so we can remove the local version here. PR Close #44238 08 December 2021, 18:42:41 UTC
0cd524b Alex Rickabaugh 08 December 2021, 18:36:58 UTC Revert "refactor(forms): Move FormControl to an overridden exported constructor. (#44316)" This reverts commit cdf50ff9318ff5cdb4cbb1272d9113de8160065c. Reverting as this needs a little more work on the documentation side, plus the `export declare interface` syntax in `model.ts` might have unintended side effects in g3. 08 December 2021, 18:36:58 UTC
cdf50ff Dylan Hunn 30 November 2021, 19:46:46 UTC refactor(forms): Move FormControl to an overridden exported constructor. (#44316) This implementation change was originally proposed as part of Typed Forms, and will have major consequences for that project as described in the design doc. Submitting it separately will greatly simplify the risk of landing Typed Forms. This change should have no visible impact on normal users of FormControl. See the Typed Forms design doc here: https://docs.google.com/document/d/1cWuBE-oo5WLtwkLFxbNTiaVQGNk8ipgbekZcKBeyxxo. PR Close #44316 08 December 2021, 18:24:28 UTC
6df314f Kristiyan Kostadinov 07 December 2021, 07:45:24 UTC refactor(animations): remove unnecessary code (#44378) * The `TransitionAnimationEngine` had a fallback where it would store classes directly on a node if it doesn't have a `classList`. Presumably this is to support old browsers or if an animation is set on something like `ng-container`. This information was never used for anything since `containsClass` was never called. These changes simplify the logic to just a null check. * Deprecates the `AnimationDriver.matchesElement` method, because it was only used in one place which can be replaced with `classList.contains`. We can't remove the method completely, because `AnimationDriver` is a public API. We also can't turn it into a method on the base class in order to remove it from the sub-classes, because it can break apps using `noImplicitOverride` while extending `AnimationDriver`. PR Close #44378 08 December 2021, 18:23:40 UTC
80ab604 Markus Doggweiler 07 December 2021, 20:55:13 UTC docs(localize): fix typo in i18n-overview.md (#44389) Co-authored-by: Andrew Kushnir <43554145+AndrewKushnir@users.noreply.github.com> PR Close #44389 08 December 2021, 18:22:31 UTC
52a73c6 Andrew Kushnir 04 December 2021, 02:41:44 UTC refactor(animations): reuse existing Version class (#44375) Animations package has its own implementation of the `Version` class, when other packages use an implementation from `@angular/core`. This commit aligns Animations package with other packages and makes use of the `Version` class from `@angular/core`. PR Close #44375 07 December 2021, 13:34:53 UTC
c434e84 dario-piotrowicz 04 December 2021, 15:08:22 UTC test: spy on console.error in configureTestingModule reset test (#44377) improve the configureTestingModule reset test by also spying on console.error and making sure that an error is logged to the user when it should be PR Close #44377 07 December 2021, 13:34:29 UTC
bca5638 dario-piotrowicz 05 December 2021, 15:46:19 UTC docs(animations): add `:enter` and `:leave` info to query api docs (#44379) add information to the query api docs clarifying what elements can be queried as entering and leaving (as that is not currently clearly documented and has caused confusions to developers) one of the tasks of issue #44253 PR Close #44379 07 December 2021, 13:34:04 UTC
4126591 George Kalpakas 05 December 2021, 20:51:28 UTC fix(ngcc): correctly resolve UMD dependencies (#44381) Previously, when processing UMD, ngcc assumed that the `exports` argument of the CommonJS factory call (if present) would be the first argument of the call. This is generally true for the supported UMD formats, but can change if ngcc prepends more imports (and thus factory arguments) while processing the module. This could lead to errors when trying to collect dependencies of an already processed module. (This was accidentally broken in #44245 (commit 2bc3522e167).) This commit fixes it by not making any assumptions about the position of an `exports` argument in the CommonJS factory call. Fixes #44380 PR Close #44381 07 December 2021, 13:33:00 UTC
43db243 Alex Rickabaugh 22 November 2021, 22:35:55 UTC refactor(compiler): delete View Engine components of @angular/compiler (#44368) This commit finishes the removal of View Engine from the codebase, deleting those pieces of @angular/compiler which were only used for VE. Co-Authored-By: JoostK <joost.koehoorn@gmail.com> PR Close #44368 06 December 2021, 18:12:36 UTC
433a956 Renovate Bot 03 December 2021, 06:45:46 UTC build: update dependency jsdom to v19 (#44362) PR Close #44362 03 December 2021, 16:49:42 UTC
back to top