Revision 9d1817cab2f030f6af360e961cc69bb1da8ad765 authored by Marcin Jurkowski on 02 March 2013, 13:50:15 UTC, committed by Greg Kroah-Hartman on 12 March 2013, 23:20:46 UTC
On Sat, Mar 02, 2013 at 10:45:10AM +0100, Sven Geggus wrote: > This is the bad commit I found doing git bisect: > 04f482faf50535229a5a5c8d629cf963899f857c is the first bad commit > commit 04f482faf50535229a5a5c8d629cf963899f857c > Author: Patrick McHardy <kaber@trash.net> > Date: Mon Mar 28 08:39:36 2011 +0000 Good job. I was too lazy to bisect for bad commit;) Reading the code I found problematic kthread_should_stop call from netlink connector which causes the oops. After applying a patch, I've been testing owfs+w1 setup for nearly two days and it seems to work very reliable (no hangs, no memleaks etc). More detailed description and possible fix is given below: Function w1_search can be called from either kthread or netlink callback. While the former works fine, the latter causes oops due to kthread_should_stop invocation. This patch adds a check if w1_search is serving netlink command, skipping kthread_should_stop invocation if so. Signed-off-by: Marcin Jurkowski <marcin1j@gmail.com> Acked-by: Evgeniy Polyakov <zbr@ioremap.net> Cc: Josh Boyer <jwboyer@gmail.com> Tested-by: Sven Geggus <lists@fuchsschwanzdomain.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: stable <stable@vger.kernel.org> # 3.0+
1 parent 34ccd87
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 1.2 KB |
Makefile | -rw-r--r-- | 178 bytes |
xz_crc32.c | -rw-r--r-- | 1.2 KB |
xz_dec_bcj.c | -rw-r--r-- | 13.6 KB |
xz_dec_lzma2.c | -rw-r--r-- | 28.4 KB |
xz_dec_stream.c | -rw-r--r-- | 19.3 KB |
xz_dec_syms.c | -rw-r--r-- | 664 bytes |
xz_dec_test.c | -rw-r--r-- | 5.2 KB |
xz_lzma2.h | -rw-r--r-- | 6.0 KB |
xz_private.h | -rw-r--r-- | 4.4 KB |
xz_stream.h | -rw-r--r-- | 1.4 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...