| 9df593b | TypeScript Bot | 28 October 2019, 18:04:07 UTC | Cherry-pick PR #34745 into release-3.7 (#34766) Component commits: 07a371bbf6 Fix extract type on JS function params | 28 October 2019, 18:04:07 UTC |
| 6317c90 | TypeScript Bot | 28 October 2019, 17:58:15 UTC | Cherry-pick PR #34764 into release-3.7 (#34765) Component commits: ab9bc3a55a Fix type reference to merged prototype property assignment The constructor function code path in the return type checking of signatures needs to pass the *merged* symbol of the declaration to getDeclaredTypeOfClassOrInterface. Other callers of getDeclaredTypeOfClassOrInterface do this, or used an already-merged symbol. Fixes #33993 | 28 October 2019, 17:58:15 UTC |
| 330c8ac | TypeScript Bot | 24 October 2019, 23:05:34 UTC | Cherry-pick PR #34702 into release-3.7 (#34710) Component commits: 7be925173c Exclude ?? operator from true/false literal check in createFlowCondition b9802166ae Accept new API baselines 3d4c14c5f8 Add tests 7362545e8c Accept new baselines 2d1af77839 Address CR feedback 8f0de27784 Accept new API baselines | 24 October 2019, 23:05:34 UTC |
| db419ff | TypeScript Bot | 24 October 2019, 22:10:57 UTC | Update user baselines (#34722) | 24 October 2019, 22:10:57 UTC |
| 1ac8f40 | TypeScript Bot | 24 October 2019, 21:30:58 UTC | 🤖 Cherry-pick PR #33847 into release-3.7 (#34720) Component commits: 97dcbd3bb9 Avoid a crash with `@typedef` in a script file. Scripts (as opposed to modules) do not have a symbol object. If a script contains a `@typdef` defined on a namespace called `exports`, TypeScript crashes because it attempts to create an exported symbol on the (non-existent) symbol of the SourceFile. This change avoids the crash by explicitly checking if the source file has a symbol object, i.e. whether it is a module. f9b7d6eaa8 Add usage of exports.SomeName typedef. 92dc69ddf0 Fix bug at bind site rather than in declare func | 24 October 2019, 21:30:58 UTC |
| cd0bfdd | TypeScript Bot | 24 October 2019, 21:03:36 UTC | Update user baselines (#34711) | 24 October 2019, 21:03:36 UTC |
| 04d55bf | Andrew Casey | 22 October 2019, 00:41:06 UTC | Handle undefined from getPropertyNameForPropertyNameNode ...which can be returned when the property name is computed. Part of #34404 | 24 October 2019, 17:29:29 UTC |
| 58bcb1e | TypeScript Bot | 24 October 2019, 17:12:24 UTC | Update user baselines (#34709) | 24 October 2019, 17:12:24 UTC |
| 23d1b7b | TypeScript Bot | 24 October 2019, 16:58:21 UTC | Cherry-pick PR #34706 into release-3.7 (#34708) Component commits: 056a656937 Restore delayed merge check to getTypeFromJSDocValueReference This is needed when a function merges with a prototype assignment. The resulting *merged* symbol is a constructor function marked with SymbolFlags.Class. However, the merge doesn't happen until getTypeOfFuncClassEnumModule is called, which, in the getTypeReferenceType code path, doesn't happen until getTypeFromJSDocValueReference. That means the check for SymbolFlags.Class is missed. Previously, getTypeFromJSDocValueReference had a weird check `symbol !== getTypeOfSymbol(symbol).symbol`, which, if true, ran getTypeReferenceType again on `getTypeOfSymbol(symbol).symbol`. For JS "aliases", this had the effect of dereferencing the alias, and for function-prototype merges, this had the effect of ... just trying again after the merge had happened. This is a confusing way to run things. getTypeReferenceType should instead detect a function-prototype merge, cause it to happen, and *then* run the rest of its code instead of relying on try-again logic at the very end. However, for the RC, I want to fix this code by restoring the old check, with an additional check to make sure that #33106 doesn't break again: ```ts const valueType = getTypeOfSymbol(symbol) symbol !== valueType.symbol && getMergedSymbol(symbol) === valueType.symbol ``` I'll work on the real fix afterwards and put it into 3.8. d1515f4ee0 Add bug number | 24 October 2019, 16:58:21 UTC |
| 4930148 | TypeScript Bot | 24 October 2019, 16:25:35 UTC | Cherry-pick PR #34683 into release-3.7 (#34705) Component commits: 2aa257df80 getTypeFromJSDocValueReference: handle import types Previously it only handled types whose declaration was from `require`, but now it handles types whose reference is an import type as well. | 24 October 2019, 16:25:35 UTC |
| ce9ce20 | TypeScript Bot | 23 October 2019, 21:19:33 UTC | Update user baselines (#34682) | 23 October 2019, 21:19:33 UTC |
| 49dfb5f | typescript-bot | 23 October 2019, 19:04:16 UTC | Update LKG | 23 October 2019, 20:22:52 UTC |
| 7afaef1 | Wesley Wigham | 23 October 2019, 19:03:00 UTC | Cherry-pick PR #34679 into release-3.7 Component commits: e0b98c6eae Do not consider element accesses which are neither statically bindable nor late bound as special assignments | 23 October 2019, 20:22:52 UTC |
| 43fb7b4 | TypeScript Bot | 22 October 2019, 23:00:13 UTC | Update user baselines (#34660) | 22 October 2019, 23:00:13 UTC |
| f21e931 | Nathan Shively-Sanders | 22 October 2019, 22:22:40 UTC | Cherry-pick PR #34649 into release-3.7 (#34657) Component commits: b6744812a0 Treat any mix of element/prop access as declaration in JS Fixes #34642 but, notably, doesn't actually make the assignment into a working declaration. It just fixes the crash. | 22 October 2019, 22:22:40 UTC |
| ea71ecf | TypeScript Bot | 22 October 2019, 22:22:31 UTC | Cherry-pick PR #34650 into release-3.7 (#34658) Component commits: 6a6f4a666e Fix crash in assigning function with this ref to alias | 22 October 2019, 22:22:31 UTC |
| 2b0d460 | Nathan Shively-Sanders | 22 October 2019, 21:47:40 UTC | Cherry-pick PR #34649 into release-3.7 Component commits: b6744812a0 Treat any mix of element/prop access as declaration in JS Fixes #34642 but, notably, doesn't actually make the assignment into a working declaration. It just fixes the crash. | 22 October 2019, 21:47:42 UTC |
| 4b09fd7 | Daniel Rosenwasser | 21 October 2019, 21:50:14 UTC | Update LKG. | 21 October 2019, 21:50:14 UTC |
| 0d53d2f | Daniel Rosenwasser | 21 October 2019, 21:49:04 UTC | Update version. | 21 October 2019, 21:49:04 UTC |
| eea1268 | Daniel Rosenwasser | 21 October 2019, 21:48:19 UTC | Merge remote-tracking branch 'origin/master' into release-3.7 | 21 October 2019, 21:48:19 UTC |
| f84fd30 | Anders Hejlsberg | 21 October 2019, 19:50:38 UTC | Merge pull request #34607 from microsoft/fix33490 Fix type inference regression | 21 October 2019, 19:50:38 UTC |
| ff6626f | Anders Hejlsberg | 21 October 2019, 19:36:07 UTC | Merge pull request #34597 from microsoft/optionalChainControlFlow More optional chaining control flow analysis | 21 October 2019, 19:36:07 UTC |
| 28028eb | Daniel Rosenwasser | 21 October 2019, 18:50:14 UTC | Extend the correct tsconfig.json. (#34615) Extend the correct tsconfig.json. | 21 October 2019, 18:50:14 UTC |
| b167012 | Daniel Rosenwasser | 21 October 2019, 17:46:41 UTC | Extend the correct tsconfig.json. | 21 October 2019, 17:46:41 UTC |
| 1d3ecc0 | Andrew Branch | 21 October 2019, 16:56:02 UTC | Ensure export= symbol from JavaScript always has a valueDeclaration (#34553) | 21 October 2019, 16:56:02 UTC |
| 82019d6 | Anders Hejlsberg | 21 October 2019, 01:01:41 UTC | Accept new baselines | 21 October 2019, 01:01:41 UTC |
| 56520da | Anders Hejlsberg | 21 October 2019, 01:00:08 UTC | Add regression tests | 21 October 2019, 01:00:08 UTC |
| 8f15a2e | Anders Hejlsberg | 21 October 2019, 00:59:21 UTC | Fix type inference regression | 21 October 2019, 00:59:21 UTC |
| ee846d9 | Anders Hejlsberg | 19 October 2019, 17:52:04 UTC | Accept new baselines | 19 October 2019, 17:52:04 UTC |
| d218a31 | Anders Hejlsberg | 19 October 2019, 17:51:59 UTC | Add tests | 19 October 2019, 17:51:59 UTC |
| 60b3915 | Anders Hejlsberg | 19 October 2019, 14:04:24 UTC | And a few more | 19 October 2019, 14:04:24 UTC |
| e8782ae | Orta | 19 October 2019, 13:06:18 UTC | Merge pull request #34574 from orta/add_docs_tsserver_debug Improve the launch template | 19 October 2019, 13:06:18 UTC |
| 0a0833b | Orta Therox | 18 October 2019, 20:35:58 UTC | Improve the launch template | 19 October 2019, 12:44:28 UTC |
| b845800 | Daniel Rosenwasser | 19 October 2019, 00:35:59 UTC | Add option to configure automatic optional chain completions (#34552) Add option to configure automatic optional chain completions | 19 October 2019, 00:35:59 UTC |
| f334654 | Daniel Rosenwasser | 19 October 2019, 00:35:37 UTC | Ensure original files are included in tsconfig.release.json (#34584) Ensure original files are included in tsconfig.release.json | 19 October 2019, 00:35:37 UTC |
| 556da72 | Ron Buckton | 19 October 2019, 00:27:47 UTC | [WIP] Improve optional chaining checker performance (#33794) * Improve optional chaining checker performance * Improve optional chaining checker performance * Add flags to Signature * Inline getOptionalExpression * split checks for optional chains * Cache optional call signatures | 19 October 2019, 00:27:47 UTC |
| 98fe342 | Anders Hejlsberg | 18 October 2019, 23:33:55 UTC | Handle more cases | 18 October 2019, 23:33:55 UTC |
| 91196fc | Andrew Branch | 18 October 2019, 23:31:43 UTC | Ensure functions that have prototype properties assigned by Object.defineProperty get marked as classes (#34577) * Ensure functions that have prototype properties assigned by Object.defineProperty get marked as classes * Revert unneeded change | 18 October 2019, 23:31:43 UTC |
| fbc070f | Daniel Rosenwasser | 18 October 2019, 23:12:26 UTC | Extend tsconfig.release.json from the sibling tsconfig.json to ensure files aren't forgotten. | 18 October 2019, 23:12:31 UTC |
| 218bbcd | Daniel Rosenwasser | 18 October 2019, 22:23:56 UTC | Don't immediately return in getMemberSymbols. | 18 October 2019, 22:23:56 UTC |
| cdf1ab2 | Nathan Shively-Sanders | 18 October 2019, 21:13:14 UTC | Bind @class in the right place -- bindWorker not bindChildrenWorker (#34575) Also add an assert to make future mismatches fail in an obvious place instead of in a while loop. | 18 October 2019, 21:13:14 UTC |
| fa1884e | Nathan Shively-Sanders | 18 October 2019, 20:31:44 UTC | Fix crash in expando assignment to alias (#34566) * Fix crash in expando assignment to alias This PR disallows expando assignments Fixes #34493, but disallows the prototype assignment nonetheless. * Revert mistaken changes | 18 October 2019, 20:31:44 UTC |
| 1d5add5 | Nathan Shively-Sanders | 18 October 2019, 20:23:38 UTC | Emit computed property temps even w/o init w/useDefineForClassFields (#34406) Fixes #33857 | 18 October 2019, 20:23:38 UTC |
| 9b6a027 | Daniel Rosenwasser | 18 October 2019, 20:03:25 UTC | Perform checks prior to calling `addTypeProperties`. | 18 October 2019, 20:03:25 UTC |
| 241de73 | Anders Hejlsberg | 18 October 2019, 19:07:03 UTC | Merge pull request #34496 from microsoft/fix34272 Properly attach alias symbol to `readonly T[]` types | 18 October 2019, 19:07:03 UTC |
| d3df927 | Anders Hejlsberg | 18 October 2019, 17:50:03 UTC | Optional chain control flow analysis fixes | 18 October 2019, 17:50:03 UTC |
| 1bfc472 | Ben Lichtman | 18 October 2019, 16:44:51 UTC | Merge pull request #33938 from uniqueiniquity/classifcationAssertion Add assertion when classification has unexpected length | 18 October 2019, 16:44:51 UTC |
| 65561a8 | Ben Lichtman | 18 October 2019, 16:18:16 UTC | fix assertion condition | 18 October 2019, 16:18:16 UTC |
| 0fc3888 | Michael Crane | 18 October 2019, 16:13:40 UTC | Remove redundant and misplaced perfLogger startup statement (#34551) | 18 October 2019, 16:13:40 UTC |
| 82f927f | Nathan Shively-Sanders | 18 October 2019, 16:01:21 UTC | Fix stack overflow in circular assignment declaration (#34543) * Fix stack overflow in circular assignment declaration It also needs to have multiple assignments so that it has a ValueModule flag. Fixes #33006 * remove errant comment * Remove other possible circularity * Restore fallback with additional condition | 18 October 2019, 16:01:21 UTC |
| 9ff9c41 | Tim Suchanek | 18 October 2019, 15:59:49 UTC | Add completion test for partial generic object (#34559) | 18 October 2019, 15:59:49 UTC |
| dd58bfc | Andrew Casey | 18 October 2019, 01:28:34 UTC | Merge pull request #34505 from amcasey/ListFilesOnly Add listFilesOnly command-line option | 18 October 2019, 01:28:34 UTC |
| 30cca63 | Daniel Rosenwasser | 18 October 2019, 00:45:25 UTC | Accepted baselines. | 18 October 2019, 00:45:25 UTC |
| 85e0913 | Daniel Rosenwasser | 18 October 2019, 00:45:13 UTC | Update comment. | 18 October 2019, 00:45:13 UTC |
| 3d7451c | Daniel Rosenwasser | 18 October 2019, 00:40:41 UTC | Accepted baselines. | 18 October 2019, 00:41:49 UTC |
| 15445e1 | Daniel Rosenwasser | 18 October 2019, 00:17:19 UTC | Add user preference to the protocol. | 18 October 2019, 00:41:49 UTC |
| 73e9715 | Daniel Rosenwasser | 18 October 2019, 00:05:08 UTC | Added option 'includeAutomaticOptionalChainCompletions' to disable '?.' completions. | 18 October 2019, 00:41:49 UTC |
| 7275e9c | Andrew Casey | 18 October 2019, 00:22:47 UTC | Delete redundant test | 18 October 2019, 00:22:47 UTC |
| d2fab65 | Daniel Rosenwasser | 18 October 2019, 00:04:45 UTC | Added test. | 18 October 2019, 00:04:45 UTC |
| 526e413 | Andrew Casey | 17 October 2019, 23:51:30 UTC | Dropping assert for 3.7 | 17 October 2019, 23:51:30 UTC |
| 8927aaa | Andrew Casey | 17 October 2019, 23:50:22 UTC | Rewrite tests | 17 October 2019, 23:50:22 UTC |
| 9dd8391 | Andrew Casey | 17 October 2019, 23:32:48 UTC | Add additional properties to switch declaration | 17 October 2019, 23:36:54 UTC |
| d18130d | Andrew Casey | 16 October 2019, 21:09:57 UTC | Consolidate checks in emitFilesAndReportErrors | 17 October 2019, 23:36:54 UTC |
| caf0041 | Andrew Casey | 10 October 2019, 23:54:11 UTC | Add listFilesOnly command-line option Msbuild currently uses a combination of `--listFiles` and `--noEmit` to obtain a list of files to be consumed by tsc. However, these two flags don't suppress type checking, the results of which msbuild will never consume. This new switch gives msbuild a faster way to obtain the file list. Note: like `--noEmit`, doesn't make sense in build mode. | 17 October 2019, 23:36:50 UTC |
| a8dc7af | csigs | 17 October 2019, 22:11:05 UTC | LEGO: Merge pull request 34549 LEGO: Merge pull request 34549 | 17 October 2019, 22:11:05 UTC |
| 80cb807 | csigs | 17 October 2019, 22:10:36 UTC | LEGO: check in for master to temporary branch. | 17 October 2019, 22:10:36 UTC |
| 580e3f5 | Sheetal Nandi | 17 October 2019, 21:19:49 UTC | Merge pull request #34527 from microsoft/rootDir Use getNormalizedAbsolutePath to combine basePath and config value for file names | 17 October 2019, 21:19:49 UTC |
| 454a3a0 | Andrew Branch | 17 October 2019, 20:59:09 UTC | Fix auto-imports from auto type acquisition definitions (#33766) * Fix auto-imports from ATA typings * Compare canonical filenames in isImportablePath | 17 October 2019, 20:59:09 UTC |
| b3df23c | Sheetal Nandi | 17 October 2019, 20:15:26 UTC | Accept module resolution trace baseline where baseUrl is specified as "../" in tsconfig | 17 October 2019, 20:15:26 UTC |
| fde10a2 | Sheetal Nandi | 17 October 2019, 19:54:26 UTC | Merge branch 'master' into rootDir | 17 October 2019, 19:54:26 UTC |
| 6d969f7 | Sheetal Nandi | 17 October 2019, 19:50:30 UTC | Merge pull request #34525 from microsoft/testChanges Converted more tsc and tsbuild tests to baseline | 17 October 2019, 19:50:30 UTC |
| 575339c | Sheetal Nandi | 17 October 2019, 19:26:16 UTC | Merge branch 'master' into testChanges | 17 October 2019, 19:26:16 UTC |
| 4055689 | Sheetal Nandi | 17 October 2019, 19:22:25 UTC | Merge pull request #34487 from microsoft/skipTsBuildinfoEmit Do not write build info if there are no files to emit | 17 October 2019, 19:22:25 UTC |
| 4530d3e | Sheetal Nandi | 17 October 2019, 19:04:24 UTC | Fixed scenario names | 17 October 2019, 19:04:24 UTC |
| 6caa928 | Sheetal Nandi | 17 October 2019, 19:00:41 UTC | Fix scenario name | 17 October 2019, 19:00:41 UTC |
| afee423 | Sheetal Nandi | 17 October 2019, 18:54:26 UTC | Feedback on formatting | 17 October 2019, 18:54:26 UTC |
| 5b5f88e | Sheetal Nandi | 17 October 2019, 18:52:22 UTC | Add test with incremental program with only d.ts files | 17 October 2019, 18:52:22 UTC |
| f32c2ea | Sheetal Nandi | 16 October 2019, 15:37:06 UTC | Some changes to incremental tests | 17 October 2019, 18:46:54 UTC |
| f5dbcb7 | Nathan Shively-Sanders | 17 October 2019, 18:21:34 UTC | Resolve more jsdoc value references as types (#34515) * Resolve more jsdoc value references as types * add test | 17 October 2019, 18:21:34 UTC |
| 262ec61 | Nathan Shively-Sanders | 17 October 2019, 18:14:07 UTC | Make ImageData(Uint8ClampedArray)'s 3rd param optional (#34519) It can be inferred from the first two. Fixes #33266 Baseline update from microsoft/TSJS-lib-generator#790 | 17 October 2019, 18:14:07 UTC |
| f41b7b5 | Andrew Branch | 17 October 2019, 17:54:01 UTC | Fix quick info for methods whose contextual type is a mapped type property (#33930) | 17 October 2019, 17:54:01 UTC |
| a95a25b | Andrew Branch | 17 October 2019, 17:45:40 UTC | Fix completions of optional properties in generic positions (#33937) * fixes #30507 * Add test case for generic Partial type * Fixes #28470 * Simplify contextFlags binary check * Add string literal completion test * Fix ContextFlags typings * Speed up inference expression for completion * Fix baseline merge * Make contextFlags internal * Reapply readonly array changes * accept baselines * Fix generic completion tests * Re-merge ContextFlags * Don’t change type during inference * Fix typos and superfluous undefined arguments * Add test for completions in unconstrained generic object literal | 17 October 2019, 17:45:40 UTC |
| 45d0ef9 | Klaus Meinhardt | 17 October 2019, 17:17:33 UTC | factory: parenthesize for-of expression when necessary (#34229) Fixes: #33856 | 17 October 2019, 17:17:33 UTC |
| 5d20c57 | Orta | 17 October 2019, 17:08:32 UTC | Merge pull request #34524 from orta/fix_32675 Does not add a duplicate completion when offering an export which was re-declared as a global | 17 October 2019, 17:08:32 UTC |
| 85010fa | Orta Therox | 17 October 2019, 16:12:41 UTC | Make sure that global module re-exports are short-cutted to be added to completions | 17 October 2019, 16:33:01 UTC |
| 43cf899 | Orta | 17 October 2019, 14:48:18 UTC | Merge pull request #34530 from connorjclark/patch-1 Update bug template to link to nightly playground | 17 October 2019, 14:48:18 UTC |
| d6663bf | Connor Clark | 17 October 2019, 02:44:48 UTC | Update bug template to link to nightly playground | 17 October 2019, 02:44:48 UTC |
| f3a234c | Nathan Shively-Sanders | 16 October 2019, 22:56:01 UTC | Dedupe inherited jsdoc comments (#34522) JSDoc on own properties was already deduped, but inherited jsdoc was incorrectly not deduped. Fixes #32708 | 16 October 2019, 22:56:01 UTC |
| 1531c9e | Sheetal Nandi | 16 October 2019, 22:42:53 UTC | Fix lint rules | 16 October 2019, 22:42:53 UTC |
| 9fa7d8b | Sheetal Nandi | 16 October 2019, 22:38:29 UTC | Use getNormalizedAbsolutePath to combine basePath and config value for file names Fixes #34502 by being consistent in path normalization | 16 October 2019, 22:38:29 UTC |
| d020ac6 | csigs | 16 October 2019, 22:10:56 UTC | LEGO: Merge pull request 34526 LEGO: Merge pull request 34526 | 16 October 2019, 22:10:56 UTC |
| 0709bde | csigs | 16 October 2019, 22:10:29 UTC | LEGO: check in for master to temporary branch. | 16 October 2019, 22:10:29 UTC |
| a4044ca | Sheetal Nandi | 16 October 2019, 21:31:59 UTC | Add test for #34502 | 16 October 2019, 21:32:18 UTC |
| 66ea16a | Sheetal Nandi | 16 October 2019, 19:55:58 UTC | Sample to baseline output | 16 October 2019, 21:05:07 UTC |
| c40ddb1 | Orta Therox | 16 October 2019, 21:02:35 UTC | Does not add a duplicate completion when offering an export which was re-declared as a global - fixes #32675 | 16 October 2019, 21:02:35 UTC |
| e54d5ca | Sheetal Nandi | 16 October 2019, 19:24:06 UTC | outFile to baseline | 16 October 2019, 19:51:41 UTC |
| 5390c64 | Sheetal Nandi | 16 October 2019, 19:18:16 UTC | rootDir tests are baselined | 16 October 2019, 19:19:26 UTC |
| 928a4e7 | Sheetal Nandi | 16 October 2019, 19:03:12 UTC | resolveJsonModule as baseline test | 16 October 2019, 19:12:12 UTC |
| 4b13406 | Sheetal Nandi | 16 October 2019, 18:52:46 UTC | transitiveReferences as baseline | 16 October 2019, 18:52:46 UTC |
| 25db0b0 | Sheetal Nandi | 16 October 2019, 18:20:14 UTC | Merge baselining and tsc logic into one | 16 October 2019, 18:39:40 UTC |
