Revision 9ecfe875c4f311618cc918aded716017dcd2ddf1 authored by Karicheri, Muralidharan on 19 February 2016, 17:58:42 UTC, committed by David S. Miller on 22 February 2016, 03:03:15 UTC
The commit 899077791403 ("netcp: try to reduce type confusion in descriptors") introduces a regression in Kernel 4.5-rc1 and it breaks get/set_pad_info() functionality. The TI NETCP driver uses pad0 and pad1 fields of knav_dma_desc to store DMA/MEM buffer pointer and buffer size respectively. And in both cases for Keystone 2 the pointer type size is 32 bit regardless of LAPE enabled or not, because CONFIG_ARCH_DMA_ADDR_T_64BIT originally is not expected to be defined. Unfortunately, above commit changed buffer's pointers save/restore code (get/set_pad_info()) and added intermediate conversation to u64 which works incorrectly on 32bit Keystone 2 and causes TI NETCP driver crash in RX/TX path due to "Unable to handle kernel NULL pointer" exception. This issue was reported and discussed in [1]. Hence, fix it by partially reverting above commit and restoring get/set_pad_info() functionality as it was before. [1] https://www.mail-archive.com/netdev@vger.kernel.org/msg95361.html Cc: Wingman Kwok <w-kwok2@ti.com> Cc: Mugunthan V N <mugunthanvnm@ti.com> CC: David Laight <David.Laight@ACULAB.COM> CC: Arnd Bergmann <arnd@arndb.de> Reported-by: Franklin S Cooper Jr <fcooper@ti.com> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com> Acked-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 3301be3
File | Mode | Size |
---|---|---|
i386 | ||
x86_64 | ||
00-INDEX | -rw-r--r-- | 643 bytes |
boot.txt | -rw-r--r-- | 38.7 KB |
early-microcode.txt | -rw-r--r-- | 1.7 KB |
earlyprintk.txt | -rw-r--r-- | 5.7 KB |
entry_64.txt | -rw-r--r-- | 4.1 KB |
exception-tables.txt | -rw-r--r-- | 11.7 KB |
intel_mpx.txt | -rw-r--r-- | 10.9 KB |
kernel-stacks | -rw-r--r-- | 6.1 KB |
mtrr.txt | -rw-r--r-- | 11.6 KB |
pat.txt | -rw-r--r-- | 9.7 KB |
tlb.txt | -rw-r--r-- | 3.6 KB |
usb-legacy-support.txt | -rw-r--r-- | 1.8 KB |
zero-page.txt | -rw-r--r-- | 1.7 KB |
Computing file changes ...