Revision 9f141d6ef6258a3a37a045842d9ba7e68f368956 authored by Jan Kara on 19 October 2016, 12:34:31 UTC, committed by Dan Williams on 27 December 2016, 04:29:25 UTC
Currently ->iomap_begin() handler is called with entry lock held. If the
filesystem held any locks between ->iomap_begin() and ->iomap_end()
(such as ext4 which will want to hold transaction open), this would cause
lock inversion with the iomap_apply() from standard IO path which first
calls ->iomap_begin() and only then calls ->actor() callback which grabs
entry locks for DAX (if it faults when copying from/to user provided
buffers).

Fix the problem by nesting grabbing of entry lock inside ->iomap_begin()
- ->iomap_end() pair.

Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
1 parent f449b93
History
File Mode Size
Kconfig -rw-r--r-- 623 bytes
Makefile -rw-r--r-- 281 bytes
csio_attr.c -rw-r--r-- 20.5 KB
csio_defs.h -rw-r--r-- 3.3 KB
csio_hw.c -rw-r--r-- 99.7 KB
csio_hw.h -rw-r--r-- 18.3 KB
csio_hw_chip.h -rw-r--r-- 3.8 KB
csio_hw_t5.c -rw-r--r-- 13.9 KB
csio_init.c -rw-r--r-- 28.7 KB
csio_init.h -rw-r--r-- 4.4 KB
csio_isr.c -rw-r--r-- 14.9 KB
csio_lnode.c -rw-r--r-- 53.4 KB
csio_lnode.h -rw-r--r-- 8.0 KB
csio_mb.c -rw-r--r-- 47.0 KB
csio_mb.h -rw-r--r-- 9.3 KB
csio_rnode.c -rw-r--r-- 22.6 KB
csio_rnode.h -rw-r--r-- 4.7 KB
csio_scsi.c -rw-r--r-- 67.1 KB
csio_scsi.h -rw-r--r-- 10.3 KB
csio_wr.c -rw-r--r-- 42.9 KB
csio_wr.h -rw-r--r-- 13.5 KB
t4fw_api_stor.h -rw-r--r-- 12.7 KB

back to top