Skip to main content

Browse the archive

https://github.com/torvalds/linux
08 September 2024, 02:26:05 UTC
Revision 9f2a1d9fb33a2129a9ba29bc61d3f14adb28ddc2 authored by Jason Yan on 25 October 2022, 04:02:06 UTC, committed by Theodore Ts'o on 06 November 2022, 05:07:59 UTC 
ext4: fix wrong return err in ext4_load_and_init_journal()
 
The return value is wrong in ext4_load_and_init_journal(). The local
variable 'err' need to be initialized before goto out. The original code
in __ext4_fill_super() is fine because it has two return values 'ret'
and 'err' and 'ret' is initialized as -EINVAL. After we factor out
ext4_load_and_init_journal(), this code is broken. So fix it by directly
returning -EINVAL in the error handler path.

Cc: stable@kernel.org
Fixes: 9c1dd22d7422 ("ext4: factor out ext4_load_and_init_journal()")
Signed-off-by: Jason Yan <yanaijie@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20221025040206.3134773-1-yanaijie@huawei.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
1 parent 1b8f787
History
Tip revision: 9f2a1d9fb33a2129a9ba29bc61d3f14adb28ddc2 authored by Jason Yan on 25 October 2022, 04:02:06 UTC
ext4: fix wrong return err in ext4_load_and_init_journal()
Tip revision: 9f2a1d9
File Mode Size
dummy-include
include
.gitignore -rw-r--r-- 96 bytes
Kconfig -rw-r--r-- 7.7 KB
Makefile -rw-r--r-- 2.7 KB
default_cpio_list -rw-r--r-- 153 bytes
gen_init_cpio.c -rw-r--r-- 14.3 KB
gen_initramfs.sh -rwxr-xr-x 5.7 KB
initramfs_data.S -rw-r--r-- 1.2 KB
back to top