Revision - 9fa6f5a - fix(core): incorrectly inserting elements inside <template> [...] - origin: https://github.com/angular/angular

visit type:

https://github.com/angular/angular

01 September 2024, 02:13:37 UTC

Revision 9fa6f5a552b7780ce32aa5a60273d4008a7b6afb authored by Kristiyan Kostadinov on 22 February 2022, 12:53:24 UTC, committed by Andrew Kushnir on 08 March 2022, 18:22:18 UTC

fix(core): incorrectly inserting elements inside <template> element (#43429)

Currently whenever we insert element we do it directly on the node using `appendChild` or `insertBefore`, however this doesn't work with `<template>` elements where the `template.content` has to be used.

These changes add a few checks to call `appendChild` and `insertBefore` on the `content` of the template.

Fixes #15557.

PR Close #43429

1 parent a659d15

Files
Changes

Permalinks

Tip revision: 9fa6f5a552b7780ce32aa5a60273d4008a7b6afb authored by Kristiyan Kostadinov on 22 February 2022, 12:53:24 UTC
fix(core): incorrectly inserting elements inside <template> element (#43429)

Tip revision: 9fa6f5a

File	Mode	Size
.circleci
.devcontainer
.github
.husky
.ng-dev
.vscode
.yarn
aio
devtools
docs
goldens
integration
modules
packages
scripts
third_party
tools
.bazelignore	-rw-r--r--	2.8 KB
.bazelrc	-rw-r--r--	6.7 KB
.bazelversion	-rw-r--r--	6 bytes
.clang-format	-rw-r--r--	73 bytes
.editorconfig	-rw-r--r--	245 bytes
.gitattributes	-rw-r--r--	240 bytes
.gitignore	-rw-r--r--	915 bytes
.gitmessage	-rw-r--r--	7.2 KB
.mailmap	-rw-r--r--	51 bytes
.npmrc	-rw-r--r--	21 bytes
.nvmrc	-rw-r--r--	8 bytes
.prettierrc	-rw-r--r--	157 bytes
.pullapprove.yml	-rw-r--r--	48.2 KB
.yarnrc	-rw-r--r--	130 bytes
BUILD.bazel	-rw-r--r--	2.0 KB
CHANGELOG.md	-rw-r--r--	1006.8 KB
CODE_OF_CONDUCT.md	-rw-r--r--	1.1 KB
CONTRIBUTING.md	-rw-r--r--	15.9 KB
LICENSE	-rw-r--r--	1.1 KB
README.md	-rw-r--r--	4.7 KB
WORKSPACE	-rw-r--r--	3.2 KB
browser-providers.conf.js	-rw-r--r--	1.8 KB
gulpfile.js	-rw-r--r--	631 bytes
karma-js.conf.js	-rw-r--r--	6.0 KB
package.json	-rw-r--r--	9.1 KB
renovate.json	-rw-r--r--	2.6 KB
test-events.js	-rw-r--r--	259 bytes
tsconfig-tslint.json	-rw-r--r--	171 bytes
tslint.json	-rw-r--r--	5.4 KB
yarn.lock	-rw-r--r--	698.9 KB
yarn.lock.readme.md	-rw-r--r--	1.3 KB

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/angular/angular

fix(core): incorrectly inserting elements inside <template> element (#43429)

README.md