https://github.com/torvalds/linux
Revision 9ff9d15eddd13ecdd41876c5e1f31ddbb127101c authored by Bart Van Assche on 22 October 2015, 22:57:04 UTC, committed by Nicholas Bellinger on 29 November 2015, 03:33:23 UTC
This patch fixes the following kernel warning because it avoids that IRQs are disabled while ft_release_cmd() is invoked (fc_seq_set_resp() invokes spin_unlock_bh()): WARNING: CPU: 3 PID: 117 at kernel/softirq.c:150 __local_bh_enable_ip+0xaa/0x110() Call Trace: [<ffffffff814f71eb>] dump_stack+0x4f/0x7b [<ffffffff8105e56a>] warn_slowpath_common+0x8a/0xc0 [<ffffffff8105e65a>] warn_slowpath_null+0x1a/0x20 [<ffffffff81062b2a>] __local_bh_enable_ip+0xaa/0x110 [<ffffffff814ff229>] _raw_spin_unlock_bh+0x39/0x40 [<ffffffffa03a7f94>] fc_seq_set_resp+0xe4/0x100 [libfc] [<ffffffffa02e604a>] ft_free_cmd+0x4a/0x90 [tcm_fc] [<ffffffffa02e6972>] ft_release_cmd+0x12/0x20 [tcm_fc] [<ffffffffa042bd66>] target_release_cmd_kref+0x56/0x90 [target_core_mod] [<ffffffffa042caf0>] target_put_sess_cmd+0xc0/0x110 [target_core_mod] [<ffffffffa042cb81>] transport_release_cmd+0x41/0x70 [target_core_mod] [<ffffffffa042d975>] transport_generic_free_cmd+0x35/0x420 [target_core_mod] Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> Acked-by: Joern Engel <joern@logfs.org> Reviewed-by: Andy Grover <agrover@redhat.com> Cc: Christoph Hellwig <hch@lst.de> Cc: Hannes Reinecke <hare@suse.de> Cc: Sagi Grimberg <sagig@mellanox.com> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
1 parent 057085e
Tip revision: 9ff9d15eddd13ecdd41876c5e1f31ddbb127101c authored by Bart Van Assche on 22 October 2015, 22:57:04 UTC
target: Invoke release_cmd() callback without holding a spinlock
target: Invoke release_cmd() callback without holding a spinlock
Tip revision: 9ff9d15
| File | Mode | Size |
|---|---|---|
| bpf | ||
| configs | ||
| debug | ||
| events | ||
| gcov | ||
| irq | ||
| livepatch | ||
| locking | ||
| power | ||
| printk | ||
| rcu | ||
| sched | ||
| time | ||
| trace | ||
| .gitignore | -rw-r--r-- | 69 bytes |
| Kconfig.freezer | -rw-r--r-- | 52 bytes |
| Kconfig.hz | -rw-r--r-- | 1.6 KB |
| Kconfig.locks | -rw-r--r-- | 4.8 KB |
| Kconfig.preempt | -rw-r--r-- | 2.1 KB |
| Makefile | -rw-r--r-- | 3.8 KB |
| acct.c | -rw-r--r-- | 15.4 KB |
| async.c | -rw-r--r-- | 9.9 KB |
| audit.c | -rw-r--r-- | 53.2 KB |
| audit.h | -rw-r--r-- | 10.9 KB |
| audit_fsnotify.c | -rw-r--r-- | 6.1 KB |
| audit_tree.c | -rw-r--r-- | 22.7 KB |
| audit_watch.c | -rw-r--r-- | 14.4 KB |
| auditfilter.c | -rw-r--r-- | 34.7 KB |
| auditsc.c | -rw-r--r-- | 64.0 KB |
| backtracetest.c | -rw-r--r-- | 2.1 KB |
| bounds.c | -rw-r--r-- | 703 bytes |
| capability.c | -rw-r--r-- | 12.1 KB |
| cgroup.c | -rw-r--r-- | 159.7 KB |
| cgroup_freezer.c | -rw-r--r-- | 12.5 KB |
| cgroup_pids.c | -rw-r--r-- | 8.8 KB |
| compat.c | -rw-r--r-- | 29.5 KB |
| configs.c | -rw-r--r-- | 2.8 KB |
| context_tracking.c | -rw-r--r-- | 6.3 KB |
| cpu.c | -rw-r--r-- | 20.1 KB |
| cpu_pm.c | -rw-r--r-- | 6.5 KB |
| cpuset.c | -rw-r--r-- | 75.2 KB |
| crash_dump.c | -rw-r--r-- | 1.3 KB |
| cred.c | -rw-r--r-- | 21.4 KB |
| delayacct.c | -rw-r--r-- | 4.5 KB |
| dma.c | -rw-r--r-- | 3.6 KB |
| elfcore.c | -rw-r--r-- | 396 bytes |
| exec_domain.c | -rw-r--r-- | 1.4 KB |
| exit.c | -rw-r--r-- | 41.6 KB |
| extable.c | -rw-r--r-- | 4.0 KB |
| fork.c | -rw-r--r-- | 50.8 KB |
| freezer.c | -rw-r--r-- | 4.4 KB |
| futex.c | -rw-r--r-- | 84.6 KB |
| futex_compat.c | -rw-r--r-- | 4.5 KB |
| groups.c | -rw-r--r-- | 5.9 KB |
| hung_task.c | -rw-r--r-- | 5.7 KB |
| irq_work.c | -rw-r--r-- | 4.5 KB |
| jump_label.c | -rw-r--r-- | 12.6 KB |
| kallsyms.c | -rw-r--r-- | 14.9 KB |
| kcmp.c | -rw-r--r-- | 4.3 KB |
| kexec.c | -rw-r--r-- | 6.6 KB |
| kexec_core.c | -rw-r--r-- | 38.0 KB |
| kexec_file.c | -rw-r--r-- | 25.0 KB |
| kexec_internal.h | -rw-r--r-- | 789 bytes |
| kmod.c | -rw-r--r-- | 19.1 KB |
| kprobes.c | -rw-r--r-- | 60.7 KB |
| ksysfs.c | -rw-r--r-- | 5.6 KB |
| kthread.c | -rw-r--r-- | 19.2 KB |
| latencytop.c | -rw-r--r-- | 7.6 KB |
| membarrier.c | -rw-r--r-- | 2.4 KB |
| memremap.c | -rw-r--r-- | 5.4 KB |
| module-internal.h | -rw-r--r-- | 458 bytes |
| module.c | -rw-r--r-- | 102.3 KB |
| module_signing.c | -rw-r--r-- | 2.0 KB |
| notifier.c | -rw-r--r-- | 16.3 KB |
| nsproxy.c | -rw-r--r-- | 6.0 KB |
| padata.c | -rw-r--r-- | 26.8 KB |
| panic.c | -rw-r--r-- | 13.0 KB |
| params.c | -rw-r--r-- | 24.1 KB |
| pid.c | -rw-r--r-- | 15.0 KB |
| pid_namespace.c | -rw-r--r-- | 10.0 KB |
| profile.c | -rw-r--r-- | 16.1 KB |
| ptrace.c | -rw-r--r-- | 30.6 KB |
| range.c | -rw-r--r-- | 3.0 KB |
| reboot.c | -rw-r--r-- | 13.3 KB |
| relay.c | -rw-r--r-- | 32.5 KB |
| resource.c | -rw-r--r-- | 37.0 KB |
| seccomp.c | -rw-r--r-- | 24.7 KB |
| signal.c | -rw-r--r-- | 93.9 KB |
| smp.c | -rw-r--r-- | 19.9 KB |
| smpboot.c | -rw-r--r-- | 13.1 KB |
| smpboot.h | -rw-r--r-- | 564 bytes |
| softirq.c | -rw-r--r-- | 18.9 KB |
| stacktrace.c | -rw-r--r-- | 1.7 KB |
| stop_machine.c | -rw-r--r-- | 16.6 KB |
| sys.c | -rw-r--r-- | 57.5 KB |
| sys_ni.c | -rw-r--r-- | 7.0 KB |
| sysctl.c | -rw-r--r-- | 64.3 KB |
| sysctl_binary.c | -rw-r--r-- | 51.0 KB |
| task_work.c | -rw-r--r-- | 3.2 KB |
| taskstats.c | -rw-r--r-- | 16.1 KB |
| test_kprobes.c | -rw-r--r-- | 7.4 KB |
| torture.c | -rw-r--r-- | 19.9 KB |
| tracepoint.c | -rw-r--r-- | 14.5 KB |
| tsacct.c | -rw-r--r-- | 4.9 KB |
| uid16.c | -rw-r--r-- | 5.0 KB |
| up.c | -rw-r--r-- | 1.7 KB |
| user-return-notifier.c | -rw-r--r-- | 1.3 KB |
| user.c | -rw-r--r-- | 5.4 KB |
| user_namespace.c | -rw-r--r-- | 25.6 KB |
| utsname.c | -rw-r--r-- | 3.0 KB |
| utsname_sysctl.c | -rw-r--r-- | 3.0 KB |
| watchdog.c | -rw-r--r-- | 29.0 KB |
| workqueue.c | -rw-r--r-- | 145.3 KB |
| workqueue_internal.h | -rw-r--r-- | 2.2 KB |
Computing file changes ...
