https://github.com/torvalds/linux
Revision 9ff9d15eddd13ecdd41876c5e1f31ddbb127101c authored by Bart Van Assche on 22 October 2015, 22:57:04 UTC, committed by Nicholas Bellinger on 29 November 2015, 03:33:23 UTC
This patch fixes the following kernel warning because it avoids that IRQs are disabled while ft_release_cmd() is invoked (fc_seq_set_resp() invokes spin_unlock_bh()): WARNING: CPU: 3 PID: 117 at kernel/softirq.c:150 __local_bh_enable_ip+0xaa/0x110() Call Trace: [<ffffffff814f71eb>] dump_stack+0x4f/0x7b [<ffffffff8105e56a>] warn_slowpath_common+0x8a/0xc0 [<ffffffff8105e65a>] warn_slowpath_null+0x1a/0x20 [<ffffffff81062b2a>] __local_bh_enable_ip+0xaa/0x110 [<ffffffff814ff229>] _raw_spin_unlock_bh+0x39/0x40 [<ffffffffa03a7f94>] fc_seq_set_resp+0xe4/0x100 [libfc] [<ffffffffa02e604a>] ft_free_cmd+0x4a/0x90 [tcm_fc] [<ffffffffa02e6972>] ft_release_cmd+0x12/0x20 [tcm_fc] [<ffffffffa042bd66>] target_release_cmd_kref+0x56/0x90 [target_core_mod] [<ffffffffa042caf0>] target_put_sess_cmd+0xc0/0x110 [target_core_mod] [<ffffffffa042cb81>] transport_release_cmd+0x41/0x70 [target_core_mod] [<ffffffffa042d975>] transport_generic_free_cmd+0x35/0x420 [target_core_mod] Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> Acked-by: Joern Engel <joern@logfs.org> Reviewed-by: Andy Grover <agrover@redhat.com> Cc: Christoph Hellwig <hch@lst.de> Cc: Hannes Reinecke <hare@suse.de> Cc: Sagi Grimberg <sagig@mellanox.com> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
1 parent 057085e
Tip revision: 9ff9d15eddd13ecdd41876c5e1f31ddbb127101c authored by Bart Van Assche on 22 October 2015, 22:57:04 UTC
target: Invoke release_cmd() callback without holding a spinlock
target: Invoke release_cmd() callback without holding a spinlock
Tip revision: 9ff9d15
| File | Mode | Size |
|---|---|---|
| kasan | ||
| Kconfig | -rw-r--r-- | 22.3 KB |
| Kconfig.debug | -rw-r--r-- | 1.2 KB |
| Makefile | -rw-r--r-- | 2.7 KB |
| backing-dev.c | -rw-r--r-- | 25.9 KB |
| balloon_compaction.c | -rw-r--r-- | 6.6 KB |
| bootmem.c | -rw-r--r-- | 21.0 KB |
| cleancache.c | -rw-r--r-- | 9.9 KB |
| cma.c | -rw-r--r-- | 12.1 KB |
| cma.h | -rw-r--r-- | 515 bytes |
| cma_debug.c | -rw-r--r-- | 4.4 KB |
| compaction.c | -rw-r--r-- | 48.3 KB |
| debug-pagealloc.c | -rw-r--r-- | 2.6 KB |
| debug.c | -rw-r--r-- | 6.6 KB |
| dmapool.c | -rw-r--r-- | 13.9 KB |
| early_ioremap.c | -rw-r--r-- | 6.2 KB |
| fadvise.c | -rw-r--r-- | 3.7 KB |
| failslab.c | -rw-r--r-- | 1.3 KB |
| filemap.c | -rw-r--r-- | 72.0 KB |
| frame_vector.c | -rw-r--r-- | 6.2 KB |
| frontswap.c | -rw-r--r-- | 14.3 KB |
| gup.c | -rw-r--r-- | 40.1 KB |
| highmem.c | -rw-r--r-- | 11.8 KB |
| huge_memory.c | -rw-r--r-- | 81.1 KB |
| hugetlb.c | -rw-r--r-- | 117.9 KB |
| hugetlb_cgroup.c | -rw-r--r-- | 10.5 KB |
| hwpoison-inject.c | -rw-r--r-- | 3.2 KB |
| init-mm.c | -rw-r--r-- | 619 bytes |
| internal.h | -rw-r--r-- | 14.7 KB |
| interval_tree.c | -rw-r--r-- | 3.1 KB |
| kmemcheck.c | -rw-r--r-- | 2.9 KB |
| kmemleak-test.c | -rw-r--r-- | 3.2 KB |
| kmemleak.c | -rw-r--r-- | 54.5 KB |
| ksm.c | -rw-r--r-- | 63.9 KB |
| list_lru.c | -rw-r--r-- | 12.5 KB |
| maccess.c | -rw-r--r-- | 3.1 KB |
| madvise.c | -rw-r--r-- | 13.9 KB |
| memblock.c | -rw-r--r-- | 47.9 KB |
| memcontrol.c | -rw-r--r-- | 145.1 KB |
| memory-failure.c | -rw-r--r-- | 49.1 KB |
| memory.c | -rw-r--r-- | 105.0 KB |
| memory_hotplug.c | -rw-r--r-- | 52.2 KB |
| mempolicy.c | -rw-r--r-- | 70.6 KB |
| mempool.c | -rw-r--r-- | 14.0 KB |
| memtest.c | -rw-r--r-- | 2.7 KB |
| migrate.c | -rw-r--r-- | 47.6 KB |
| mincore.c | -rw-r--r-- | 6.7 KB |
| mlock.c | -rw-r--r-- | 20.7 KB |
| mm_init.c | -rw-r--r-- | 4.9 KB |
| mmap.c | -rw-r--r-- | 90.2 KB |
| mmu_context.c | -rw-r--r-- | 1.3 KB |
| mmu_notifier.c | -rw-r--r-- | 11.7 KB |
| mmzone.c | -rw-r--r-- | 2.3 KB |
| mprotect.c | -rw-r--r-- | 10.9 KB |
| mremap.c | -rw-r--r-- | 15.1 KB |
| msync.c | -rw-r--r-- | 2.6 KB |
| nobootmem.c | -rw-r--r-- | 11.1 KB |
| nommu.c | -rw-r--r-- | 51.9 KB |
| oom_kill.c | -rw-r--r-- | 20.7 KB |
| page-writeback.c | -rw-r--r-- | 83.7 KB |
| page_alloc.c | -rw-r--r-- | 188.9 KB |
| page_counter.c | -rw-r--r-- | 4.8 KB |
| page_ext.c | -rw-r--r-- | 10.4 KB |
| page_idle.c | -rw-r--r-- | 5.4 KB |
| page_io.c | -rw-r--r-- | 9.2 KB |
| page_isolation.c | -rw-r--r-- | 8.3 KB |
| page_owner.c | -rw-r--r-- | 7.1 KB |
| pagewalk.c | -rw-r--r-- | 7.5 KB |
| percpu-km.c | -rw-r--r-- | 2.8 KB |
| percpu-vm.c | -rw-r--r-- | 10.0 KB |
| percpu.c | -rw-r--r-- | 66.1 KB |
| pgtable-generic.c | -rw-r--r-- | 5.7 KB |
| process_vm_access.c | -rw-r--r-- | 9.8 KB |
| quicklist.c | -rw-r--r-- | 2.4 KB |
| readahead.c | -rw-r--r-- | 15.4 KB |
| rmap.c | -rw-r--r-- | 46.9 KB |
| shmem.c | -rw-r--r-- | 89.8 KB |
| slab.c | -rw-r--r-- | 107.6 KB |
| slab.h | -rw-r--r-- | 10.4 KB |
| slab_common.c | -rw-r--r-- | 29.9 KB |
| slob.c | -rw-r--r-- | 16.0 KB |
| slub.c | -rw-r--r-- | 132.9 KB |
| sparse-vmemmap.c | -rw-r--r-- | 6.0 KB |
| sparse.c | -rw-r--r-- | 20.9 KB |
| swap.c | -rw-r--r-- | 32.1 KB |
| swap_cgroup.c | -rw-r--r-- | 4.6 KB |
| swap_state.c | -rw-r--r-- | 13.1 KB |
| swapfile.c | -rw-r--r-- | 77.7 KB |
| truncate.c | -rw-r--r-- | 23.7 KB |
| userfaultfd.c | -rw-r--r-- | 7.2 KB |
| util.c | -rw-r--r-- | 10.9 KB |
| vmacache.c | -rw-r--r-- | 3.1 KB |
| vmalloc.c | -rw-r--r-- | 68.1 KB |
| vmpressure.c | -rw-r--r-- | 11.4 KB |
| vmscan.c | -rw-r--r-- | 111.0 KB |
| vmstat.c | -rw-r--r-- | 41.2 KB |
| workingset.c | -rw-r--r-- | 13.6 KB |
| zbud.c | -rw-r--r-- | 18.2 KB |
| zpool.c | -rw-r--r-- | 10.0 KB |
| zsmalloc.c | -rw-r--r-- | 47.7 KB |
| zswap.c | -rw-r--r-- | 32.0 KB |
Computing file changes ...
