Revision - a01acec - fix(docs-infra): use correct parameters for paginated requests [...] - origin: https://github.com/angular/angular

visit type:

https://github.com/angular/angular

19 April 2024, 08:24:33 UTC

Revision a01acec7febf30bdedd7fad2b6c2187886b3e9c0 authored by George Kalpakas on 15 September 2018, 12:44:38 UTC, committed by Kara Erickson on 26 September 2018, 22:26:19 UTC

fix(docs-infra): use correct parameters for paginated requests to GitHub (#25671)

As it turns out, in GitHub API paginated requests, page numbering is
1-based. (https://developer.github.com/v3/#pagination)

Starting at page 0 (which returns the first page), results in making the
same request twice and logging incorrect numbers (since the first 100
items are listed twice).

PR Close #25671

1 parent 021f434

Files
Changes

Permalinks

Tip revision: a01acec7febf30bdedd7fad2b6c2187886b3e9c0 authored by George Kalpakas on 15 September 2018, 12:44:38 UTC
fix(docs-infra): use correct parameters for paginated requests to GitHub (#25671)

Tip revision: a01acec

File	Mode	Size
.circleci
.github
aio
docs
integration
modules
packages
scripts
tools
.bowerrc	-rw-r--r--	39 bytes
.clang-format	-rw-r--r--	73 bytes
.editorconfig	-rw-r--r--	244 bytes
.gitattributes	-rw-r--r--	240 bytes
.gitignore	-rw-r--r--	426 bytes
.mailmap	-rw-r--r--	51 bytes
.nvmrc	-rw-r--r--	7 bytes
.pullapprove.yml	-rw-r--r--	14.5 KB
.travis.yml	-rw-r--r--	2.8 KB
BUILD.bazel	-rw-r--r--	1.3 KB
CHANGELOG.md	-rw-r--r--	345.3 KB
CODE_OF_CONDUCT.md	-rw-r--r--	1.1 KB
CONTRIBUTING.md	-rw-r--r--	13.2 KB
LICENSE	-rw-r--r--	1.1 KB
README.md	-rw-r--r--	1.8 KB
WORKSPACE	-rw-r--r--	4.7 KB
bower.json	-rw-r--r--	89 bytes
browser-providers.conf.js	-rw-r--r--	10.0 KB
build.sh	-rwxr-xr-x	17.8 KB
gulpfile.js	-rw-r--r--	1.8 KB
index.bzl	-rw-r--r--	1.1 KB
karma-js.conf.js	-rw-r--r--	5.7 KB
package.json	-rw-r--r--	4.8 KB
protractor-e2e.conf.js	-rw-r--r--	1.3 KB
protractor-examples-e2e.conf.js	-rw-r--r--	1.2 KB
protractor-perf.conf.js	-rw-r--r--	2.1 KB
shims_for_IE.js	-rw-r--r--	117.0 KB
test-events.js	-rw-r--r--	262 bytes
test-main.js	-rw-r--r--	10.2 KB
test.sh	-rwxr-xr-x	1.1 KB
tslint.json	-rw-r--r--	1.1 KB
yarn.lock	-rw-r--r--	251.8 KB
yarn.lock.readme.md	-rw-r--r--	1.3 KB

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/angular/angular

fix(docs-infra): use correct parameters for paginated requests to GitHub (#25671)

README.md