Revision a123ef58b1bc9db4ec26fb9679f23bd383c1d9a3 authored by Andrew Scott on 23 July 2020, 22:53:46 UTC, committed by Misko Hevery on 25 July 2020, 01:02:49 UTC
There are a few changes in this PR to ensure conditions that are based
on groups (i.e. `- groups.pending.length == 0`) do not fail the verify
task:
* Remove the warning when a condition is encountered that depends on the
`groups` state. The warning will otherwise be printed once for every
file that triggers the execution of the condition (400,000+ times)
* Add an `unverifiable` flag to `GroupCondition` interface and set it to
true when an error is encountered due to attempting to get the state of
`groups` in a condition
* Ignore any unverifiable conditions when gathering unmatched
conditions. These should not be considered `unmatched` for verification
purposes.
* Print the unverifiable conditions by group in the results
Sample output:
```
┌──────────────────────────────────────────────────────────────────────────────┐
│ PullApprove results by group │
└──────────────────────────────────────────────────────────────────────────────┘
Groups skipped (4 groups)
Matched conditions by Group (37 groups)
Unmatched conditions by Group (0 groups)
Unverifiable conditions by Group (3 groups)
[public-api]
len(groups.pending.exclude("required-minimum-review")...
len(groups.rejected.exclude("required-minimum-review")...
[size-tracking]
len(groups.pending.exclude("required-minimum-review")...
len(groups.rejected.exclude("required-minimum-review")...
[circular-dependencies]
len(groups.pending.exclude("required-minimum-review")...
len(groups.rejected.exclude("required-minimum-review")...
```
PR Close #37798
1 parent 024126d
| File | Mode | Size |
|---|---|---|
| .circleci | ||
| .devcontainer | ||
| .github | ||
| .ng-dev | ||
| .vscode | ||
| .yarn | ||
| aio | ||
| dev-infra | ||
| docs | ||
| goldens | ||
| integration | ||
| modules | ||
| packages | ||
| scripts | ||
| third_party | ||
| tools | ||
| .bazelignore | -rw-r--r-- | 4.3 KB |
| .bazelrc | -rw-r--r-- | 6.5 KB |
| .bazelversion | -rw-r--r-- | 213 bytes |
| .clang-format | -rw-r--r-- | 73 bytes |
| .editorconfig | -rw-r--r-- | 245 bytes |
| .gitattributes | -rw-r--r-- | 314 bytes |
| .gitignore | -rw-r--r-- | 726 bytes |
| .gitmessage | -rw-r--r-- | 7.2 KB |
| .mailmap | -rw-r--r-- | 51 bytes |
| .nvmrc | -rw-r--r-- | 8 bytes |
| .pullapprove.yml | -rw-r--r-- | 43.8 KB |
| .yarnrc | -rw-r--r-- | 128 bytes |
| BUILD.bazel | -rw-r--r-- | 1.7 KB |
| CHANGELOG.md | -rw-r--r-- | 718.1 KB |
| CODE_OF_CONDUCT.md | -rw-r--r-- | 1.1 KB |
| CONTRIBUTING.md | -rw-r--r-- | 14.2 KB |
| LICENSE | -rw-r--r-- | 1.1 KB |
| README.md | -rw-r--r-- | 1.2 KB |
| WORKSPACE | -rw-r--r-- | 4.3 KB |
| browser-providers.conf.js | -rw-r--r-- | 8.9 KB |
| gulpfile.js | -rw-r--r-- | 1.2 KB |
| karma-js.conf.js | -rw-r--r-- | 7.6 KB |
| package.json | -rw-r--r-- | 8.2 KB |
| test-events.js | -rw-r--r-- | 259 bytes |
| test-main.js | -rw-r--r-- | 11.3 KB |
| tslint.json | -rw-r--r-- | 2.3 KB |
| yarn.lock | -rw-r--r-- | 674.8 KB |
| yarn.lock.readme.md | -rw-r--r-- | 1.3 KB |
Computing file changes ...
