Skip to main content

Browse the archive

Revision a177abef1b0a0edc46dcca2d8c5c67669c55ff8f authored by Andrew Scott on 18 April 2024, 16:33:15 UTC, committed by Andrew Kushnir on 25 April 2024, 16:06:39 UTC 
fix(core): render hooks should not specifically run outside the Angular zone (#55399)
 
The timing of render hook execution is almost entirely identical to
`ngZone.onMicrotaskEmpty`. Developers working towards zoneless
compatibility will need to migrate `onMicrotaskEmpty` calls to use
`afterNextRender`/`afterRender` instead. This, however, would lead to
confusing issues if there are promises in the callbacks because
`onMicrotaskEmpty` emits inside the Angular zone while render hooks
execute outside today. This is problematic because it's not documented
and does not produce any notification or error message when async work
is done inside the hooks that requires change detection. Instead, change detection
simply does not run, and this behavior has proven to be surprising to
developers who are used to ZoneJS change detection behavior.

fixes #55299

PR Close #55399
1 parent a5c57c7
Raw File
.clang-format 
Language:        JavaScript
BasedOnStyle:    Google
ColumnLimit:     100
back to top