| a25ba7c | Danilo Piparo | 30 January 2024, 08:13:32 UTC | "Update ROOT version files to v6.28/12." | 30 January 2024, 08:13:32 UTC |
| 2c56d61 | Danilo Piparo | 30 January 2024, 08:07:30 UTC | [relnotes] Update for 6.28/12. | 30 January 2024, 08:07:30 UTC |
| d1fb58e | Danilo Piparo | 30 January 2024, 07:33:55 UTC | [NFC] Spelling | 30 January 2024, 07:33:55 UTC |
| 1233eb0 | Sergey Linev | 19 January 2024, 08:27:39 UTC | [tbrowser] check web canvas creation Allow to create web-based canvas only if web display is enabled. It only can happen programmatically | 29 January 2024, 20:05:00 UTC |
| 7a7abc6 | Sergey Linev | 30 November 2023, 10:18:58 UTC | [http] disable default webgui page There was simple lists of windows. Even now it is not possible connect them - just forbid this | 29 January 2024, 20:05:00 UTC |
| 939f603 | Sergey Linev | 13 December 2023, 09:02:04 UTC | [webgui] secure arguments for http server creation Prevent possibility to provide extra (potentially dangerous) arguments to creation of engines in http server | 29 January 2024, 20:05:00 UTC |
| 9cc8c39 | Sergey Linev | 07 December 2023, 08:51:21 UTC | [rbrowser] do not allow reconnect | 29 January 2024, 20:05:00 UTC |
| a7ad984 | Sergey Linev | 06 December 2023, 07:28:32 UTC | [http] do not expose current dir for webgui webgui uses THttpServer with limited functionality. Normally files from current directory can be read via THttpServer, but not in case of webgui where it opens potential security problem | 29 January 2024, 20:05:00 UTC |
| bf51a3b | Sergey Linev | 06 December 2023, 16:48:58 UTC | [webgui] RWebWindowsManager::SetLoopbackMode() Introduce such method to let switch it off - for very special cases. | 29 January 2024, 20:05:00 UTC |
| 9694b7e | Sergey Linev | 07 December 2023, 12:52:24 UTC | Provide initializer for TROOT web display flags | 29 January 2024, 19:54:54 UTC |
| 99cb5b3 | Sergey Linev | 07 December 2023, 12:47:52 UTC | Disable rc parameter for web based tree viewer If in rootrc file web-based tree viewer stored and web mode is not active, it will be disabled with warning message | 29 January 2024, 19:54:54 UTC |
| 59721fd | Sergey Linev | 06 December 2023, 16:31:12 UTC | Let start web browser only in web mode | 29 January 2024, 19:54:54 UTC |
| 2f55c4e | Sergey Linev | 06 December 2023, 16:30:36 UTC | Do not create web canvas and browser from rootrc Handling in normal TRootGuiFactory, where normal classes are created as well | 29 January 2024, 19:54:54 UTC |
| 4a62f69 | Sergey Linev | 06 December 2023, 16:30:02 UTC | Do not create web browser from rootrc without web | 29 January 2024, 19:54:54 UTC |
| 150c1bd | Sergey Linev | 06 December 2023, 16:29:11 UTC | Disable WebGui.Display rootrc parameter | 29 January 2024, 19:54:54 UTC |
| 68c03c1 | Sergey Linev | 06 December 2023, 16:28:41 UTC | Disable --web args for TApplication | 29 January 2024, 19:54:54 UTC |
| 3a028d5 | Danilo Piparo | 26 January 2024, 07:34:36 UTC | [Core] Change logo date from 2023 to 2024 | 26 January 2024, 07:45:42 UTC |
| ebb702f | Bertrand Bellenot | 25 January 2024, 08:01:20 UTC | [v6-28][core][backport] Fix random crashes on Windows Fix random crashes of the `imt101_parTreeProcessing` tutorial on Windows | 25 January 2024, 11:20:30 UTC |
| 4fe40a6 | Olivier Couet | 25 January 2024, 09:17:17 UTC | Remove matomo code (#14431) | 25 January 2024, 09:17:17 UTC |
| 19eff09 | Vincenzo Eduardo Padulano | 16 January 2024, 20:49:44 UTC | [core] Fix statements at global scope in TCling test `TInterpreter::Declare` does not support issuing statements on the global scope, while `TInterpreter::ProcessLine` does. This test was first introduced in a development version of ROOT (6.31), where the upgrade to LLVM16 was already in place. In that scenario, clang supports global scope statements (thanks to changes made for clang-repl). Applying the test to ROOT 6.30 uncovered the problem, since the clang of LLVM13 does not support global scope statements. Fix the test by using `ProcessLine` instead of `Declare` which does the intended thing independently from the ROOT version. Co-authored-by: Vassil Vassilev <vasil.georgiev.vasilev@cern.ch> | 24 January 2024, 20:09:02 UTC |
| 943e821 | Vincenzo Eduardo Padulano | 08 January 2024, 10:53:20 UTC | [core] Make some constants constexpr This allows us to avoid generating symbols in libCore for these constants keeping the same amount of open calls at ROOT startup time. | 24 January 2024, 20:09:02 UTC |
| 4afc72e | Vassil Vassilev | 08 January 2024, 10:21:54 UTC | [core] Prefer variable initializer over symbol search Symbol lookup is a quite expensive operation and might result in JIT compilation and library loading. Co-authored-by: Jonas Hahnfeld <jonas.hahnfeld@cern.ch> | 24 January 2024, 20:09:02 UTC |
| 9d068f9 | Vassil Vassilev | 08 January 2024, 10:21:54 UTC | [core] Evaluate initializer of constant variables Co-authored-by: Jonas Hahnfeld <jonas.hahnfeld@cern.ch> | 24 January 2024, 20:09:02 UTC |
| 71bf80e | Vassil Vassilev | 08 January 2024, 10:21:54 UTC | [core] Reduce symbol search only to when autoloading is enabled. The llvm9 JIT issued callbacks when a symbol was missing and we reacted on it by loading the relevant library. In root-project/root@9b2041e3 we have kept the logic but now the JIT started querying more often even for symbols which are okay to be missing. In turn that leads to scanning all libraries causing performance issues. This patch tries to limit this functionality only in contexts where automatic loading is allowed. | 24 January 2024, 20:09:02 UTC |
| 9b126d2 | moneta | 06 October 2023, 11:22:30 UTC | [tmva] Fix dependency and speed-up TMVA_CNN and TMVA_RNN tutorials | 22 January 2024, 09:35:10 UTC |
| c99b924 | Philippe Canal | 11 December 2023, 10:05:06 UTC | Core: Add missing typeid name demangling | 19 January 2024, 22:53:38 UTC |
| 3d12501 | Philippe Canal | 08 December 2023, 20:55:20 UTC | Core: Avoid (indirect) memory hoarding in TPluginManager. This was reported at https://github.com/art-framework-suite/art/issues/142 and is due to the combination of (a) We do not generate dictionary for std::tuple instances (b) When TClass::GetClass is called it tries to load the dictonary until there is a full TClass object is in memory (c) The emulated std::tuple TClass are marked as 'not loaded' (d) Searching for the TClass for a templated class will cost memory (during the lookup of the instantiation). (e) TPluginManager::ExecPluginImpl was looking up the TClass for the typle `std::type< list of arguments>` The lookup induced in (e) in the user's case (root built with runtime cxx module on) lead to some memory allocation in Clang while trying to find out if there was now a library or dictionary to load. | 19 January 2024, 22:53:38 UTC |
| 72e02d1 | Vincenzo Eduardo Padulano | 19 December 2023, 17:14:16 UTC | [core] Materialize symbols for TError variables The variables present in TError.h are used throughout the ROOT libraries. Anytime one of these variables is requested, e.g. with a simple test such as `python -c "import ROOT; ROOT.kError"`, the interpreter will lookup the corresponding symbol. Previously, the variables were declared and defined in the header directly but were not generating any symbol since the linkage was internal. With this commit, provide external linkage to these variables so that the corresponding symbols are materialized in libCore.so. As a consequence, a huge number of extra lookups by cling is avoided. | 20 December 2023, 08:49:55 UTC |
| a42cc81 | Vincenzo Eduardo Padulano | 18 December 2023, 07:50:06 UTC | [core] Properly define TString::kNPOS data member according to standard C++ A declaration of a static data member *is not* also a definition, even if the data member is default-initialized in the class body. The definition must be explicitly written in one TU, which also ensures proper ODR use. See https://en.cppreference.com/w/cpp/language/definition. Co-authored-by: Jonas Hahnfeld <jonas.hahnfeld@cern.ch> | 19 December 2023, 13:13:10 UTC |
| 6587bb1 | Bertrand Bellenot | 14 December 2023, 08:10:32 UTC | Add a safety check on `std::multimap::empty()` Prevent a potential crash on Windows in Debug mode when the multimap is empty | 15 December 2023, 09:36:47 UTC |
| 6c58f17 | Bertrand Bellenot | 11 December 2023, 14:40:44 UTC | Use the correct parameter types for `NetLocalGroupEnum` and `NetLocalGroupGetMembers` | 13 December 2023, 16:31:47 UTC |
| 1766f21 | Jonas Hahnfeld | 24 November 2023, 13:39:34 UTC | [cling] DeclUnloader: Remove extra check isInstantiatedInPCH This effectively reverts commit 74472caaa9 ("[cling] Fixes issue in DeclUnloader: do not unload templates intantiated in the PCH"), it's not needed anymore, all tests pass and the snippet in the summary of https://github.com/root-project/root/pull/4447 works, but it filters too many declarations from the unloader. (cherry picked from commit 1c3ea0a068bc22eacf0dee087d8e3e2801b8018d) | 13 December 2023, 09:06:01 UTC |
| f12ae12 | Javier Lopez-Gomez | 29 August 2023, 14:43:05 UTC | [cling] DeclUnloader: do not delete instantiated member functions The body of member functions of a templated class only gets instantiated when the function is used. These `CXXMethodDecl` should not be deleted from the AST; instead return them to the 'instantiation pending' state. (cherry picked from commit afba1d737aeafd554ac4763fcc2d542de961be2a) | 13 December 2023, 09:06:01 UTC |
| 4571e1b | Javier Lopez-Gomez | 29 August 2023, 14:43:05 UTC | [cling] DeclUnloader: remove StaticVarCollector StaticVarCollector recursively visited descendants of a `FunctionDecl` node to collect static local variables. However, these always appear in the enclosing DeclContext. (cherry picked from commit bd28a5b793947c1b777edb376c35062da409281b) | 13 December 2023, 09:06:01 UTC |
| 95c304c | Javier Lopez-Gomez | 24 August 2023, 13:39:44 UTC | [cling] Fix unmatched `#pragma clang diagnostic push` Cherry-picked from 94c5c9e3d134fa69cfe14f6d731eeaf6a540b39c. | 13 December 2023, 09:06:01 UTC |
| 481fab3 | Javier Lopez-Gomez | 24 August 2023, 13:39:44 UTC | [cling][NFC] Move helper functions to anonymous namespace at the beginning Cherry-picked from fa2cacb4413fc43e8ea58c561e2d62bd43e22f5d. | 13 December 2023, 09:06:01 UTC |
| 5df8b8f | Sergey Linev | 30 November 2023, 13:07:47 UTC | [webgui] do not build without http | 01 December 2023, 07:14:29 UTC |
| ad63cee | Danilo Piparo | 27 November 2023, 20:46:05 UTC | "Update ROOT version files to v6.28/11." | 27 November 2023, 20:46:05 UTC |
| f7ba9bf | Danilo Piparo | 27 November 2023, 20:22:19 UTC | "Update ROOT version files to v6.28/10." | 27 November 2023, 20:42:22 UTC |
| c55f24b | Danilo Piparo | 27 November 2023, 19:21:20 UTC | [relnotes] Update for 6.28/10. | 27 November 2023, 19:21:20 UTC |
| 492215d | Sergey Linev | 27 November 2023, 15:55:36 UTC | [webgui] use classical browser by default | 27 November 2023, 18:21:55 UTC |
| 5434c69 | Sergey Linev | 27 November 2023, 12:12:47 UTC | [webgui] always use loopback Disregard of rootrc parameters always assign loopback. The only valid alternative - unix socket. FastCGI is also disabled for the moment; it is alternative to civetweb | 27 November 2023, 17:00:34 UTC |
| ba65f3b | Sergey Linev | 27 November 2023, 11:59:03 UTC | [webgui] change RBrowser warning | 27 November 2023, 17:00:34 UTC |
| 5bd09b7 | Sergey Linev | 23 November 2023, 10:16:40 UTC | [jsroot] 7.3.x 23/11/2023 Fix - draw histogram with only negative bins jsroot:#276 Fix - reading TLeaf with fixed-size array Fix - correctly set pave name jsroot:#278 | 23 November 2023, 16:51:41 UTC |
| 2735cc8 | Sergey Linev | 21 November 2023, 07:32:09 UTC | [webgui] use loopback by default Default value is on in C++ code, but was remained off in system.rootrc and over-rulling C++ | 21 November 2023, 17:02:07 UTC |
| 60f680f | Olivier Couet | 21 November 2023, 09:26:55 UTC | [v6-28] Backport Cocoa (#14020) * Fix Cocoa GUI for MacOS14 and clang5 * Fix the text editor (Thanks Timur !) | 21 November 2023, 09:26:55 UTC |
| 79424c0 | Sergey Linev | 31 October 2023, 08:49:28 UTC | [jsroot] 7.3.x 31/10/2023 1. Fix - correctly set visibility level for geo drawing 2. Fix - use more factor for number of nodes in geo drawing 3. Fix - add missing Chebyshev0 function 4. Fix - provide Gaus with normalization 5. Fix - call 3D rendering after adding TPolyLine3D 6. Fix - properly add interactive resize elements 7. Fix - drop handling on tabs layout 8. Fix - member-wise streaming of std::map #262 9. Fix - typo in expandItem 10. Fix - add missing import in RPavePainter 11. Fix - prevent drawing of empty TGraph 12. Fix - use semicolon in RH3 13. Fix - prevent zero division when drawing TGraph exclusion 14. Fix - draw th2 col bins with configured y bar 15. Fix - let handle derived classes from TH1/TH2 #269 16. Fix - add support of #mp symbol 17. Fix - support TMath::Sq() function 18. Fix - prevent drawing of empty TGraph | 31 October 2023, 11:53:52 UTC |
| 55a4c23 | Jonas Rembser | 28 October 2023, 13:02:10 UTC | [PyROOT] Fix typo in recent PyROOT commit `Metho_` -> `Method_` | 28 October 2023, 14:43:52 UTC |
| b3f6230 | Jonas Rembser | 23 October 2023, 19:40:30 UTC | [PyROOT] Add patch for commit that avoids failing CPython 3.12 assert | 28 October 2023, 14:43:52 UTC |
| 6a2341d | Jonas Rembser | 20 October 2023, 16:56:32 UTC | [PyROOT] Prevent functions from crashing due to Python 3.12 assert Since Python 3.12, in the implementation of 'classobject.h' the function PyMethod_GET_SELF performs an assert to check that the passed function argument is a method: ``` \#define _PyMethod_CAST(meth) \ (assert(PyMethod_Check(meth)), _Py_CAST(PyMethodObject*, meth)) [...] static inline PyObject* PyMethod_GET_SELF(PyObject *meth) { return _PyMethod_CAST(meth)->im_self; } ``` It's fair that the assert fails, because the Python type of `meth` in this context is not a `PyMethod_Type`, but the `CustomInstanceMethod_Type` from cppyy. However, as can be seen in the implementation of `CustomInstanceMethod_New`, the actual C++ type that implements this custom cppy type is just the regular `PyMethodObject`. Hence, this commit suggests new assert-free `CustomInstanceMethod_GET_*` macros that replace the `PyMethod_GET_*` macros in the context of the `CustomInstanceMethod` implementation. | 28 October 2023, 14:43:52 UTC |
| 0f8b06b | Pere Mato | 26 October 2023, 09:11:27 UTC | Make FindMySQL.cmake more tolerant | 27 October 2023, 14:32:03 UTC |
| a1297c3 | Sergey Linev | 26 October 2023, 07:19:53 UTC | [tbrowser] ensure that TCanvas created when web mode is not active In "classical" TBrowser one want to use normal TCanvas - even if rootrc configured differently. Therefore change gEnv values for the time when canvas is created | 26 October 2023, 13:36:23 UTC |
| bf3e7b5 | Vincenzo Eduardo Padulano | 24 October 2023, 14:30:01 UTC | [PyROOT] Fix distributed RDataFrame tests due to error serialization This commit enables serialization of the Python proxy defined within cppyy to the C++ std::runtime_error class. By doing so, we avoid errors that happen in certain configurations of Dask tasks where a std::runtime_error may be thrown within the event loop itself. Recent CI failures report the following: ``` RDataFrame::Run: event loop was interrupted Warning in <TBufferFile::WriteObjectAny>: since runtime_error has no public constructor which can be called without argument, objects of this class can not be read with the current library. You will need to add a default constructor before attempting to read it. Warning in <TStreamerInfo::Build>: runtime_error: base class exception has no streamer or dictionary it will not be saved Warning in <TStreamerInfo::Build>: runtime_error: __cow_string has no streamer or dictionary, data member "_M_msg" will not be saved Error in <TClass::New>: cannot create object of class runtime_error Error in <TBufferFile::ReadObject>: could not create object of class runtime_error *** Break *** segmentation violation ``` This is due to the fact that for some reason the std::runtime_error object is serialized at the end of the function scope within the Dask task. The culprit is the [tblib](https://github.com/ionelmc/python-tblib) Python package, a dependency of Dask. Its most recent version (3.0.0) released on October 22th changes the pickling behaviour of exception objects, which is now evidently more enforced than before. Downgrading to previous versions of tblib make the errors above disappear in the distributed RDataFrame tests. | 25 October 2023, 07:24:55 UTC |
| 919f224 | Danilo Piparo | 04 October 2023, 09:17:39 UTC | [PyROOT] Speedup inclusion of ROOT module by removing invocations to the root-config executable. This executable was invoked twice to check if RDataFrame was available. Such a behaviour causes a severe slowdown, especially on cvmfs. This has been replaced by a simple string comparison. Backport of 4c863d | 22 October 2023, 05:33:30 UTC |
| 08b1d43 | Jonas Hahnfeld | 13 October 2023, 14:36:42 UTC | [clang] Fix crash with constexpr destructor Fixes https://github.com/root-project/root/issues/13851 See also https://github.com/llvm/llvm-project/issues/68702 (cherry picked from commit 0919a5359eefda0fc9e56a3198da21596114d62f) | 18 October 2023, 09:32:54 UTC |
| ebb1810 | Bertrand Bellenot | 03 October 2023, 10:56:43 UTC | Add the `TWebFile::Close(Option_t *option)` method This is needed to properly close and delete the socket when closing the file in `TROOT::CloseFiles()`, preventing a potential issue when trying to close the socket afterwards | 17 October 2023, 07:01:38 UTC |
| 96ca920 | Danilo Piparo | 13 October 2023, 09:55:24 UTC | "Update ROOT version files to v6.28/09." | 13 October 2023, 09:55:24 UTC |
| 2300fd7 | Danilo Piparo | 13 October 2023, 09:32:17 UTC | "Update ROOT version files to v6.28/08." | 13 October 2023, 09:32:17 UTC |
| 63d71a4 | Danilo Piparo | 13 October 2023, 09:26:13 UTC | [relnotes] Update for 6.28/08. | 13 October 2023, 09:26:13 UTC |
| 11e5ff0 | Philippe Canal | 18 May 2023, 18:04:45 UTC | IO: Use the skipping StreamerInfo record optimization also in single threaded code. Skip the StreamerInfo record process saves CPU time in all cases | 11 October 2023, 16:06:49 UTC |
| 7db6d51 | Philippe Canal | 18 May 2023, 17:47:06 UTC | IO: Fix StreamerInfo record write during file update. Fix #12783 Since "66dfb08bd7 - [IO] Do not process the streamerinfo record of a file if we read the si already read" which was extended in scope by "7cf9d5dc8c - fix hashing of streamer info," if a file is opened in update mode and the reading of its `StreamerInfo` record is skip (but an identical record was already read) *and* some data is stored in the file, the new `StreamerInfo` record written was missing all the classes in the original record that were not used during the update. To resolve this we record not only the fact that the record has been read and process but also its content (via a collectin of uid of the `TStreamerInfo` objects). Upon skipping the `StreamerInfo` record, we now mark of its `TStreamerInfo` objects has been used by the file (and thus upon writing the record is complete). This behavior was seen #12783 due an awkward 'create, fill, close, update immediately' cycle for a couple of files. | 11 October 2023, 16:06:49 UTC |
| 7bc2aab | Danilo Piparo | 10 October 2023, 13:57:41 UTC | [TMVA] Work around warning about unused variables in non-debug builds. | 10 October 2023, 18:56:33 UTC |
| 45a42a0 | Attila Krasznahorkay | 08 December 2022, 09:28:55 UTC | Made the test build against the build directory set CMAKE_PREFIX_PATH correctly. So that headers/libraries in the build directory could be found correctly. | 09 October 2023, 20:13:01 UTC |
| 1f21d60 | Attila Krasznahorkay | 06 December 2022, 10:21:37 UTC | Fixed how VDT would be used. Switched to using the VDT::VDT imported target to set up the build of ROOTVecOps, RooBatchCompute and TMVA. Then made all the necessary changes in SearchInstalledSoftware.cmake to make that work. | 09 October 2023, 20:13:01 UTC |
| 7da0d29 | Danilo Piparo | 07 October 2023, 06:28:09 UTC | [CMake] Update Vc version to 1.4.4 | 08 October 2023, 05:23:04 UTC |
| 15d5663 | Vincenzo Eduardo Padulano | 06 October 2023, 15:10:01 UTC | [cppyy] Add gSetItem to PyStrings This commit is taken partly from enable initialization of std::map from dict: https://github.com/wlav/CPyCppyy/commit/a43cb38cf2c10d668760a937f308fb1f1807d0aa And is needed in preparation of the changes related to https://github.com/root-project/root/issues/13410 | 07 October 2023, 12:00:00 UTC |
| 27c7540 | Vincenzo Eduardo Padulano | 06 October 2023, 14:54:08 UTC | [cppyy] Fix derived overload visibility This commit is in spirit equal to the sum of * cover more iterator protocol use cases: https://github.com/wlav/CPyCppyy/commit/48884a4f3b24211d6d1f748fadbf301a18c4731a * don't mix base and derived overloads: https://github.com/wlav/CPyCppyy/commit/ac926d910b31cd3e977a140bcdbf89818e553d47 Only for those changes that relate to issue https://github.com/root-project/root/issues/13410. | 07 October 2023, 12:00:00 UTC |
| be120ce | Vincenzo Eduardo Padulano | 27 September 2023, 14:04:41 UTC | [core] Add rpath on MacOS in compiledata.sh The generated compiler invocation in TSystem::CompileMacro doesn't add the `-rpath` option. The output of `root-config --libs` contains that option on MacOS, so we should also have it here. Extend the flags passed to the compiler defined in `compiledata.sh` so it gets generated at configuration time. This should fix errors seen in MacOS 14 when loading a shared library obtained via ACLiC. Co-authored-by: Philippe Canal <pcanal@fnal.gov> | 06 October 2023, 11:08:27 UTC |
| 0b2fc31 | moneta | 06 September 2023, 09:03:07 UTC | [tmva][pymva] Do not disable tensorflow eager execution on MacoS Disbaling it causes an interference with multiprocessing and a restart of the process after it is endeded. This fixes the timeout of the PyKeras tests on MacOS. This commits apply also some small fixes/improvements on the deletetion of some TMVA objects. (fir backport) remove bug in MethodBase.cxx in GetMvaValues introuduced in the original commit | 05 October 2023, 13:37:00 UTC |
| 354780c | moneta | 14 September 2023, 21:43:43 UTC | [tmva][pymva] Use less events on testPyKerasRegression Reduce number of events to avoid timeout of the test. Do this separtly for MAcOSX, since we cannot disable there eager execution | 04 October 2023, 10:38:31 UTC |
| 873863d | moneta | 06 September 2023, 09:26:15 UTC | [tmva][pymva] Fixes for latest version of scikit-learn | 04 October 2023, 10:38:31 UTC |
| fc7329b | moneta | 04 September 2023, 14:58:35 UTC | [tmva][sofie] Add dependency on sklearn for TMVA_SOFIE_Models tutorial | 04 October 2023, 10:38:31 UTC |
| 5d50559 | Jonas Hahnfeld | 03 October 2023, 15:03:11 UTC | [cling] Emit const variables only once Otherwise they are emitted as internal and we get double-construction and -destruction on the same memory address due to the way we promote internal declarations in KeepLocalGVPass. According to upstream tests, the de-duplication doesn't work on Windows (yet), but I think this problem is severe enough to fix it on the other platforms sooner rather than later. Fixes #13429 (cherry picked from commit 2dc57866c1d18010d3ebee681cc5e7777cd4d017) | 04 October 2023, 06:33:47 UTC |
| a561750 | Vincenzo Eduardo Padulano | 03 October 2023, 15:15:18 UTC | [df] Add regression test for #12043 | 03 October 2023, 20:54:52 UTC |
| f7d9db5 | Vincenzo Eduardo Padulano | 03 October 2023, 07:32:08 UTC | [df] Avoid clearing sample callbacks after event loop Sample callbacks can be registered by an RAction or an RDefinePerSample instance. In both cases, the lifetime of the callback is tied to the lifetime of the object itself. Avoid eager clearing of the callbacks so to not interfer with the normal functioning. | 03 October 2023, 20:54:52 UTC |
| e1b2cdf | Vincenzo Eduardo Padulano | 03 October 2023, 07:27:09 UTC | [df] Add RDefinePerSample to CMakeLists.txt | 03 October 2023, 17:14:01 UTC |
| e4a7739 | Sergey Linev | 30 June 2023, 15:15:24 UTC | [eve] Fix TGCompositeFrame flags - c++20 warnings | 03 October 2023, 01:13:13 UTC |
| 592fcb9 | Sergey Linev | 28 June 2023, 14:43:23 UTC | [treeplayer] fix compiler warnings concerning enum combination Messages like this: ``` tree/treeplayer/src/TFormLeafInfo.cxx: In member function ‘virtual Bool_t TFormLeafInfo::IsString() const’: tree/treeplayer/src/TFormLeafInfo.cxx:361:36: warning: arithmetic between different enumeration types ‘TStreamerInfo::EReadWrite’ and ‘EDataType’ is deprecated [-Wdeprecated-enum-enum-conversion] 361 | case TStreamerInfo::kOffsetL + kChar_t: | ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~ tree/treeplayer/src/TFormLeafInfo.cxx: In member function ‘T TFormLeafInfo::ReadValueImpl(char*, Int_t)’: tree/treeplayer/src/TFormLeafInfo.cxx:890:36: warning: arithmetic between different enumeration types ‘TStreamerInfo::EReadWrite’ and ‘EDataType’ is deprecated [-Wdeprecated-enum-enum-conversion] 890 | case TStreamerInfo::kOffsetL + kULong64_t: | ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~ ``` | 03 October 2023, 01:13:13 UTC |
| 4cc94a2 | moneta | 25 August 2023, 11:38:46 UTC | [pymva] Use back .h5 file format for PyKeras tests | 02 October 2023, 23:05:59 UTC |
| d36b1d4 | moneta | 24 August 2023, 14:07:42 UTC | [pymva] Refactor TestRModelParserPyTorch to use RSofieReader Make model generation, code generation and evaluation all in the test | 02 October 2023, 23:05:59 UTC |
| d2e7dd9 | moneta | 24 August 2023, 13:01:37 UTC | [pymva] Use .keras instead of .h5 for saving keras models From tensorflow 2.13 it is reccomended to use .keras for the saved keras files instead of .h5 | 02 October 2023, 23:05:59 UTC |
| b3b46b5 | Vincenzo Eduardo Padulano | 06 September 2023, 07:06:55 UTC | [TMVA] Remove dependency on torch.onnx submodule As seen in https://github.com/pytorch/pytorch/pull/82628. This removes the `TypeError: 'torch._C.Node' object is not subscriptable` error. | 02 October 2023, 19:52:12 UTC |
| e504110 | moneta | 24 August 2023, 08:58:11 UTC | [pymva] Fix again retrieval of tf/keras version | 02 October 2023, 19:52:12 UTC |
| 10d14cf | moneta | 24 August 2023, 08:33:23 UTC | [pymva] Fix retrieving Keras version when using new version of tensorflow With the latest tensorflow (2.13) tf.keras.__version__ is not existing anymore, oone needs to use tf.__version__ | 02 October 2023, 19:52:12 UTC |
| b70c442 | Danilo Piparo | 30 September 2023, 09:42:25 UTC | [CMake] Slightly refactor code to make it more readable. | 02 October 2023, 19:52:12 UTC |
| d1e18a1 | Danilo Piparo | 30 September 2023, 09:41:18 UTC | [TMVA] Remove Keras Regression test from the battery on Macos because it always fails due to the slowness of the tool on the platform. | 02 October 2023, 19:52:12 UTC |
| e3df232 | moneta | 26 September 2023, 15:48:54 UTC | [tmva] Make library libTMVAUtils | 02 October 2023, 19:52:12 UTC |
| 4ba37f9 | moneta | 25 September 2023, 11:00:12 UTC | [tmva] Veto tutorial/keras on macos Do not run in CI the tutorial/keras on macos because we cannot disable eager execution on tensorflow. This causes timeout in the tutorials | 02 October 2023, 19:52:12 UTC |
| 6c7086b | moneta | 25 September 2023, 10:54:36 UTC | [tmva] Remove direct dataframe dependency libTMVA does not need to depend explicitly on RDataFrame. It is used only in the template function AsTensor and in the header files of the BatchGenerator used from Python remove lib dependency | 02 October 2023, 19:52:12 UTC |
| 7d6384c | Danilo Piparo | 24 September 2023, 07:04:10 UTC | [TMVA] Do not run CNN tutorial if imt not specified if imt is not specified, this tutorial should not be run as a test. | 02 October 2023, 19:52:12 UTC |
| dbaaa1c | Bertrand Bellenot | 21 April 2023, 09:53:00 UTC | Unconditionally disable multiproc tests on Windows | 02 October 2023, 19:52:12 UTC |
| c3491bc | Sergey Linev | 03 July 2023, 06:30:31 UTC | [geombuilder] fix warning about enum mixing | 02 October 2023, 15:47:14 UTC |
| eb13f97 | Sergey Linev | 30 June 2023, 13:34:26 UTC | [tmva] fix capture warning from c++20 ``` tmva/tmva/src/Classification.cxx: In lambda function: tmva/tmva/src/Classification.cxx:265:23: warning: implicit capture of ‘this’ via ‘[=]’ is deprecated in C++20 [-Wdeprecated] 265 | auto executor = [=](UInt_t workerID) -> ClassificationResult { | ^ tmva/tmva/src/Classification.cxx:265:23: note: add explicit ‘this’ or ‘*this’ capture ``` | 02 October 2023, 15:47:14 UTC |
| 58f053f | Axel Naumann | 29 June 2023, 14:47:30 UTC | [tree,html] Fix C++20/GCC13 warnings (enum arithmetic, this capture): e.g. ``` bitwise operation between different enumeration types ‘TBranch::EStatusBits’ and ‘TBranchElement::EStatusBits’ is deprecated [-Wdeprecated-enum-enum-conversion] ``` ``` implicit capture of ‘this’ via ‘[=]’ is deprecated in C++20 [-Wdeprecated] ``` | 02 October 2023, 15:47:14 UTC |
| df7c350 | Vincenzo Eduardo Padulano | 20 September 2023, 19:20:23 UTC | [io] Validate fList data member in TDirectory::RecursiveRemove | 01 October 2023, 16:47:38 UTC |
| cd26b14 | Vincenzo Eduardo Padulano | 21 September 2023, 06:51:33 UTC | [io] Do not initialize gROOT in TDirectory destructor | 01 October 2023, 16:47:38 UTC |
| a8bf5ca | Vincenzo Eduardo Padulano | 21 September 2023, 06:57:28 UTC | Add unittest for TDirectoryFile destructor With the reproducer described in https://github.com/root-project/root/issues/13691. The test *must* link to some library that is not automatically ignored when loading PCMs in TCling::RegisterModule in order to trigger the segfault. | 01 October 2023, 16:47:38 UTC |
| 7f038a1 | Danilo Piparo | 29 September 2023, 12:17:11 UTC | [CMake] Remove N-1 identical link statements of the libxxhash.a library when building libCore.so | 30 September 2023, 09:52:11 UTC |
| 88edada | Jonas Rembser | 03 April 2023, 10:38:11 UTC | [core] Remove some `mm*.c` in core/clib These files are unused and can be removed. This should fix this warning in the ROOT nightlies on the mac13 node: ``` core/clib/src/mmtrace.c:32:14: warning: a function declaration without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype] extern char *getenv (); ``` https://lcgapp-services.cern.ch/root-jenkins/view/ROOT%20Nightly/job/root-nightly-master/LABEL=mac13,SPEC=cxx20,V=master/lastBuild/parsed_console/ | 30 September 2023, 09:51:59 UTC |
| 3df96a5 | Mattias Ellert | 25 September 2023, 04:25:54 UTC | Remove ELISPDIR - nothing is installed in it anymore | 28 September 2023, 11:11:43 UTC |
