https://github.com/torvalds/linux
Revision a25ce4270bfdd522207b02f81a594c7d1746b697 authored by Kaike Wan on 17 June 2017, 17:37:26 UTC, committed by Doug Ledford on 20 July 2017, 15:20:50 UTC
Current computation of qp->timeout_jiffies in rvt_modify_qp() will cause
overflow due to the fact that the input to the function usecs_to_jiffies
is only 32-bit ( unsigned int). Overflow will occur when attr->timeout is
equal to or greater than 30. The consequence is unnecessarily excessive
retry and thus degradation of the system performance.

This patch fixes the problem by limiting the input to 5-bit and calling
usecs_to_jiffies() before multiplying the scaling factor.

Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Kaike Wan <kaike.wan@intel.com>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
1 parent 266098b
History
Tip revision: a25ce4270bfdd522207b02f81a594c7d1746b697 authored by Kaike Wan on 17 June 2017, 17:37:26 UTC
IB/rdmavt: Setting of QP timeout can overflow jiffies computation
Tip revision: a25ce42

back to top