Revision - a2b1f94 - disable irinterp for interpreters with `may_optimize(...)=false` - origin: https://github.com/JuliaLang/julia

visit type:

https://github.com/JuliaLang/julia

19 April 2024, 06:28:37 UTC

Revision a2b1f94ce2fae805920bcc4aa07d801d38cb89e0 authored by Shuhei Kadowaki on 04 March 2024, 01:08:35 UTC, committed by Jameson Nash on 04 March 2024, 16:50:48 UTC

disable irinterp for interpreters with `may_optimize(...)=false`

As discussed at <https://github.com/JuliaLang/julia/commit/b8a0a3978ccf163ce8fc371a4882547dc1271d53#commitcomment-139076159>,
currently external abstract interpreter that configures `may_optimize`
to return `false` may end up with the internal error from irinterp since
it fundamentally required optimized IR but it currently assumes that all
sources from cached `CodeInstance`s are optimized.

This commit addresses the issue by incorporating a `may_optimize` check
in `concrete_eval_eligible`, which in turn automatically disables
irinterp for such interpreters. Although there were earlier discussions
suggesting the revival of `codeinfo.inferred::Bool`, this commit does
not need it, and I think this approach maintains the current state more
cleanly.

1 parent c0a93f8

Files
Changes

Permalinks

Tip revision: a2b1f94ce2fae805920bcc4aa07d801d38cb89e0 authored by Shuhei Kadowaki on 04 March 2024, 01:08:35 UTC
disable irinterp for interpreters with `may_optimize(...)=false`

Tip revision: a2b1f94

File	Mode	Size
.devcontainer
.github
base
cli
contrib
deps
doc
etc
src
stdlib
test
.buildkite-external-version	-rw-r--r--	5 bytes
.clang-format	-rw-r--r--	3.3 KB
.clangd	-rw-r--r--	114 bytes
.codecov.yml	-rw-r--r--	52 bytes
.git-blame-ignore-revs	-rw-r--r--	371 bytes
.gitattributes	-rw-r--r--	65 bytes
.gitignore	-rw-r--r--	571 bytes
.mailmap	-rw-r--r--	12.7 KB
CITATION.bib	-rw-r--r--	513 bytes
CITATION.cff	-rw-r--r--	940 bytes
CONTRIBUTING.md	-rw-r--r--	23.4 KB
HISTORY.md	-rw-r--r--	372.8 KB
LICENSE.md	-rw-r--r--	1.3 KB
Make.inc	-rw-r--r--	56.1 KB
Makefile	-rw-r--r--	30.2 KB
NEWS.md	-rw-r--r--	12.5 KB
README.md	-rw-r--r--	7.4 KB
THIRDPARTY.md	-rw-r--r--	3.9 KB
VERSION	-rw-r--r--	11 bytes
julia.spdx.json	-rw-r--r--	37.8 KB
pkgimage.mk	-rw-r--r--	7.1 KB
sysimage.mk	-rw-r--r--	4.2 KB
typos.toml	-rw-r--r--	78 bytes

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/JuliaLang/julia

disable irinterp for interpreters with `may_optimize(...)=false`

README.md