https://github.com/torvalds/linux
Revision a46f9484f8926aacb2e79a0e1676de3a6a6fbae8 authored by Zach Brown on 04 July 2006, 09:57:52 UTC, committed by Linus Torvalds on 04 July 2006, 17:24:57 UTC
mthca: initialize send and receive queue locks separately
lockdep identifies a lock by the call site of its initialization. By
initializing the send and receive queue locks in mthca_wq_init() we confuse
lockdep. It warns that that the ordered acquiry of both locks in
mthca_modify_qp() is recursive acquiry of one lock:
=============================================
[ INFO: possible recursive locking detected ]
---------------------------------------------
modprobe/1192 is trying to acquire lock:
(&wq->lock){....}, at: [<f892b4db>] mthca_modify_qp+0x60/0xa7b [ib_mthca]
but task is already holding lock:
(&wq->lock){....}, at: [<f892b4ce>] mthca_modify_qp+0x53/0xa7b [ib_mthca]
Initializing the locks separately in mthca_alloc_qp_common() stops the
warning and will let lockdep enforce proper ordering on paths that acquire
both locks.
Signed-off-by: Zach Brown <zach.brown@oracle.com>
Cc: Roland Dreier <rolandd@cisco.com>
Cc: Arjan van de Ven <arjan@linux.intel.com>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
1 parent dd8041f
Tip revision: a46f9484f8926aacb2e79a0e1676de3a6a6fbae8 authored by Zach Brown on 04 July 2006, 09:57:52 UTC
[PATCH] mthca: initialize send and receive queue locks separately
[PATCH] mthca: initialize send and receive queue locks separately
Tip revision: a46f948
| File | Mode | Size |
|---|---|---|
| Documentation | ||
| arch | ||
| block | ||
| crypto | ||
| drivers | ||
| fs | ||
| include | ||
| init | ||
| ipc | ||
| kernel | ||
| lib | ||
| mm | ||
| net | ||
| scripts | ||
| security | ||
| sound | ||
| usr | ||
| .gitignore | -rw-r--r-- | 462 bytes |
| COPYING | -rw-r--r-- | 18.3 KB |
| CREDITS | -rw-r--r-- | 87.5 KB |
| Kbuild | -rw-r--r-- | 1.2 KB |
| MAINTAINERS | -rw-r--r-- | 69.5 KB |
| Makefile | -rw-r--r-- | 45.4 KB |
| README | -rw-r--r-- | 16.2 KB |
| REPORTING-BUGS | -rw-r--r-- | 3.0 KB |
Computing file changes ...
