Skip to main content

Browse the archive

https://github.com/angular/angular
19 April 2024, 08:24:33 UTC
sort by:
Revision Author Date Message Commit Date
a491295 Andrew Scott 04 August 2021, 16:59:03 UTC release: cut the v12.1.5 release (#43044) 04 August 2021, 16:59:03 UTC
585b3de George Kalpakas 03 August 2021, 08:56:53 UTC build(docs-infra): upgrade cli command docs sources to 18b20d67b (#43025) Updating [angular#12.1.x](https://github.com/angular/angular/tree/12.1.x) from [cli-builds#12.2.x](https://github.com/angular/cli-builds/tree/12.2.x). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/0ab046223...18b20d67b): **Modified** - help/e2e.json PR Close #43025 04 August 2021, 15:59:53 UTC
6875d94 atscott 03 August 2021, 21:49:34 UTC Revert "refactor(ngcc): remove unused import (#42062)" (#43033) This reverts commit 42265cca1c0088b9623a94cfb4a39e9690e75234. PR Close #43033 03 August 2021, 22:38:58 UTC
3c3c2af atscott 03 August 2021, 21:49:25 UTC Revert "test(compiler-cli): clarify source-map expectations in compliance tests (#42062)" (#43033) This reverts commit 29f9888a985b14cf1025105baa1fd262c751cc10. PR Close #43033 03 August 2021, 22:38:58 UTC
b3466b9 atscott 03 August 2021, 21:49:21 UTC Revert "refactor(compiler): remove cyclic dependencies (#42062)" (#43033) This reverts commit 75855196e320022e79202ccaeb9be000da55b9eb. PR Close #43033 03 August 2021, 22:38:57 UTC
b90ce36 atscott 03 August 2021, 21:49:17 UTC Revert "refactor(compiler): support interpolation tokens when lexing markup (#42062)" (#43033) This reverts commit c8a46bfdcd5dac0044c4322a5b3967163056b339. PR Close #43033 03 August 2021, 22:38:57 UTC
57db29f atscott 03 August 2021, 21:49:13 UTC Revert "refactor(compiler): share `isQuote()` via `chars.ts` (#42062)" (#43033) This reverts commit 3d3b69ff81c593602b75ee8eec60b36ecc09c767. PR Close #43033 03 August 2021, 22:38:57 UTC
c34b02b atscott 03 August 2021, 21:49:09 UTC Revert "refactor(compiler): support interpolation tokens when lexing attribute values (#42062)" (#43033) This reverts commit c516e252fcb199f2f503db5dc6ce563a299da010. PR Close #43033 03 August 2021, 22:38:57 UTC
e01bc77 atscott 03 August 2021, 21:49:05 UTC Revert "refactor(compiler): support encoded entity tokens when lexing markup (#42062)" (#43033) This reverts commit 942b24d5ea5d36ad4e53ed435bda35a6ae6876c9. PR Close #43033 03 August 2021, 22:38:57 UTC
b54c076 atscott 03 August 2021, 21:49:01 UTC Revert "refactor(compiler): expose token parts in Text nodes (#42062)" (#43033) This reverts commit 8a54896a91512131fbfb0b3d2f5440aec792cbfd. PR Close #43033 03 August 2021, 22:38:56 UTC
a964666 atscott 03 August 2021, 21:48:56 UTC Revert "test(compiler): check `fullStart` source-span (#42062)" (#43033) This reverts commit 973f9b8d1957d5479f5813664d35fd445f38e525. PR Close #43033 03 August 2021, 22:38:56 UTC
8c660fb atscott 03 August 2021, 21:48:52 UTC Revert "fix(compiler): include leading whitespace in source-spans of i18n messages (#42062)" (#43033) This reverts commit f08516db09df64c075f273159a15f80c792c96f0. PR Close #43033 03 August 2021, 22:38:56 UTC
f55c1c9 atscott 03 August 2021, 21:48:49 UTC Revert "refactor(compiler): define interfaces for each lexer token (#42062)" (#43033) This reverts commit 9b3d4f5575bfccfbbfb943dc9689f3915dd63752. PR Close #43033 03 August 2021, 22:38:56 UTC
78f6d49 atscott 03 August 2021, 21:48:45 UTC Revert "test(compiler): check that the parser supports prematurely terminated interpolations (#42062)" (#43033) This reverts commit 11ebe21d0dc8d82970153007e780800c87a76021. PR Close #43033 03 August 2021, 22:38:56 UTC
e170b39 atscott 03 August 2021, 21:48:42 UTC Revert "refactor(compiler): use `===` rather than `==` in the ml_parser (#42062)" (#43033) This reverts commit 28b0c45fde59da35a797cbdcceba973dbbb497a4. PR Close #43033 03 August 2021, 22:38:56 UTC
402c7d0 atscott 03 August 2021, 21:48:20 UTC Revert "test(compiler): add a test for parsing multiline expressions in attributes (#42062)" (#43033) This reverts commit fe1265158051ec3a90945bbc199af8c271b52842. PR Close #43033 03 August 2021, 22:38:55 UTC
a036cb5 dario-piotrowicz 01 August 2021, 12:30:47 UTC docs: amend links in content-projection guide (#43009) PR Close #43009 02 August 2021, 22:36:52 UTC
3574e56 Pete Bacon Darwin 21 July 2021, 14:58:48 UTC test(compiler): add a test for parsing multiline expressions in attributes (#42062) This tests a scenario that was failing in an internal project. PR Close #42062 02 August 2021, 16:53:17 UTC
5f7b5dc Pete Bacon Darwin 01 July 2021, 10:19:39 UTC refactor(compiler): use `===` rather than `==` in the ml_parser (#42062) This is a simple tidy up commit to move to the more specific `===` comparison operator in the HTML lexer/parser. PR Close #42062 02 August 2021, 16:53:16 UTC
0d95581 Pete Bacon Darwin 17 June 2021, 17:06:33 UTC test(compiler): check that the parser supports prematurely terminated interpolations (#42062) Such interpolations turned up during internal testing at Google, so this commit adds a test to prevent regressions. PR Close #42062 02 August 2021, 16:53:16 UTC
11414d2 Pete Bacon Darwin 12 June 2021, 19:56:05 UTC refactor(compiler): define interfaces for each lexer token (#42062) These token interfaces will make it easier to reason about tokens in the parser and in specs. Previously, it was never clear what items could appear in the `parts` array of a token given a particular `TokenType`. Now, each token interface declares a labelled tuple for the parts, which helps to document the token better. PR Close #42062 02 August 2021, 16:53:16 UTC
82ca69d Pete Bacon Darwin 08 June 2021, 10:27:55 UTC fix(compiler): include leading whitespace in source-spans of i18n messages (#42062) Previously, the way templates were tokenized meant that we lost information about the location of interpolations if the template contained encoded HTML entities. This meant that the mapping back to the source interpolated strings could be offset incorrectly. Also, the source-span assigned to an i18n message did not include leading whitespace. This confused the output source-mappings so that the first text nodes of the message stopped at the first non-whitespace character. This commit makes use of the previous refactorings, where more fine grain information was provided in text tokens, to enable the parser to identify the location of the interpolations in the original source more accurately. Fixes #41034 PR Close #42062 02 August 2021, 16:53:16 UTC
1130b99 Pete Bacon Darwin 20 May 2021, 12:18:33 UTC test(compiler): check `fullStart` source-span (#42062) The tests were checking that the source-span of parsed HTML nodes were accurate, but they were not checking the span when it includes the "leading trivia", which are given by the `fullStart` rather than `start` location. PR Close #42062 02 August 2021, 16:53:16 UTC
25f4825 Pete Bacon Darwin 15 May 2021, 19:37:08 UTC refactor(compiler): expose token parts in Text nodes (#42062) When it was tokenized, text content is split into parts that can include interpolations and encoded entities tokens. To make this information available to downstream processing, this commit adds these tokens to the `Text` AST nodes, with suitable processing. PR Close #42062 02 August 2021, 16:53:15 UTC
9927888 Pete Bacon Darwin 14 May 2021, 17:53:17 UTC refactor(compiler): support encoded entity tokens when lexing markup (#42062) The lexer now splits encoded entity tokens out from text and attribute value tokens. Previously encoded entities would be decoded and the decoded value would be included as part of the text token of the surrounding text. Now the entities have their own tokens. There are two scenarios: text and attribute values. Previously the contents of `<div>Hello &amp; goodbye</div>` would be a single TEXT token. Now it will be three tokens: ``` TEXT: "Hello " ENCODED_ENTITY: "&", "&amp;" TEXT: " goodbye" ``` Previously the attribute value in `<div title="Hello &amp; goodbye">` would be a single text token. Now it will be three tokens: ``` ATTR_VALUE_TEXT: "Hello " ENCODED_ENTITY: "&", "&amp;" ATTR_VALUE_TEXT: " goodbye" ``` - ENCODED_ENTITY tokens have two parts: "decoded" and "encoded". - ENCODED_ENTITY tokens are always preceded and followed by either TEXT tokens or ATTR_VALUE_TEXT tokens, depending upon the context, even if they represent an empty string. The HTML parser has been modified to recombine these tokens to allow this refactoring to have limited effect in this commit. Further refactorings to use these new tokens will follow in subsequent commits. PR Close #42062 02 August 2021, 16:53:15 UTC
7d52f65 Pete Bacon Darwin 13 May 2021, 16:00:56 UTC refactor(compiler): support interpolation tokens when lexing attribute values (#42062) The lexer now splits interpolation tokens out from attribute value tokens. Previously the attribute value of `<div attr="Hello, {{ name}}">` would be a single token. Now it will be three tokens: ``` ATTR_VALUE_TEXT: "Hello, " ATTR_VALUE_INTERPOLATION: "{{", " name", "}}" ATTR_VALUE_TEXT: "" ``` - ATTR_VALUE_INTERPOLATION tokens have three parts, "start marker", "expression" and "end marker". - ATTR_VALUE_INTERPOLATION tokens are always preceded and followed by TEXT tokens, even if they represent an empty string. The HTML parser has been modified to recombine these tokens to allow this refactoring to have limited effect in this commit. Further refactorings to use these new tokens will follow in subsequent commits. PR Close #42062 02 August 2021, 16:53:15 UTC
3644ddf Pete Bacon Darwin 12 May 2021, 19:46:49 UTC refactor(compiler): share `isQuote()` via `chars.ts` (#42062) This function is general purpose and by moving it into the `chars.ts` file along with similar helpers, it can be reused in the lexer, for instance. PR Close #42062 02 August 2021, 16:53:15 UTC
543c626 Pete Bacon Darwin 11 May 2021, 16:03:38 UTC refactor(compiler): support interpolation tokens when lexing markup (#42062) The lexer now splits interpolation tokens out from text tokens. Previously the contents of `<div>Hello, {{ name}}<div>` would be a single text token. Now it will be three tokens: ``` TEXT: "Hello, " INTERPOLATION: "{{", " name", "}}" TEXT: "" ``` - INTERPOLATION tokens have three parts, "start marker", "expression" and "end marker". - INTERPOLATION tokens are always preceded and followed by TEXT tokens, even if they represent an empty string. The HTML parser has been modified to recombine these tokens to allow this refactoring to have limited effect in this commit. Further refactorings to use these new tokens will follow in subsequent commits. PR Close #42062 02 August 2021, 16:53:15 UTC
9a5d71c Pete Bacon Darwin 19 May 2021, 08:48:28 UTC refactor(compiler): remove cyclic dependencies (#42062) This commit removes 9 cycles in the dependency graph of the compiler code. PR Close #42062 02 August 2021, 16:53:15 UTC
4c64935 Pete Bacon Darwin 20 May 2021, 10:17:39 UTC test(compiler-cli): clarify source-map expectations in compliance tests (#42062) The compliance tests can check source-map segments against expectations encoded into the expectation files. Previously, the encoding of the expected segment was only delimited by whitespace, but this made it difficult to identify segments that started or ended with whitespace. Now these segment expectations are wrapped in double-quotes which makes it easier to read and understand the expectation files. PR Close #42062 02 August 2021, 16:53:14 UTC
72cef43 Pete Bacon Darwin 30 June 2021, 13:19:44 UTC refactor(ngcc): remove unused import (#42062) This import is not used in the file, so can be removed. PR Close #42062 02 August 2021, 16:53:14 UTC
688b164 Alex Rickabaugh 27 July 2021, 22:59:17 UTC refactor(bazel): extract function to patch fileNameToModuleName on host (#42974) This commit extracts the patching operation that adds `fileNameToModuleName` to the Angular compiler's `ts.CompilerHost` into a separate function, so that it can be invoked in other compilation flows besides the one outlined in `ngc-wrapped`. This is primarily needed for the xi18n operation in g3. PR Close #42974 30 July 2021, 16:29:43 UTC
8ba328a Paul Gschwendtner 29 July 2021, 18:59:31 UTC fix(dev-infra): browser archive rule should handle `.dmg` files (#42992) We recently reworked our browser archive extraction to happen at analysis time for better caching. This resulted in us breaking the extraction of macOS dmg files so that Firefox is currently not usable for local testing on macOS. We implement a similar special logic for `.dmg` files to what has been done within the Bazel webtesting rules. PR Close #42992 30 July 2021, 16:28:07 UTC
67a25b7 Nichola Alkhouri 29 July 2021, 07:18:19 UTC docs: Fix wrongly provided/Injected AnimalService (#42988) In the logical tree example which demonstrate the use of `@SkipSelf` and `@Host`, the provided and injected `AnimalService` are reversed. PR Close #42988 29 July 2021, 22:05:52 UTC
da35c04 Joe Martin 27 July 2021, 18:45:21 UTC docs: Add josmar-crwdstffng to contributors list. (#42972) Add josmar-crwdstffng to list in contributors.json. Add josephmmartin image file. PR Close #42972 28 July 2021, 22:56:01 UTC
4bafa85 Joey Perrott 28 July 2021, 19:17:19 UTC fix(dev-infra): ensure that building environment stamp fails silently (#42985) Previously when a failure occurred in part of building the environment stamp, the entire process errored. This should instead fail silently providing no value for the stamp. PR Close #42985 28 July 2021, 20:00:08 UTC
6ef06bb Joey Perrott 28 July 2021, 18:24:08 UTC release: cut the v12.1.4 release (#42981) PR Close #42981 28 July 2021, 18:34:19 UTC
c7e4f14 codebriefcase 29 June 2021, 15:18:21 UTC docs: include interpolations in the "What is Angular" example (#42702) Affected URL - https://angular.io/guide/what-is-angular#template Fixes #42665 PR Close #42702 28 July 2021, 17:53:33 UTC
9d6fdd0 Paul Gschwendtner 27 July 2021, 19:45:28 UTC feat(dev-infra): introduce release action for directly branching-off into RC (#42973) Introduces a new release action for cutting a release-action by directly moving the next release-train into the `release-candidate` phase. This allows the Angular team to release minor versions without needing to branch-off first into the feature-freeze phase. For minors this phase can be skipped. Switching into the feature-freeze phase beforehand as a workaround would have allowed for branching-off but has the downside that `target: minor` would no longer point to the branched-off release train (only `target: rc` would work then). PR Close #42973 28 July 2021, 17:50:24 UTC
5474f80 Dylan Hunn 27 July 2021, 17:25:49 UTC Revert "refactor(compiler-cli): add makeTemplateDiagnostic wrapper (#42937)" (#42971) This reverts commit bb5facbcd27575e8661ba0c905780d01bfd538a2. PR Close #42971 27 July 2021, 21:14:32 UTC
3e1657d George Kalpakas 22 July 2021, 15:42:19 UTC fix(docs-infra): notify `ErrorHandler` of `UnrecoverableState` errors (#42941) With this commit, the `ErrorHandler` is notified of ServiceWorker `UnrecoverableState` errors. The main purpose of this change is gathering info about the occurrence (and frequency) of such errors in Google analytics. PR Close #42941 27 July 2021, 16:23:15 UTC
6e55752 Andrew Scott 26 July 2021, 18:37:35 UTC ci: add atscott to fw-compiler reviewers (#42963) add atscott to fw-compiler reviewers PR Close #42963 27 July 2021, 16:22:50 UTC
0bf6ab4 Vladyslav 26 July 2021, 19:54:19 UTC docs: updated input-output page documentation content (#42964) PR Close #42964 27 July 2021, 16:22:20 UTC
bb5facb Daniel Trevino 22 July 2021, 21:18:04 UTC refactor(compiler-cli): add makeTemplateDiagnostic wrapper (#42937) Add a `makeTemplateDiagnostic` wrapper in the `TemplateTypeChecker`. This requiers less parameters to create template diagnostics, since the `TemplateTypeChecker` can get the templateId and mapping from it's scope with the `ts.ClassDeclartion`. The `TemplateTypeChecker` is often used to determine if a diagnostic should be produced, so it makes sense to have a function in it that helps create them. Refs #42966 PR Close #42937 27 July 2021, 01:00:46 UTC
77ae445 JoostK 16 July 2021, 21:58:50 UTC fix(compiler-cli): use correct module resolution context for absolute imports in .d.ts files (#42879) The compiler keeps track of how a declaration has been referenced using absolute module imports and from which path the absolute module should be resolved from. There was a bug in how the .d.ts metadata extraction would incorrectly use the .d.ts file itself as resolution context for symbols that had been imported using a relative module specifier. This could result in module resolution failures. For example, when extracting NgModule metadata from `/node_modules/lib/index.d.ts` that looks like ``` import {LibDirective} from './dir'; @NgModule({ declarations: [LibDirective], exports: [LibDirective], }) export class LibModule {} ``` and `/app.module.ts` that contains ``` import {LibModule} from 'lib'; @NgModule({ imports: [LibModule], }) export class AppModule {} ``` then `AppModule` would have recorded a reference to `LibModule` using the `'lib'` module specifier. When extracting the NgModule metadata from the `/node_modules/lib/index.d.ts` file the relative import into `./dir` should also be assumed to be importable from `'lib'` (according to APF where symbols need to be exported from a single entry-point) so the reference to `LibDirective` should have `'lib'` as absolute module specifier, but it would incorrectly have `/node_modules/lib/index.d.ts` as resolution context path. The latter is incorrect as `'lib'` needs to be resolved from `/app.module.ts` and not from within the library itself. Fixes #42810 PR Close #42879 26 July 2021, 20:17:45 UTC
0736882 Paul Gschwendtner 01 July 2021, 15:49:21 UTC build: remove ts-api-guardian from repository (#42735) This commit removes `ts-api-guardian` from the repository. We introduced a new tool for testing API signature that is part of the shared dev-infra package. The TS API guardian package will be deprecated for the public in favor of Microsoft's API extractor that has support for more parts of the syntax, such as alias exports. PR Close #42735 26 July 2021, 19:02:15 UTC
5cffdd0 Yuvaraj 19 July 2021, 08:08:31 UTC docs: fix the selector in component interaction guide (#42891) The selector for the `CountdownTimerComponent` is `app-countdown-timer` not `countdown-timer`. PR Close #42891 26 July 2021, 18:47:56 UTC
e8eb87f Teri Glover 14 July 2021, 22:25:01 UTC docs: Edits to remove jargon (#42861) PR Close #42861 24 July 2021, 00:12:51 UTC
ee1f824 Andrew Scott 22 July 2021, 19:02:59 UTC test(router): move computed state restoration tests to own file (#42933) To reduce the enormouse size of the integration.spec.ts file, move tests related to the computed state restoration to their own file. PR Close #42933 23 July 2021, 21:25:07 UTC
1e7644d Andrew Scott 22 July 2021, 19:01:38 UTC refactor(router): Ensure computed state restoration works for thrown errors (#42933) When `canceledNavigationResolution='computed'`, the `Router` needs to handle the cases where errors are thrown. Previously, the logic was not updated and would simply do a `replaceState` rather than determining where in the history we should move to restore the page/url from before the failed navigation. PR Close #42933 23 July 2021, 21:25:07 UTC
0b8f3a1 Joey Perrott 22 July 2021, 16:28:08 UTC ci: update pullapprove config to properly handle global approvals (#42929) Update the config to properly identify a global approval as approved rather than as no file matching based groups being matched. PR Close #42929 23 July 2021, 19:09:27 UTC
e242d1d Andrew Scott 22 July 2021, 19:19:44 UTC docs: Add import line to router event example for clarification (#42935) Without the `import {Event} from '@angular/router';`, the filter will not work because the type is understood as the native `Event`. Fixes #42920 PR Close #42935 23 July 2021, 19:06:35 UTC
772dbe8 Joey Perrott 22 July 2021, 19:15:50 UTC feat(dev-infra): include experimental version stamp in env stamps (#42934) Include the determined experimental version for stamping in the env stamps created for release and snapshot builds. PR Close #42934 23 July 2021, 17:37:09 UTC
065d263 George Kalpakas 23 July 2021, 12:00:52 UTC build(docs-infra): upgrade cli command docs sources to 0ab046223 (#42944) Updating [angular#12.1.x](https://github.com/angular/angular/tree/12.1.x) from [cli-builds#12.1.x](https://github.com/angular/cli-builds/tree/12.1.x). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/18bbd044d...0ab046223): **Modified** - help/generate.json PR Close #42944 23 July 2021, 17:36:22 UTC
a69edc4 Renovate Bot 22 July 2021, 05:15:58 UTC build: update dependency globby to v12 (#42945) Update dependency `globby` to v12. PR Close #42945 23 July 2021, 17:35:30 UTC
246cdad George Kalpakas 22 July 2021, 13:37:34 UTC build(docs-infra): switch the `example-e2e` script to ESM (#42945) Switch the JS script used for running the docs examples tests from CommonJS to ESM format. This is necessary for upgrading the `globby` dependency to [version 12.0.0][1] in a subsequent commit. [1]: https://github.com/sindresorhus/globby/releases/v12.0.0 PR Close #42945 23 July 2021, 17:35:30 UTC
da0dabc George Kalpakas 22 July 2021, 11:38:18 UTC build(docs-infra): switch the `generate-stackblitz/zips` scripts to ESM (#42945) Switch the JS scripts used for generating StackBlitz projects and zips from CommonJS to ESM format. This is necessary for upgrading the `globby` dependency to [version 12.0.0][1] in a subsequent commit. [1]: https://github.com/sindresorhus/globby/releases/v12.0.0 PR Close #42945 23 July 2021, 17:35:30 UTC
c20103c Joey Perrott 21 July 2021, 23:39:44 UTC refactor(dev-infra): move semver utils into the utils directory (#42917) Move semver into the utils directory rather than as a set of utils specifically for release tooling. While the utils are only currently used in the release tooling, they are not providing a release specific utility and can be used by any subtool of ng-dev. PR Close #42917 22 July 2021, 18:01:19 UTC
11bc6ff Joey Perrott 21 July 2021, 23:36:52 UTC fix(dev-infra): fix creating experimental semver versions to include prerelease chunk (#42917) SemVers created for experimental versions should also include the prerelease chunk (i.e. -next.3). PR Close #42917 22 July 2021, 18:01:18 UTC
c06516c Joey Perrott 21 July 2021, 23:17:17 UTC Revert "fix(dev-infra): perform actual npm login verification for wombot proxy (#42871)" (#42917) This reverts commit fd92a3e87f08253ac8d20d01bc726c7460bd9ec9. It turns out that wombot proxy will return who is logged in, but does so regardless of if the users token is currently active. Since we cannot rely on `npm whoami` to determine the login state, we revert to our previous state of assuming new login is needed. PR Close #42917 22 July 2021, 18:01:18 UTC
268ba5c Pete Bacon Darwin 21 July 2021, 13:07:37 UTC ci: fix typo in docs-bug issue template (#42908) "browser specific" should be replaced with "browser-specific" because it's a compound modifier (cf. https://en.wikipedia.org/wiki/Compound_modifier). See #42906 PR Close #42908 22 July 2021, 16:25:40 UTC
dda23b9 Pete Bacon Darwin 21 July 2021, 13:06:10 UTC docs: fix spacing in code style guide (#42908) Fixes #42906 PR Close #42908 22 July 2021, 16:25:40 UTC
c2d3f60 Teri Glover 21 July 2021, 05:01:39 UTC docs: Edits to remove jargon (#42907) PR Close #42907 22 July 2021, 16:24:16 UTC
f589b01 JoostK 12 June 2021, 14:46:24 UTC perf(compiler-cli): skip analysis in incremental builds for files without Angular behavior (#42562) In an incremental rebuild, the compiler attempts to reuse as much analysis data from a prior compilation as possible to avoid doing the analysis work again. For source files without Angular behavior however, no analysis data would be recorded such that the source file had to be reanalyzed each rebuild, even if it has not changed. This commit avoids the analysis of such source files by registering these files as not containing any Angular behavior; allowing subsequent rebuilds to avoid the analysis work. PR Close #42562 21 July 2021, 22:40:39 UTC
a779a10 George Kalpakas 20 July 2021, 09:25:57 UTC fix(core): correctly handle `null` or `undefined` in `ErrorHandler#handleError()` (#42881) Since `ErrorHandler#handleError()` expects an argument of type `any` it should be able to handle values such as `null` and `undefined`. Previously, it failed to handle these values, because it was trying to access properties on them. This commit fixes it by ensuring no properties are accessed on `null` or `undefined` values. NOTE: This is part of fully addressing #28106. Fixes #21252 PR Close #42881 21 July 2021, 22:35:35 UTC
4307d6e Paul Gschwendtner 19 July 2021, 16:18:41 UTC ci: no longer use deprecated `pullapprove_conditions` option (#42895) PullApprove deprecated the `pullapprove_conditions` config option and introduced the `overrides` option. This commit migrates to the new option, while also eliminating the `fallback` group with a simple override (as per recommendation from the pull approve docs). PR Close #42895 21 July 2021, 22:34:25 UTC
879bf22 Joey Perrott 27 May 2021, 19:04:39 UTC refactor(dev-infra): remove usages and dependency on shelljs (#42911) Remove usages of shelljs and instead use spawn/spawnSync. PR Close #42911 21 July 2021, 22:33:38 UTC
b3328a9 Joey Perrott 03 June 2021, 17:54:36 UTC refactor(dev-infra): add spawnSync to child process utils, normalize naming of child-process utils (#42911) Create a `spawnSync` command for common usage, additionally update naming to use `spawn` instead of `spawnWithDebugOutput` PR Close #42911 21 July 2021, 22:33:38 UTC
b0854e2 Alex Rickabaugh 21 July 2021, 21:31:12 UTC release: cut the v12.1.3 release (#42914) PR Close #42914 21 July 2021, 21:32:51 UTC
29f5097 George Kalpakas 20 July 2021, 09:36:26 UTC fix(docs-infra): fix keyword color in CLI pages code blocks (#42889) Previously, names of CLI commands that also happened to be keywords were shown in black color in the code block demonstrating the command's usage. This worked fine when in light mode (where the code block background is white) but not in the recently introduced dark mode (where the code block background is dark gray). This commit fixes this by ensuring the `.kwd` token color is inherited from its parent (which has an appropriate color for the current theme). Previously, the `.kwd` token was reset to its initial value (which is `black` regardless of the theme). **Before:** ![CLI pages keyword before][1] **After:** ![cli-pages-keyword after][2] [1]: https://user-images.githubusercontent.com/8604205/126073803-af317f0c-d04f-4c3a-9a83-e92541d7dd5a.png [2]: https://user-images.githubusercontent.com/8604205/126073806-1d57e3ed-90b1-4735-ae2a-d0a39862bb95.png PR Close #42889 20 July 2021, 18:56:34 UTC
d207ea0 JoostK 17 July 2021, 20:50:03 UTC fix(compiler-cli): use correct module import for types behind a `forwardRef` (#42887) The static interpreter assumed that a foreign function expression would have to be imported from the absolute module specifier that was used for the foreign function itself. This assumption does not hold for the `forwardRef` foreign function resolver, as that extracts the resolved expression from the function's argument, which is not behind the absolute module import of the `forwardRef` function. The prior behavior has worked for the typical usage of `forwardRef`, when it is contained within the same source file as where the static evaluation started. In that case, the resulting reference would incorrectly have an absolute module guess of `@angular/core`, but the local identifier emit strategy was capable of emitting the reference without generating an import using the absolute module guess. In the scenario where the static interpreter would first have to follow a reference to a different source that contained the `forwardRef` would the compilation fail. In that case, there is no local identifier available such that the absolute module emitter would try to locate the imported symbol from `@angular/core`. which fails as the symbol is not exported from there. This commit fixes the issue by checking whether a foreign expression occurs in the same source file as the call expression. If it does, then the absolute module specifier that was used to resolve the call expression is ignored. Fixes #42865 PR Close #42887 20 July 2021, 18:56:07 UTC
18e2dba Joey Perrott 16 July 2021, 00:06:15 UTC fix(dev-infra): use the version from package.json rather than tags (#42872) Use the version value from the primary package.json file rather than checking the branch for the latest semver tag. This allows for us to explictly create changelogs from the previous version to the new version. PR Close #42872 20 July 2021, 18:30:34 UTC
e31eaf8 Joey Perrott 20 July 2021, 00:04:38 UTC feat(dev-infra): update package version verification to allow for experimental version (#42898) The angular-cli repo publishes experimental versioned packages in addition to standard versioned packages. Both experimental and standard verions, based on the expected new version provided are treated as valid and correct. PR Close #42898 20 July 2021, 18:30:01 UTC
e6b7472 dario-piotrowicz 18 July 2021, 09:32:26 UTC build(docs-infra): improve @usageNotes message (#42888) improve the @usageNotes message by adding the word "is" (outcome: "Further information is available in...", compared to "Further information available in...") PR Close #42888 20 July 2021, 00:37:57 UTC
a6db152 JoostK 17 July 2021, 19:26:12 UTC fix(core): use correct injector when resolving DI tokens from within a directive provider factory (#42886) When a directive provides a DI token using a factory function and interacting with a standalone injector from within that factory, the standalone injector should not have access to either the directive injector nor the NgModule injector; only the standalone injector should be used. This commit ensures that a standalone injector never reaches into the directive-level injection context while resolving DI tokens. Fixes #42651 PR Close #42886 20 July 2021, 00:36:30 UTC
778edfc George Kalpakas 17 July 2021, 16:30:02 UTC fix(docs-infra): prevent main content from overlapping with ToC (#42884) Previously, if there was more content than what would horizontally fit in the main content area, it would overflow to the right and overlap with the Table of Contents (ToC). This was accidentally introduced in #42787. This commit fixes it by ensuring that the main content area will not overlap with ToC and the necessary space for the ToC will be reserved using `margin` (instead of `padding`, which contributes to the element's size). Fixes #42867 PR Close #42884 20 July 2021, 00:35:36 UTC
8989397 George Kalpakas 17 July 2021, 11:41:45 UTC fix(docs-infra): correctly handle reported errors (#42883) Error-handling in AIO happens mainly in two places: 1. For errors happening inside the app we have a custom `ErrorHandler` implementation, `ReportingErrorHandler`. `ReportingErrorHandler` passes errors to the default `ErrorHandler` (for them to be logged to the console) and also forwards them to `window.onerror()`. 2. Errors happening outside the app and errors forwarded by `ReportingErrorHandler` are handled by `window.onerror()`, which in turn reports them to Google analytics. Previously, we were making some assumptions (which turned out to be incorrect based on the info captured in Google analytics - see #28106): - `ReportingErrorHandler` assumed that the errors passed to its `handleError()` method would be either strings or `Error` instances. _Apparently, other values (such as `null` or `undefined`) may also be passed._ - `window.onerror()` assumed that if an `Error` instance was passed in, it would always have a stacktrace (i.e. its `stack` property would be defined). _This is not necessarily true, although it is not clear (based on the logs) whether reported errors of this type are caused by `Error` instance with no stacktrace or by non-string error objects which are incorrectly treated as `Error` instances. This commit ensures that all types of error arguments can be handled correctly, including `Error` instances with no stacktrace and other types of objects or primitives. NOTE: PR #42881 is related as it fixes handling `null` and `undefined` arguments in the default `ErrorHandler`. Fixes #28106 PR Close #42883 20 July 2021, 00:35:03 UTC
aeff926 Paul Gschwendtner 16 July 2021, 18:18:18 UTC feat(dev-infra): add option to setup global types in API golden test (#42876) Previously we disabled automatic type-resolution for the API extractor because in non-sandbox environments this resulted in different API reports. There are cases where global types are still needed for analysis of an entry-point. To support this, we add a new property called `types` which allows for explicit type targets being specified. Note that we do not want to determine types from the `data` runfiles because API extractor itself also brings in types which should not always be part of the API report analysis. PR Close #42876 20 July 2021, 00:33:20 UTC
24cc144 Paul Gschwendtner 16 July 2021, 17:23:09 UTC ci: remove RBE workaround from `components-repo-unit-tests` job (#42875) In the past when we had issues with our RBE instance, we wanted to get CI green as soon as possible, and couldn't wait on the components repo to land their RBE instance fix. We manually fixed the RBE instance name using a CI step using `sed`. This is no longer needed if we update to the most recent state of the components repository. PR Close #42875 20 July 2021, 00:32:44 UTC
6eea132 Paul Gschwendtner 15 July 2021, 19:23:13 UTC build: remove unnecessary husky gitignore file (#42870) We recently updated to Husky v7 through Renovate, but as of Husky v7, a `.gitignore` file is no longer needed. This commit removes the file. PR Close #42870 20 July 2021, 00:31:55 UTC
a47ea85 Paul Gschwendtner 15 July 2021, 18:39:24 UTC ci: exempt bazel scope from merge tool target label checks (#42869) Currently, changes with the `bazel` scope are guarded by the merge tool target label checks. i.e. feature commits with the `bazel` scope cannot land in the patch branch. This is expected for all public packages, but given the `bazel` package being used internal-only, it should be possible to land these in a patch branch. Especially since we want tooling to be in sync between version branches as much as possible. PR Close #42869 20 July 2021, 00:29:02 UTC
9ee4441 Joey Perrott 15 July 2021, 23:35:57 UTC fix(dev-infra): prevent verbose messaging of git checkout and commit for release (#42871) Prevent logging verbose messages to the output for commit and checkout during the release process. PR Close #42871 20 July 2021, 00:15:55 UTC
e7b3b34 Joey Perrott 15 July 2021, 23:28:26 UTC fix(dev-infra): perform actual npm login verification for wombot proxy (#42871) Previously the wombot proxy was not able to be queried for login state, now that it is able to be checked via `npm whoami` a specific alternate flow is no longer needed. PR Close #42871 20 July 2021, 00:15:54 UTC
ca2165e Joey Perrott 15 July 2021, 23:26:26 UTC refactor(dev-infra): provide entire pull request object to waitForPullRequestToBeMerged (#42871) `waitForPullRequestToBeMerged` should get the entire `PullRequest` object rather than just the id to allow it to have more information/context for logging and messaging. PR Close #42871 20 July 2021, 00:15:54 UTC
d845643 Joey Perrott 15 July 2021, 23:22:04 UTC fix(dev-infra): don't pollute standard out during commit message hooks (#42871) When a commit message is not restored, there is not need to log this to stdout. It is a better experience to silently succeed. PR Close #42871 20 July 2021, 00:15:54 UTC
8f109da dario-piotrowicz 17 July 2021, 19:35:35 UTC refactor(animations): remove unused animation trigger imports (#42763) in the animation_trigger.ts file there are unused imports remove them to clean up the file PR Close #42763 20 July 2021, 00:13:46 UTC
6de37b8 dario-piotrowicz 17 July 2021, 12:37:36 UTC refactor(animations): remove publicApi annotations from triggers (#42763) the buildTrigger function and AnimationTrigger class are annotated as publicApi which seems wrong and makes changes to the two problematic, so they are being removed here see: https://github.com/angular/angular/pull/42763/files#r671481902 PR Close #42763 20 July 2021, 00:13:46 UTC
3cddc3d dario-piotrowicz 04 July 2021, 08:57:55 UTC fix(animations): normalize final styles in buildStyles (#42763) the final styles created in buildStyles lack normalization, meaning that pixel values remain as numbers (without "px") and so such properties fail to be correctly set/applied Example: "width: 300" is applies as "width": "300" (and thus ignored) instead of the correct "width": "300px" PR Close #42763 20 July 2021, 00:13:46 UTC
0dfb4e8 dario-piotrowicz 17 July 2021, 09:53:26 UTC refactor(animations): fix typo in transition animations spec file (#42763) fix the typo "mean't" in the transition_animation_engine spec file to "meant" (the typo is simply in a code comment so the change does not have any impact) PR Close #42763 20 July 2021, 00:13:46 UTC
97fa1cf Joey Perrott 14 July 2021, 19:43:39 UTC build: add configuration for caretaker handoff (#42859) Add configuration information about groups for caretaker handoff assistant. PR Close #42859 15 July 2021, 20:34:59 UTC
9d4b580 Joey Perrott 14 July 2021, 19:43:28 UTC feat(dev-infra): create caretaker handoff assistant to update github team membership (#42859) Create a handoff assistant, currently only assists in updating github team membership for caretaking team. PR Close #42859 15 July 2021, 20:34:59 UTC
0ef8b01 Minko Gechev 13 July 2021, 23:01:01 UTC docs: remove reference to an obsolete design doc (#42842) The type checking design document is no longer relevant. This PR removes the reference to it. Close #42424. PR Close #42842 15 July 2021, 20:24:58 UTC
c06cbb2 David Shevitz 13 July 2021, 22:59:06 UTC docs: remove references to future in topic (#42841) Fixes #25704 PR Close #42841 15 July 2021, 20:23:28 UTC
688b1c5 dario-piotrowicz 03 July 2021, 10:42:39 UTC docs(docs-infra): remove unnecessary "Podcast" from happy-angular podcast's title (#42756) PR Close #42756 15 July 2021, 20:22:04 UTC
12ad314 dario-piotrowicz 03 July 2021, 10:41:40 UTC docs(docs-infra): add the angular show to the podcast resources (#42756) PR Close #42756 15 July 2021, 20:22:04 UTC
8b9aea9 dario-piotrowicz 03 July 2021, 10:24:58 UTC docs(docs-infra): podcast keys cleanup in resources.json (#42756) PR Close #42756 15 July 2021, 20:22:04 UTC
1d9d74a dario-piotrowicz 03 July 2021, 09:28:02 UTC docs(docs-infra): remove deep dive from podcast resources (#42756) PR Close #42756 15 July 2021, 20:22:03 UTC
d4567b2 JoostK 28 June 2021, 21:07:41 UTC refactor(core): expand error logging when the JIT compiler is not available (#42693) If a decorator or partial declaration has not been AOT compiled, then the compiler is needed at runtime to be able to JIT compile the code. However, it may occur that the compiler is not available, if it has not been loaded into the application. The error that was reported in this case did not provide insight into which class requested compilation, nor did it differentiate between decorators vs. partial declarations. This commit expands the error logging to provide better insight into the class that initiated JIT compilation and offers a specialized error message for partial declarations. This should help a developer better understand why the error occurs and what can be done to resolve it. Closes #40609 PR Close #42693 15 July 2021, 20:19:05 UTC
e6d520f JoostK 15 March 2021, 22:28:28 UTC perf(compiler-cli): optimize cycle detection using a persistent cache (#41271) For the compilation of a component, the compiler verifies that the imports it needs to generate to reference the used directives and pipes would not create an import cycle in the program. This requires visiting the transitive import graphs of all directive/pipe usage in search of the component file. The observation can be made that all directive/pipe usages can leverage the exploration work in search of the component file, thereby allowing sub-graphs of the import graph to be only visited once instead of repeatedly per usage. Additionally, the transitive imports of a file are no longer collected into a set to reduce memory pressure. PR Close #41271 15 July 2021, 20:13:49 UTC
e6f01d7 Krzysztof Kotowicz 08 July 2021, 11:36:54 UTC revert: docs: remove references to Trusted Types due to incompatibility with Webpack 5 (#42796) Re-add reference to Trusted Types since the issue #41754 is resolved in 12.1.1. This reverts commit 7254fbc2baa1455e3b24400597342843df3017f2. PR Close #42796 14 July 2021, 18:14:08 UTC
back to top